Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 71335,
    "url": "http://patches.dpdk.org/api/patches/71335/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200612032410.20864-12-guinanx.sun@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200612032410.20864-12-guinanx.sun@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200612032410.20864-12-guinanx.sun@intel.com",
    "date": "2020-06-12T03:24:00",
    "name": "[11/21] net/ixgbe/base: modify loop accounting for retries",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "5d8d4845ec520b43722ddbdbe6a7859c2582efac",
    "submitter": {
        "id": 1476,
        "url": "http://patches.dpdk.org/api/people/1476/?format=api",
        "name": "Guinan Sun",
        "email": "guinanx.sun@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200612032410.20864-12-guinanx.sun@intel.com/mbox/",
    "series": [
        {
            "id": 10428,
            "url": "http://patches.dpdk.org/api/series/10428/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10428",
            "date": "2020-06-12T03:23:49",
            "name": "update ixgbe base code",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/10428/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/71335/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/71335/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 754F5A00BE;\n\tFri, 12 Jun 2020 05:47:56 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D42471BED6;\n\tFri, 12 Jun 2020 05:46:30 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 7FFA11B951\n for <dev@dpdk.org>; Fri, 12 Jun 2020 05:46:26 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Jun 2020 20:46:25 -0700",
            "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 11 Jun 2020 20:46:24 -0700"
        ],
        "IronPort-SDR": [
            "\n fTJ/sOmCsMQn5YfZHpUjFEv9olm3Hgzlz3Q0mrBqP4I3GO+CA+6q/qWKg7Yydw7OBkCzvLG5x+\n d8PW3EsW8+EA==",
            "\n J2PtLqHzrBB67l2WBgEgYsycExO2wRB4DVCLBKNiQ9Ziad31uGBWTJ2aUbxlNcbhmAD24sC7DS\n 0fUeXcLmgEfQ=="
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.73,501,1583222400\"; d=\"scan'208\";a=\"289759546\"",
        "From": "Guinan Sun <guinanx.sun@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Guinan Sun <guinanx.sun@intel.com>,\n\tJeb Cramer <jeb.j.cramer@intel.com>",
        "Date": "Fri, 12 Jun 2020 03:24:00 +0000",
        "Message-Id": "<20200612032410.20864-12-guinanx.sun@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200612032410.20864-1-guinanx.sun@intel.com>",
        "References": "<20200612032410.20864-1-guinanx.sun@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 11/21] net/ixgbe/base: modify loop accounting for\n\tretries",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The condition for comparing retry against max_retry was flawed in the\ndo-while loops.  For the case where retry was initialized to 0 and\nmax_retry was initialized to 1, we'd break out of the loop at the\ncondition when the intent is to retry the code at least once.\nOtherwise, the loop is unnecessary.  The other places have a larger\nmax_retry so code would get run multiple times (if necessary), but not\nto the intended extent.\n\nSigned-off-by: Jeb Cramer <jeb.j.cramer@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_phy.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c\nindex 9bb24f1ef..823cf161e 100644\n--- a/drivers/net/ixgbe/base/ixgbe_phy.c\n+++ b/drivers/net/ixgbe/base/ixgbe_phy.c\n@@ -143,7 +143,7 @@ s32 ixgbe_read_i2c_combined_generic_int(struct ixgbe_hw *hw, u8 addr, u16 reg,\n \t\telse\n \t\t\tDEBUGOUT(\"I2C byte read combined error.\\n\");\n \t\tretry++;\n-\t} while (retry < max_retry);\n+\t} while (retry <= max_retry);\n \n \treturn IXGBE_ERR_I2C;\n }\n@@ -208,7 +208,7 @@ s32 ixgbe_write_i2c_combined_generic_int(struct ixgbe_hw *hw, u8 addr, u16 reg,\n \t\telse\n \t\t\tDEBUGOUT(\"I2C byte write combined error.\\n\");\n \t\tretry++;\n-\t} while (retry < max_retry);\n+\t} while (retry <= max_retry);\n \n \treturn IXGBE_ERR_I2C;\n }\n@@ -2062,7 +2062,7 @@ STATIC s32 ixgbe_read_i2c_byte_generic_int(struct ixgbe_hw *hw, u8 byte_offset,\n \t\telse\n \t\t\tDEBUGOUT(\"I2C byte read error.\\n\");\n \t\tretry++;\n-\t} while (retry < max_retry);\n+\t} while (retry <= max_retry);\n \n \treturn status;\n }\n@@ -2165,7 +2165,7 @@ STATIC s32 ixgbe_write_i2c_byte_generic_int(struct ixgbe_hw *hw, u8 byte_offset,\n \t\telse\n \t\t\tDEBUGOUT(\"I2C byte write error.\\n\");\n \t\tretry++;\n-\t} while (retry < max_retry);\n+\t} while (retry <= max_retry);\n \n \tif (lock)\n \t\thw->mac.ops.release_swfw_sync(hw, swfw_mask);\n",
    "prefixes": [
        "11/21"
    ]
}