Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71163/?format=api
{ "id": 71163, "url": "http://patches.dpdk.org/api/patches/71163/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200610114427.22146-28-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200610114427.22146-28-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200610114427.22146-28-somnath.kotur@broadcom.com", "date": "2020-06-10T11:44:18", "name": "[27/36] net/bnxt: parse ipv6 vtc_flow field for more granularly", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b2f44165d6345cbccd72496b57af787f6a22b682", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200610114427.22146-28-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 10380, "url": "http://patches.dpdk.org/api/series/10380/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10380", "date": "2020-06-10T11:43:51", "name": "bnxt patches", "version": 1, "mbox": "http://patches.dpdk.org/series/10380/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/71163/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/71163/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 85E18A051B;\n\tWed, 10 Jun 2020 13:53:56 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 364C91BF9C;\n\tWed, 10 Jun 2020 13:49:34 +0200 (CEST)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.232.149]) by dpdk.org (Postfix) with ESMTP id 2225A1BF84\n for <dev@dpdk.org>; Wed, 10 Jun 2020 13:49:31 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 741711BD53A;\n Wed, 10 Jun 2020 04:49:30 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 741711BD53A", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1591789771;\n bh=9nU+KzgiI96cEaZ2dUouUqSUeeCMDDAMNa2Upbdl0ak=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=nhqeJcB2bd4SmmkQeroH2D60novdFAP4i2d0xw5lGbhnO6fc1MzKSUryVooTao6mu\n 6St2OlnibqOjcJ070DGNpQoFSM0AIzujW7OtgVWaqj0jaLEjtKVRf4xInvWaUTfaKV\n vgU/K4OvcENyD7Q0EbFX0SKLuXlFCS/P0u5V0s+Y=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Wed, 10 Jun 2020 17:14:18 +0530", "Message-Id": "<20200610114427.22146-28-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200610114427.22146-1-somnath.kotur@broadcom.com>", "References": "<20200610114427.22146-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 27/36] net/bnxt: parse ipv6 vtc_flow field for\n\tmore granularly", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n\nipv6 vtc_flow contains three fields\n1. Version\n2. Priority / Traffic Class\n3. Flow Label\nCurrently, these are not parsed separately and also not set separately\nin the field bitmap by the flow parser. However, the template treats\nthem separately. As a result, the flow matching doesn't succeed because\nthe bitmaps of parser and the template doesn't match.\n\nThis patch fixes this problem by parsing the above mentioned fields\nindividually to align with the template.\n\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Michael Baucom <michael.baucom@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 37 ++++++++++++++++++++++++---\n drivers/net/bnxt/tf_ulp/ulp_rte_parser.h | 10 ++++++++\n drivers/net/bnxt/tf_ulp/ulp_template_struct.h | 2 +-\n 3 files changed, 44 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\nindex 3dd941f..ec576a9 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n@@ -598,6 +598,7 @@ ulp_rte_ipv6_hdr_handler(const struct rte_flow_item *item,\n \tuint32_t idx = params->field_idx;\n \tuint32_t size;\n \tuint32_t inner_l3, outer_l3;\n+\tuint32_t vtcf, vtcf_mask;\n \n \tinner_l3 = ULP_COMP_FLD_IDX_RD(params, BNXT_ULP_CF_IDX_I_L3);\n \tif (inner_l3) {\n@@ -606,14 +607,27 @@ ulp_rte_ipv6_hdr_handler(const struct rte_flow_item *item,\n \t}\n \n \t/*\n-\t * Copy the rte_flow_item for ipv4 into hdr_field using ipv4\n+\t * Copy the rte_flow_item for ipv6 into hdr_field using ipv6\n \t * header fields\n \t */\n \tif (ipv6_spec) {\n \t\tsize = sizeof(ipv6_spec->hdr.vtc_flow);\n+\n+\t\tvtcf = BNXT_ULP_GET_IPV6_VER(ipv6_spec->hdr.vtc_flow);\n \t\tfield = ulp_rte_parser_fld_copy(¶ms->hdr_field[idx],\n-\t\t\t\t\t\t&ipv6_spec->hdr.vtc_flow,\n+\t\t\t\t\t\t&vtcf,\n+\t\t\t\t\t\tsize);\n+\n+\t\tvtcf = BNXT_ULP_GET_IPV6_TC(ipv6_spec->hdr.vtc_flow);\n+\t\tfield = ulp_rte_parser_fld_copy(field,\n+\t\t\t\t\t\t&vtcf,\n+\t\t\t\t\t\tsize);\n+\n+\t\tvtcf = BNXT_ULP_GET_IPV6_FLOWLABEL(ipv6_spec->hdr.vtc_flow);\n+\t\tfield = ulp_rte_parser_fld_copy(field,\n+\t\t\t\t\t\t&vtcf,\n \t\t\t\t\t\tsize);\n+\n \t\tsize = sizeof(ipv6_spec->hdr.payload_len);\n \t\tfield = ulp_rte_parser_fld_copy(field,\n \t\t\t\t\t\t&ipv6_spec->hdr.payload_len,\n@@ -636,9 +650,24 @@ ulp_rte_ipv6_hdr_handler(const struct rte_flow_item *item,\n \t\t\t\t\t\tsize);\n \t}\n \tif (ipv6_mask) {\n+\t\tsize = sizeof(ipv6_mask->hdr.vtc_flow);\n+\n+\t\tvtcf_mask = BNXT_ULP_GET_IPV6_VER(ipv6_mask->hdr.vtc_flow);\n+\t\tulp_rte_prsr_mask_copy(params, &idx,\n+\t\t\t\t &vtcf_mask,\n+\t\t\t\t size);\n+\n+\t\tvtcf_mask = BNXT_ULP_GET_IPV6_TC(ipv6_mask->hdr.vtc_flow);\n \t\tulp_rte_prsr_mask_copy(params, &idx,\n-\t\t\t\t &ipv6_mask->hdr.vtc_flow,\n-\t\t\t\t sizeof(ipv6_mask->hdr.vtc_flow));\n+\t\t\t\t &vtcf_mask,\n+\t\t\t\t size);\n+\n+\t\tvtcf_mask =\n+\t\t\tBNXT_ULP_GET_IPV6_FLOWLABEL(ipv6_mask->hdr.vtc_flow);\n+\t\tulp_rte_prsr_mask_copy(params, &idx,\n+\t\t\t\t &vtcf_mask,\n+\t\t\t\t size);\n+\n \t\tulp_rte_prsr_mask_copy(params, &idx,\n \t\t\t\t &ipv6_mask->hdr.payload_len,\n \t\t\t\t sizeof(ipv6_mask->hdr.payload_len));\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.h b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.h\nindex 868e6dc..c90bff4 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.h\n+++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.h\n@@ -21,6 +21,16 @@\n #define BNXT_ULP_ENCAP_UDP_SIZE\t\t\t4\n #define BNXT_ULP_INVALID_SVIF_VAL\t\t-1U\n \n+#define\tBNXT_ULP_GET_IPV6_VER(vtcf)\t\t\\\n+\t\t\t(((vtcf) & BNXT_ULP_PARSER_IPV6_VER_MASK) >> 28)\n+#define\tBNXT_ULP_GET_IPV6_TC(vtcf)\t\t\\\n+\t\t\t(((vtcf) & BNXT_ULP_PARSER_IPV6_TC) >> 20)\n+#define\tBNXT_ULP_GET_IPV6_FLOWLABEL(vtcf)\t\\\n+\t\t\t((vtcf) & BNXT_ULP_PARSER_IPV6_FLOW_LABEL)\n+#define\tBNXT_ULP_PARSER_IPV6_VER_MASK\t\t0xf0000000\n+#define\tBNXT_ULP_PARSER_IPV6_TC\t\t\t0x0ff00000\n+#define\tBNXT_ULP_PARSER_IPV6_FLOW_LABEL\t\t0x000fffff\n+\n /* Function to handle the parsing of the RTE port id. */\n int32_t\n ulp_rte_parser_svif_process(struct ulp_rte_parser_params *params);\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_template_struct.h b/drivers/net/bnxt/tf_ulp/ulp_template_struct.h\nindex 9b1bdbb..36bf5a4 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_template_struct.h\n+++ b/drivers/net/bnxt/tf_ulp/ulp_template_struct.h\n@@ -23,7 +23,7 @@\n #define BNXT_ULP_PROTO_HDR_S_VLAN_NUM\t3\n #define BNXT_ULP_PROTO_HDR_VLAN_NUM\t6\n #define BNXT_ULP_PROTO_HDR_IPV4_NUM\t10\n-#define BNXT_ULP_PROTO_HDR_IPV6_NUM\t6\n+#define BNXT_ULP_PROTO_HDR_IPV6_NUM\t8\n #define BNXT_ULP_PROTO_HDR_UDP_NUM\t4\n #define BNXT_ULP_PROTO_HDR_TCP_NUM\t9\n #define BNXT_ULP_PROTO_HDR_VXLAN_NUM\t4\n", "prefixes": [ "27/36" ] }