Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70726/?format=api
{ "id": 70726, "url": "http://patches.dpdk.org/api/patches/70726/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200601180229.26566-2-akhil.goyal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200601180229.26566-2-akhil.goyal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200601180229.26566-2-akhil.goyal@nxp.com", "date": "2020-06-01T18:02:29", "name": "[2/2] test/crypto: enable hfn override in PDCP cases", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bac46f27bdc934ff3156a042702b595792c6f634", "submitter": { "id": 517, "url": "http://patches.dpdk.org/api/people/517/?format=api", "name": "Akhil Goyal", "email": "akhil.goyal@nxp.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200601180229.26566-2-akhil.goyal@nxp.com/mbox/", "series": [ { "id": 10287, "url": "http://patches.dpdk.org/api/series/10287/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10287", "date": "2020-06-01T18:02:28", "name": "[1/2] drivers/crypto: fix 18bit PDCP cases with HFN override", "version": 1, "mbox": "http://patches.dpdk.org/series/10287/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70726/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/70726/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E4CDAA04EF;\n\tMon, 1 Jun 2020 20:03:12 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C29491BFF5;\n\tMon, 1 Jun 2020 20:03:12 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 18F491BFE2\n for <dev@dpdk.org>; Mon, 1 Jun 2020 20:03:11 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 9ABD52007A4;\n Mon, 1 Jun 2020 20:03:10 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id C211E20058B;\n Mon, 1 Jun 2020 20:03:08 +0200 (CEST)", "from lsv03273.swis.in-blr01.nxp.com (lsv03273.swis.in-blr01.nxp.com\n [92.120.147.113])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 7BA70402DF;\n Tue, 2 Jun 2020 02:03:06 +0800 (SGT)" ], "From": "Akhil Goyal <akhil.goyal@nxp.com>", "To": "dev@dpdk.org", "Cc": "hemant.agrawal@nxp.com,\n\tAkhil Goyal <akhil.goyal@nxp.com>", "Date": "Mon, 1 Jun 2020 23:32:29 +0530", "Message-Id": "<20200601180229.26566-2-akhil.goyal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200601180229.26566-1-akhil.goyal@nxp.com>", "References": "<20200601180229.26566-1-akhil.goyal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 2/2] test/crypto: enable hfn override in PDCP\n\tcases", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As most of the real woeld use cases need HFN value to\nbe updated on per packet basis, changing the default\ntesting with HFN override enabled for all PDCP cases.\n\nSigned-off-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n app/test-crypto-perf/cperf_ops.c | 10 +++++++---\n app/test/test_cryptodev.c | 13 +++++++++++--\n 2 files changed, 18 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c\nindex 97584ceed..847982219 100644\n--- a/app/test-crypto-perf/cperf_ops.c\n+++ b/app/test-crypto-perf/cperf_ops.c\n@@ -25,6 +25,10 @@ cperf_set_ops_security(struct rte_crypto_op **ops,\n \t\tstruct rte_security_session *sec_sess =\n \t\t\t(struct rte_security_session *)sess;\n \n+\t\tuint32_t *per_pkt_hfn = rte_crypto_op_ctod_offset(ops[i],\n+\t\t\t\t\tuint32_t *, iv_offset);\n+\t\t*per_pkt_hfn = 0x1;\n+\n \t\tops[i]->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;\n \t\trte_security_attach_session(ops[i], sec_sess);\n \t\tsym_op->m_src = (struct rte_mbuf *)((uint8_t *)ops[i] +\n@@ -529,16 +533,15 @@ cperf_create_session(struct rte_mempool *sess_mp,\n \t\tcipher_xform.cipher.algo = options->cipher_algo;\n \t\tcipher_xform.cipher.op = options->cipher_op;\n \t\tcipher_xform.cipher.iv.offset = iv_offset;\n+\t\tcipher_xform.cipher.iv.length = 4;\n \n \t\t/* cipher different than null */\n \t\tif (options->cipher_algo != RTE_CRYPTO_CIPHER_NULL) {\n \t\t\tcipher_xform.cipher.key.data = test_vector->cipher_key.data;\n \t\t\tcipher_xform.cipher.key.length = test_vector->cipher_key.length;\n-\t\t\tcipher_xform.cipher.iv.length = test_vector->cipher_iv.length;\n \t\t} else {\n \t\t\tcipher_xform.cipher.key.data = NULL;\n \t\t\tcipher_xform.cipher.key.length = 0;\n-\t\t\tcipher_xform.cipher.iv.length = 0;\n \t\t}\n \n \t\t/* Setup Auth Parameters */\n@@ -576,8 +579,9 @@ cperf_create_session(struct rte_mempool *sess_mp,\n \t\t\t\t.domain = options->pdcp_domain,\n \t\t\t\t.pkt_dir = 0,\n \t\t\t\t.sn_size = options->pdcp_sn_sz,\n-\t\t\t\t.hfn = 0x1,\n+\t\t\t\t.hfn = 0x0,\n \t\t\t\t.hfn_threshold = 0x70C0A,\n+\t\t\t\t.hfn_ovrd = 1,\n \t\t\t} },\n \t\t\t.crypto_xform = &cipher_xform\n \t\t};\ndiff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 8f631468b..f4ed89c1c 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -7385,7 +7385,8 @@ test_pdcp_proto_SGL(int i, int oop,\n \tut_params->cipher_xform.cipher.key.data = pdcp_test_crypto_key[i];\n \tut_params->cipher_xform.cipher.key.length =\n \t\t\t\t\tpdcp_test_params[i].cipher_key_len;\n-\tut_params->cipher_xform.cipher.iv.length = 0;\n+\tut_params->cipher_xform.cipher.iv.length = 4;\n+\tut_params->cipher_xform.cipher.iv.offset = IV_OFFSET;\n \n \t/* Setup HMAC Parameters if ICV header is required */\n \tif (pdcp_test_params[i].auth_alg != 0) {\n@@ -7410,8 +7411,12 @@ test_pdcp_proto_SGL(int i, int oop,\n \t\t\t.domain = pdcp_test_params[i].domain,\n \t\t\t.pkt_dir = pdcp_test_packet_direction[i],\n \t\t\t.sn_size = pdcp_test_data_sn_size[i],\n-\t\t\t.hfn = pdcp_test_hfn[i],\n+\t\t\t.hfn = 0, /**\n+\t\t\t\t * hfn can be set as pdcp_test_hfn[i]\n+\t\t\t\t * if hfn_ovrd is not set\n+\t\t\t\t */\n \t\t\t.hfn_threshold = pdcp_test_hfn_threshold[i],\n+\t\t\t.hfn_ovrd = 1,\n \t\t} },\n \t\t.crypto_xform = &ut_params->cipher_xform\n \t};\n@@ -7438,6 +7443,10 @@ test_pdcp_proto_SGL(int i, int oop,\n \t\tgoto on_err;\n \t}\n \n+\tuint32_t *per_pkt_hfn = rte_crypto_op_ctod_offset(ut_params->op,\n+\t\t\t\t\tuint32_t *, IV_OFFSET);\n+\t*per_pkt_hfn = pdcp_test_hfn[i];\n+\n \trte_security_attach_session(ut_params->op, ut_params->sec_session);\n \n \t/* set crypto operation source mbuf */\n", "prefixes": [ "2/2" ] }