Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70535/?format=api
{ "id": 70535, "url": "http://patches.dpdk.org/api/patches/70535/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200522173254.18643-2-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200522173254.18643-2-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200522173254.18643-2-kalesh-anakkur.purayil@broadcom.com", "date": "2020-05-22T17:32:53", "name": "[1/2] net/bnxt: fix the check for validating link speed", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ac9ad4bcc32fa3a19f3f38e7dd769372eca07536", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200522173254.18643-2-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 10209, "url": "http://patches.dpdk.org/api/series/10209/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10209", "date": "2020-05-22T17:32:52", "name": "bnxt bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/10209/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70535/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/70535/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 50514A04A2;\n\tFri, 22 May 2020 19:17:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D79351D9F3;\n\tFri, 22 May 2020 19:17:18 +0200 (CEST)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.232.149]) by dpdk.org (Postfix) with ESMTP id E63CD1D9F0\n for <dev@dpdk.org>; Fri, 22 May 2020 19:17:07 +0200 (CEST)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 154D01BFEE2;\n Fri, 22 May 2020 10:17:01 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 154D01BFEE2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1590167823;\n bh=1XjBMCd7TZqkSUBfJBp5MQwGoEVBF6+Udb/7xh5N3H4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=QkCe7vniiq3XCjqdMBN7FcVNwPNnDWGmAA3Jg5K+d1XVx0XZFyWTjS7LZooa4vUGt\n Kz8+M47djhpb4CNLP+EWz13+8ErTdGQXq+N2t/v8KHqEQPwemwm/IcXEagrp03mxAn\n B4yuVHCWTi5NgTgOQpa6pZkWfonCcfPK+MBLfOQU=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Fri, 22 May 2020 23:02:53 +0530", "Message-Id": "<20200522173254.18643-2-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20200522173254.18643-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20200522173254.18643-1-kalesh-anakkur.purayil@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] =?utf-8?q?_=5BPATCH_1/2=5D_net/bnxt=3A_fix_the_check_for?=\n\t=?utf-8?q?_validating=C2=A0link_speed?=", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nbnxt PMD uses the macro BNXT_SUPPORTED_SPEEDS to validate\nthe user requested speed. But this has all the speed values\nsupported by the PMD and is not chip specific.\n\nThe check against this macro returns success when the user\ntries set the speed to 100G on a port even if the chip does\nnot support 100G speed.\n\nFixed it to use bnxt_get_speed_capabilities() to check the\nsupported speeds by the chip.\n\nFixes: 1d0704f4d793 (\"net/bnxt: add device configure operation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_ethdev.c | 2 +-\n drivers/net/bnxt/bnxt_hwrm.c | 14 +++++++++-----\n 3 files changed, 11 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 446764c..2c3aef6 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -780,4 +780,5 @@ void bnxt_cancel_fc_thread(struct bnxt *bp);\n void bnxt_flow_cnt_alarm_cb(void *arg);\n int bnxt_flow_stats_req(struct bnxt *bp);\n int bnxt_flow_stats_cnt(struct bnxt *bp);\n+uint32_t bnxt_get_speed_capabilities(struct bnxt *bp);\n #endif\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex ae495da..e635781 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -778,7 +778,7 @@ static int bnxt_shutdown_nic(struct bnxt *bp)\n * Device configuration and status function\n */\n \n-static uint32_t bnxt_get_speed_capabilities(struct bnxt *bp)\n+uint32_t bnxt_get_speed_capabilities(struct bnxt *bp)\n {\n \tuint32_t link_speed = bp->link_info->support_speeds;\n \tuint32_t speed_capa = 0;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex c1798b5..945bc90 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -2788,13 +2788,18 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed)\n \t\tETH_LINK_SPEED_40G | ETH_LINK_SPEED_50G | \\\n \t\tETH_LINK_SPEED_100G | ETH_LINK_SPEED_200G)\n \n-static int bnxt_valid_link_speed(uint32_t link_speed, uint16_t port_id)\n+static int bnxt_validate_link_speed(struct bnxt *bp)\n {\n+\tuint32_t link_speed = bp->eth_dev->data->dev_conf.link_speeds;\n+\tuint16_t port_id = bp->eth_dev->data->port_id;\n+\tuint32_t link_speed_capa;\n \tuint32_t one_speed;\n \n \tif (link_speed == ETH_LINK_SPEED_AUTONEG)\n \t\treturn 0;\n \n+\tlink_speed_capa = bnxt_get_speed_capabilities(bp);\n+\n \tif (link_speed & ETH_LINK_SPEED_FIXED) {\n \t\tone_speed = link_speed & ~ETH_LINK_SPEED_FIXED;\n \n@@ -2804,14 +2809,14 @@ static int bnxt_valid_link_speed(uint32_t link_speed, uint16_t port_id)\n \t\t\t\tlink_speed, port_id);\n \t\t\treturn -EINVAL;\n \t\t}\n-\t\tif ((one_speed & BNXT_SUPPORTED_SPEEDS) != one_speed) {\n+\t\tif ((one_speed & link_speed_capa) != one_speed) {\n \t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\t\"Unsupported advertised speed (%u) for port %u\\n\",\n \t\t\t\tlink_speed, port_id);\n \t\t\treturn -EINVAL;\n \t\t}\n \t} else {\n-\t\tif (!(link_speed & BNXT_SUPPORTED_SPEEDS)) {\n+\t\tif (!(link_speed & link_speed_capa)) {\n \t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\t\"Unsupported advertised speeds (%u) for port %u\\n\",\n \t\t\t\tlink_speed, port_id);\n@@ -2957,8 +2962,7 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up)\n \tif (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp))\n \t\treturn 0;\n \n-\trc = bnxt_valid_link_speed(dev_conf->link_speeds,\n-\t\t\tbp->eth_dev->data->port_id);\n+\trc = bnxt_validate_link_speed(bp);\n \tif (rc)\n \t\tgoto error;\n \n", "prefixes": [ "1/2" ] }