Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69790/?format=api
{ "id": 69790, "url": "http://patches.dpdk.org/api/patches/69790/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200505214105.19465-2-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200505214105.19465-2-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200505214105.19465-2-l.wojciechow@partner.samsung.com", "date": "2020-05-05T21:41:05", "name": "[2/2] crypto/dpaa_sec: repair memory allocations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3f6fc8921007002ac30de1ebbb619e6fe766403b", "submitter": { "id": 1628, "url": "http://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200505214105.19465-2-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 9846, "url": "http://patches.dpdk.org/api/series/9846/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9846", "date": "2020-05-05T21:41:04", "name": "[1/2] crypto/dpaa_sec: improve memory freeing", "version": 1, "mbox": "http://patches.dpdk.org/series/9846/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69790/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/69790/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E532FA0352;\n\tTue, 5 May 2020 23:41:41 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 424C21D6F0;\n\tTue, 5 May 2020 23:41:34 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 7CE401D6E5\n for <dev@dpdk.org>; Tue, 5 May 2020 23:41:32 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200505214131euoutp028bab58f74f26f5d2ef664f472519d249~MP8bHuwFt1709617096euoutp02k\n for <dev@dpdk.org>; Tue, 5 May 2020 21:41:31 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200505214130eucas1p1f3cd16fe55b995204f61fe958716f2f5~MP8aiPmE61106811068eucas1p1l;\n Tue, 5 May 2020 21:41:30 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id C4.91.61286.A8DD1BE5; Tue, 5\n May 2020 22:41:30 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200505214129eucas1p146b40738c440b77ee0131d18a80eea3d~MP8ZWxdR20907709077eucas1p1k;\n Tue, 5 May 2020 21:41:29 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200505214129eusmtrp23d36fd4c35038f673f349f68267c86a9~MP8ZWNO7Z0253702537eusmtrp2L;\n Tue, 5 May 2020 21:41:29 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id C4.30.07950.98DD1BE5; Tue, 5\n May 2020 22:41:29 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200505214129eusmtip165d780021c665cf78bf9a3a64fbec339~MP8Yyc7Ko2481324813eusmtip19;\n Tue, 5 May 2020 21:41:28 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200505214131euoutp028bab58f74f26f5d2ef664f472519d249~MP8bHuwFt1709617096euoutp02k", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1588714891;\n bh=v0xLy1y9X8L/xXHb87ZwSADsZVo4Ewg3nURJfNjlCnw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=sfJJOhHBMKR8R42cIA/EsA3XnGqag9jDOhHperjkH7fw6nmC5B70YDVqQbgrmZsWz\n nGVbhJ3hAyL0sN4+5XRVCWImftX+GsC6t4LE5HeZU7dKqh4Fm1Gg8rFsOdT2PTnFrA\n Z7wrKTb7FEHgKgUiYnudlwLEv2zwLzs7+cjbTiZY=", "X-AuditID": "cbfec7f2-f0bff7000001ef66-73-5eb1dd8af15a", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com>", "Cc": "dev@dpdk.org, l.wojciechow@partner.samsung.com", "Date": "Tue, 5 May 2020 23:41:05 +0200", "Message-Id": "<20200505214105.19465-2-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200505214105.19465-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsWy7djP87pddzfGGZzeYmSx/sw8Rot3n7Yz\n Wax8vJHN4lnPOkYHFo9fC5ayemx8t4PJ4+C7PUwBzFFcNimpOZllqUX6dglcGZO+drMU7BCo\n OPFzPksD4zreLkZODgkBE4nWH//Zuxi5OIQEVjBK/Hn9jxnC+cIo0d7xgwXC+cwocejgCnaY\n lo+97VCJ5UBV+z6yw1Xd3vGQFaSKTcBW4sjMr2C2iECAxPWuPWwgNrOAkcTL7olAOzg4hAXs\n JXpOOIOEWQRUJe52zwAr5xVwlfg6+SYTxDJ5idUbDjCD2JwCbhKPLt5hA9klIXCGTeLmmVWs\n EEUuEjM+n4eyhSVeHd8CdamMxP+d85kgGrYxSlz9/ZMRwtnPKHG9F+Yfa4nD/36zgVzELKAp\n sX6XPogpIeAo0T9BGMLkk7jxVhDifD6JSdumM0OEeSU62oQgZuhJPO2Zygiz9c/aJywQtofE\n qS9voSE6k1Hi5YrJzBMY5Wch7FrAyLiKUTy1tDg3PbXYMC+1XK84Mbe4NC9dLzk/dxMjMOpP\n /zv+aQfj10tJhxgFOBiVeHgN3DfGCbEmlhVX5h5ilOBgVhLhXfZjQ5wQb0piZVVqUX58UWlO\n avEhRmkOFiVxXuNFL2OFBNITS1KzU1MLUotgskwcnFINjDV7V3lleEdL7/6nxLXeV3Gj/4VN\n le9vLvGXX8d2/Ufv9SPv7F667T6+27m/ZNMF79nG8xO/N4mZvLDe6V3w/fEFd8FCqYvit2et\n TmIsPNT4xVn4XN2ixbP3P7dtbO3tasveVrM8XjLdRX8Gp7XNS/H7CzkY9m8U8/v/WVz3r3Px\n dP8Fnwon7FJiKc5INNRiLipOBABvI9oq9gIAAA==", "\n H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsVy+t/xu7qddzfGGRyYo2Cx/sw8Rot3n7Yz\n Wax8vJHN4lnPOkYHFo9fC5ayemx8t4PJ4+C7PUwBzFF6NkX5pSWpChn5xSW2StGGFkZ6hpYW\n ekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6GZO+drMU7BCoOPFzPksD4zreLkZODgkBE4mP\n ve0sXYxcHEICSxklZp/qZOti5ABKyEh8uCQAUSMs8edaFxtEzUdGiX/zbjCCJNgEbCWOzPzK\n CmKLCARIfF90gQ3EZgYaenteE9gcYQF7iZ4TziBhFgFVibvdM8DKeQVcJb5OvskEMV9eYvWG\n A8wgNqeAm8Sji3fAxggB1cz61sA6gZFvASPDKkaR1NLi3PTcYiO94sTc4tK8dL3k/NxNjMAA\n 3Hbs55YdjF3vgg8xCnAwKvHwGrhvjBNiTSwrrsw9xCjBwawkwrvsx4Y4Id6UxMqq1KL8+KLS\n nNTiQ4ymQEdNZJYSTc4HRkdeSbyhqaG5haWhubG5sZmFkjhvh8DBGCGB9MSS1OzU1ILUIpg+\n Jg5OqQZGHu+Lxj/E1BYV1ur/sfHcLPot9770tijFVXVXf164K9DdoP26+IHnIWt3pSVzPsmd\n 79csP9XfFjlZWe6wJIuYqlqJG9dTnpd3z35+/ZypzrHY9/U9ge7e/Nj5Bj050RqmzEK7qmQD\n D81QqXz9sNzooq/os+I1xzaWOnhqqO4oMGlZtKVpg4MSS3FGoqEWc1FxIgBCAhtlVgIAAA==" ], "X-CMS-MailID": "20200505214129eucas1p146b40738c440b77ee0131d18a80eea3d", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200505214129eucas1p146b40738c440b77ee0131d18a80eea3d", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200505214129eucas1p146b40738c440b77ee0131d18a80eea3d", "References": "<20200505214105.19465-1-l.wojciechow@partner.samsung.com>\n <CGME20200505214129eucas1p146b40738c440b77ee0131d18a80eea3d@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH 2/2] crypto/dpaa_sec: repair memory allocations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch repairs 2 memory allocations issues:\n\n1) possible leak of memory\n In cryptodev_dpaa_sec_probe() function in case of portal\n initialization failure, function exited without cleanup.\n\n The patch redirects flow to out label, which provides\n proper cleanup in case of error: freeing cryptodevice private\n data and releasing cryptodevice.\n\n2) double free of cryptodev private data\n The function dpaa_sec_dev_init() in case of failure called\n dpaa_sec_uninit() which freed both private data and security\n context. However one layer above in cryptodev_dpaa_sec_probe()\n function, the private data were freed one more time.\n\n The patch limits cleanup of the dpaa_sec_dev_init() function\n to freeing only the security context.\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c\nindex 021a5639d..097ab8de9 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.c\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c\n@@ -3410,7 +3410,7 @@ dpaa_sec_dev_init(struct rte_cryptodev *cryptodev)\n init_error:\n \tDPAA_SEC_ERR(\"driver %s: create failed\\n\", cryptodev->data->name);\n \n-\tdpaa_sec_uninit(cryptodev);\n+\trte_free(cryptodev->security_ctx);\n \treturn -EFAULT;\n }\n \n@@ -3467,7 +3467,7 @@ cryptodev_dpaa_sec_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused,\n \t\tretval = rte_dpaa_portal_init((void *)1);\n \t\tif (retval) {\n \t\t\tDPAA_SEC_ERR(\"Unable to initialize portal\");\n-\t\t\treturn retval;\n+\t\t\tgoto out;\n \t\t}\n \t}\n \n@@ -3476,13 +3476,15 @@ cryptodev_dpaa_sec_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused,\n \tif (retval == 0)\n \t\treturn 0;\n \n+\tretval = -ENXIO;\n+out:\n \t/* In case of error, cleanup is done */\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n \t\trte_free(cryptodev->data->dev_private);\n \n \trte_cryptodev_pmd_release_device(cryptodev);\n \n-\treturn -ENXIO;\n+\treturn retval;\n }\n \n static int\n", "prefixes": [ "2/2" ] }