Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69599/?format=api
{ "id": 69599, "url": "http://patches.dpdk.org/api/patches/69599/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/f98eb89eb043810e5b4c523a51408a2c053cf490.1588243784.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<f98eb89eb043810e5b4c523a51408a2c053cf490.1588243784.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f98eb89eb043810e5b4c523a51408a2c053cf490.1588243784.git.anatoly.burakov@intel.com", "date": "2020-04-30T10:49:48", "name": "[v2] l3fwd-power: add Rx interrupt timeout", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a447d00f27f6174488f811fafa4870f5f7428e21", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/f98eb89eb043810e5b4c523a51408a2c053cf490.1588243784.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 9762, "url": "http://patches.dpdk.org/api/series/9762/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9762", "date": "2020-04-30T10:49:48", "name": "[v2] l3fwd-power: add Rx interrupt timeout", "version": 2, "mbox": "http://patches.dpdk.org/series/9762/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69599/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/69599/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 90BAAA00C5;\n\tThu, 30 Apr 2020 12:49:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BFC0E1DB56;\n\tThu, 30 Apr 2020 12:49:54 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id 2B5941DB3D;\n Thu, 30 Apr 2020 12:49:52 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2020 03:49:51 -0700", "from aburakov-mobl.ger.corp.intel.com (HELO ubuntu-vm.mshome.net)\n ([10.249.32.101])\n by orsmga006.jf.intel.com with ESMTP; 30 Apr 2020 03:49:49 -0700" ], "IronPort-SDR": [ "\n rDH2HbuVdEqrseXnXIctlbLJ1NIRSRArFlovSD3tU51nOxbo7gLGOW4Q4gQArQBCuR/dxU3shK\n HsSdJ1sPi5LQ==", "\n fEYXDrDqqVjaAMXWLcdXchj3xyWF5eMBYd8aUy2eu7LP7q3u5U3gwVAzQLQxaVMuwYAflio647\n 5tGSWbs/eKsw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,334,1583222400\"; d=\"scan'208\";a=\"261736201\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "David Hunt <david.hunt@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 30 Apr 2020 10:49:48 +0000", "Message-Id": "\n <f98eb89eb043810e5b4c523a51408a2c053cf490.1588243784.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "\n <0ebd62205da8cd9964dcd370a69cc5a38f54dede.1588162894.git.anatoly.burakov@intel.com>", "References": "\n <0ebd62205da8cd9964dcd370a69cc5a38f54dede.1588162894.git.anatoly.burakov@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] l3fwd-power: add Rx interrupt timeout", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, thread waiting on an interrupt does not have a timeout, so\nit will not ever wake up until traffic arrives. This means that, when\ntime comes to exit the application, it will not quit unless there\nhappens to be traffic coming in and waking up the thread from sleep.\n\nFix it so that the interrupt thread sleeps for 10ms before waking up\nand attempting to poll again. Additionally, remove the log message\nto avoid spamming about entering interrupt mode.\n\nFixes: 613ce6691c0d (\"examples/l3fwd-power: implement proper shutdown\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n examples/l3fwd-power/main.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex 293b3da4ae..21fb15e1a2 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -829,11 +829,7 @@ sleep_until_rx_interrupt(int num)\n \tuint8_t queue_id;\n \tvoid *data;\n \n-\tRTE_LOG(INFO, L3FWD_POWER,\n-\t\t\"lcore %u sleeps until interrupt triggers\\n\",\n-\t\trte_lcore_id());\n-\n-\tn = rte_epoll_wait(RTE_EPOLL_PER_THREAD, event, num, -1);\n+\tn = rte_epoll_wait(RTE_EPOLL_PER_THREAD, event, num, 10);\n \tfor (i = 0; i < n; i++) {\n \t\tdata = event[i].epdata.data;\n \t\tport_id = ((uintptr_t)data) >> CHAR_BIT;\n@@ -1306,7 +1302,8 @@ main_loop(__rte_unused void *dummy)\n \t\t\t\t\t/**\n \t\t\t\t\t * start receiving packets immediately\n \t\t\t\t\t */\n-\t\t\t\t\tgoto start_rx;\n+\t\t\t\t\tif (likely(!is_done()))\n+\t\t\t\t\t\tgoto start_rx;\n \t\t\t\t}\n \t\t\t}\n \t\t\tstats[lcore_id].sleep_time += lcore_idle_hint;\n", "prefixes": [ "v2" ] }