Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69154/?format=api
{ "id": 69154, "url": "http://patches.dpdk.org/api/patches/69154/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200422214555.11837-2-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200422214555.11837-2-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200422214555.11837-2-l.wojciechow@partner.samsung.com", "date": "2020-04-22T21:45:53", "name": "[v2,1/3] config: introduce global rte debug flag", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "aa4acd916eb2d1680cc7cff8ba9e5c5e8fa9b127", "submitter": { "id": 1628, "url": "http://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200422214555.11837-2-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 9575, "url": "http://patches.dpdk.org/api/series/9575/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9575", "date": "2020-04-22T21:45:52", "name": "introduce global debug flag", "version": 2, "mbox": "http://patches.dpdk.org/series/9575/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69154/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/69154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 583D2A00C2;\n\tWed, 22 Apr 2020 23:46:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0CAD01D166;\n\tWed, 22 Apr 2020 23:46:19 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 12FB31C2EC\n for <dev@dpdk.org>; Wed, 22 Apr 2020 23:46:16 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200422214615euoutp01b1f265e359e0e3327b8aadeb38d0abc7~IQn2GYmQ21855618556euoutp01D\n for <dev@dpdk.org>; Wed, 22 Apr 2020 21:46:15 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200422214615eucas1p1930a814fbbc65fec257817f550b56ff0~IQn1mjP9Z0073700737eucas1p1S;\n Wed, 22 Apr 2020 21:46:15 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id FA.4B.60679.62BB0AE5; Wed, 22\n Apr 2020 22:46:14 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200422214614eucas1p1044184e60bcb04469783ef0dd95091c1~IQn06AhSZ0612206122eucas1p17;\n Wed, 22 Apr 2020 21:46:14 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200422214614eusmtrp145b69957ddced74fa9d7c66c299fb6af~IQn05gCWT3110331103eusmtrp1W;\n Wed, 22 Apr 2020 21:46:14 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id BD.7A.08375.62BB0AE5; Wed, 22\n Apr 2020 22:46:14 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200422214613eusmtip1a4bc0398dc925a7344d6d5b1353127f9~IQn0gWoTO0760407604eusmtip1T;\n Wed, 22 Apr 2020 21:46:13 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200422214615euoutp01b1f265e359e0e3327b8aadeb38d0abc7~IQn2GYmQ21855618556euoutp01D", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1587591975;\n bh=rSVA9K7s4KDty17e5koTI8u67FJxUQ6xYh1s7FtkPVU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=POQn8Q+fO20h5VhJC2sIixU9gkzuDYtH+wSxvmSDUuEzizM/9kzMqlMfHTmaGrTwg\n QL/G7kn/6bH7c0iP12ttbib+lfhj/+bWPp4OTi3bPtXs0aPxahJpe22r3dzJj2yu2o\n 1qibY8tvgkQQtmMRZqIGGAYdMyyPrAleD2+wL4Wg=", "X-AuditID": "cbfec7f4-0e5ff7000001ed07-e7-5ea0bb264ae4", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Bruce Richardson\n <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org", "Date": "Wed, 22 Apr 2020 23:45:53 +0200", "Message-Id": "<20200422214555.11837-2-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200422214555.11837-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsWy7djP87pquxfEGUzqNrO4scre4t2n7UwW\n nx6cYHFg9vi1YCmrx+I9L5k8jt2cxh7AHMVlk5Kak1mWWqRvl8CVsfDCZ+aCvWIVN+Z+YWlg\n vCfUxcjJISFgInHo2AOWLkYuDiGBFYwSqw4/YAVJCAl8YZTYMoUTIvGZUaJ/VzczTMe1VSsY\n IRLLGSWmHL7DDFe17899NpAqNgFbiSMzv4KNEhGIkti55ygTiM0sICDx+N4zsLiwgL1E+4UG\n FhCbRUBV4vmeRnYQm1fAVaL1VD/UNnmJ1RsOgNmcAm4Sp4+2gN0qIXCETeL/pscsEEUuEtvu\n b2GFsIUlXh3fwg5hy0icntwD1bCNUeLq75+MEM5+RonrvSugqqwlDv/7DXQ2B9B5mhLrd+lD\n hB0lrm27wwoSlhDgk7jxVhDiAT6JSdumM0OEeSU62qDhqCfxtGcqI8zaP2ufQJ3mIbHucQMb\n JICuMkrMbZ/NNoFRfhbCsgWMjKsYxVNLi3PTU4uN8lLL9YoTc4tL89L1kvNzNzECY/30v+Nf\n djDu+pN0iFGAg1GJhzdCcUGcEGtiWXFl7iFGCQ5mJRHeDQ/nxQnxpiRWVqUW5ccXleakFh9i\n lOZgURLnNV70MlZIID2xJDU7NbUgtQgmy8TBKdXAyH424hDviXs3V7xO3HrKyqSM5YvHCy+e\n BVsKzmS90Fmko3vo1uTSyakmhScDNy3zeGUVm7PaeMU7lQ0hwdPMoyMk1e5Z3Ejc8lt151n1\n 9ZtWJbmKT776Om/z0i7vsDWai28+TzRVvCOVsuEQJ8svM/biywXdDC0X1LsP3FdgZG+xv9k2\n 9+Cz40osxRmJhlrMRcWJAIZ05j3xAgAA", "\n H4sIAAAAAAAAA+NgFtrPLMWRmVeSWpSXmKPExsVy+t/xu7pquxfEGRw7yGdxY5W9xbtP25ks\n Pj04weLA7PFrwVJWj8V7XjJ5HLs5jT2AOUrPpii/tCRVISO/uMRWKdrQwkjP0NJCz8jEUs/Q\n 2DzWyshUSd/OJiU1J7MstUjfLkEvY+GFz8wFe8Uqbsz9wtLAeE+oi5GTQ0LAROLaqhWMXYxc\n HEICSxklpu38yNLFyAGUkJH4cEkAokZY4s+1LjaImo+MEg9/t7GCJNgEbCWOzPwKZosIREn0\n 7FoOZjMLCEg8vvcMzBYWsJdov9DAAmKzCKhKPN/TyA5i8wq4SrSe6meGWCAvsXrDATCbU8BN\n 4vTRFhaIZY2MEtcnH2WawMi3gJFhFaNIamlxbnpusaFecWJucWleul5yfu4mRmDgbTv2c/MO\n xksbgw8xCnAwKvHwRiguiBNiTSwrrsw9xCjBwawkwrvh4bw4Id6UxMqq1KL8+KLSnNTiQ4ym\n QFdNZJYSTc4HRkVeSbyhqaG5haWhubG5sZmFkjhvh8DBGCGB9MSS1OzU1ILUIpg+Jg5OqQZG\n 45872rbbhRb9231t1g7fW5OPant5V2ukt+7b5j3lVPrv1QxZW/fGm88yTjy0sqKrkvuOfzrH\n vTXPhJnimCOdzCYZ6SuwX7xxrN6R9RhnCXviLp95r1uSA799EfwvdG5+bMMLjXzl/9wJQk6x\n QbxfS38duSje5/4rYVY5a9bU/50Se+t/dAQpsRRnJBpqMRcVJwIAX+xmA1ICAAA=" ], "X-CMS-MailID": "20200422214614eucas1p1044184e60bcb04469783ef0dd95091c1", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200422214614eucas1p1044184e60bcb04469783ef0dd95091c1", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200422214614eucas1p1044184e60bcb04469783ef0dd95091c1", "References": "<20200417215739.23180-1-l.wojciechow@partner.samsung.com>\n <20200422214555.11837-1-l.wojciechow@partner.samsung.com>\n <CGME20200422214614eucas1p1044184e60bcb04469783ef0dd95091c1@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v2 1/3] config: introduce global rte debug flag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A new boolean meson build flag is introduced with this patch: rte_debug.\nTo enable this option add -Drte_debug=true to the meson configure command.\n\nBy enabling this flag the globaly defined macro RTE_DEBUG becomes\ndefined. It should be used for enabling debug code in all dpdk project\ncomponents. Using this flag allows to make additional checks or tests\nand provide additional logs even in performance sensitive parts of code.\n\nThe flag is disabled by default.\n\nAdditionally for all enabled to be built libraries\na RTE_DEBUG_{library name} is defined and assigned a value 1.\nThis standardize names of library specific debug macros. Those can\nbe used also without rte_debug option by using CFLAGS=\"-D...\" build\nparameter.\n\nCode put inside RTE_DEBUG* #ifdef sections should be also put inside\nif (rte_log_can_log(...)) condition to allow run-time filtering of\nsanity checks, validations, logs and dumps when using rte_debug option.\n\nLibraries will be adjusted to the change in separate patches.\n\nSuggested-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n config/meson.build | 4 ++++\n lib/meson.build | 4 ++++\n meson_options.txt | 2 ++\n 3 files changed, 10 insertions(+)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 224d29e1c..5ab510009 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -183,6 +183,10 @@ endif\n # add -include rte_config to cflags\n add_project_arguments('-include', 'rte_config.h', language: 'c')\n \n+if get_option('rte_debug')\n+\tdpdk_conf.set('RTE_DEBUG', 1)\n+endif\n+\n # enable extra warnings and disable any unwanted warnings\n warning_flags = [\n \t# -Wall is added by meson by default, so add -Wextra only\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 63c17ee75..8e0abca1e 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -88,6 +88,10 @@ foreach l:libraries\n \t\tdpdk_conf.set('RTE_LIBRTE_' + name.to_upper(), 1)\n \t\tinstall_headers(headers)\n \n+\t\tif get_option('rte_debug')\n+\t\t\tdpdk_conf.set('RTE_DEBUG_' + name.to_upper(), 1)\n+\t\tendif\n+\n \t\tlibname = 'rte_' + name\n \t\tincludes += include_directories(dir_name)\n \ndiff --git a/meson_options.txt b/meson_options.txt\nindex 9e4923a4f..a14f0efdb 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -30,6 +30,8 @@ option('max_lcores', type: 'integer', value: 128,\n \tdescription: 'maximum number of cores/threads supported by EAL')\n option('max_numa_nodes', type: 'integer', value: 4,\n \tdescription: 'maximum number of NUMA nodes supported by EAL')\n+option('rte_debug', type: 'boolean', value: false,\n+\tdescription: 'build with additional sanity checks, validations and logs')\n option('tests', type: 'boolean', value: true,\n \tdescription: 'build unit tests')\n option('use_hpet', type: 'boolean', value: false,\n", "prefixes": [ "v2", "1/3" ] }