Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69012/?format=api
{ "id": 69012, "url": "http://patches.dpdk.org/api/patches/69012/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200421123949.38270-2-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200421123949.38270-2-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200421123949.38270-2-ciara.power@intel.com", "date": "2020-04-21T12:39:33", "name": "[v3,01/17] build: add arch-specific header path to global includes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d6002d2ad6bb57e915019fb84aa044b44af9ad0a", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200421123949.38270-2-ciara.power@intel.com/mbox/", "series": [ { "id": 9543, "url": "http://patches.dpdk.org/api/series/9543/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9543", "date": "2020-04-21T12:39:32", "name": "update and simplify telemetry library.", "version": 3, "mbox": "http://patches.dpdk.org/series/9543/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69012/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/69012/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 283BBA0597;\n\tTue, 21 Apr 2020 14:59:35 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4A9F01D44F;\n\tTue, 21 Apr 2020 14:59:28 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id 46EE61D409\n for <dev@dpdk.org>; Tue, 21 Apr 2020 14:59:26 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Apr 2020 05:59:25 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by fmsmga004.fm.intel.com with ESMTP; 21 Apr 2020 05:59:23 -0700" ], "IronPort-SDR": [ "\n yjfaiCSs3veDzRl1oXj4Cy6syr06NNgikNCgrCG84gHuGOw1Gx51+7C7phDy/OBEbzDuVl3gNj\n vXJGCBCJ9f4A==", "\n O/z18M4YFKGrQg9YNVRHhUhkleA7091XYlW4reOPy0E1w2lYjEYMQtahj0ETsjhHqhQgG31VlJ\n milYI1PU3BiA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,410,1580803200\"; d=\"scan'208\";a=\"279629048\"", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org,\n\tkevin.laatz@intel.com", "Cc": "reshma.pattan@intel.com, jerinjacobk@gmail.com, david.marchand@redhat.com,\n keith.wiles@intel.com, mb@smartsharesystems.com, thomas@monjalon.net,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 21 Apr 2020 13:39:33 +0100", "Message-Id": "<20200421123949.38270-2-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200421123949.38270-1-ciara.power@intel.com>", "References": "<20200319171907.60891-1-ciara.power@intel.com>\n <20200421123949.38270-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 01/17] build: add arch-specific header path to\n\tglobal includes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nThe global include path, which is used by anything built before EAL,\npoints to the EAL header files so they utility macros etc. can be used\nanywhere in DPDK. This path included the OS-specific EAL header files,\nbut not the architecture-specific ones. This patch moves the selection\nof target architecture to the top-level meson.build file so that the\nglobal include can reference that.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/meson.build | 7 -------\n lib/librte_eal/arm/include/meson.build | 2 --\n lib/librte_eal/ppc/include/meson.build | 2 --\n lib/librte_eal/x86/include/meson.build | 2 --\n meson.build | 9 +++++++++\n 5 files changed, 9 insertions(+), 13 deletions(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 58421342b1..49482091d5 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -229,13 +229,6 @@ dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true)\n \n \n compile_time_cpuflags = []\n-if host_machine.cpu_family().startswith('x86')\n-\tarch_subdir = 'x86'\n-elif host_machine.cpu_family().startswith('arm') or host_machine.cpu_family().startswith('aarch')\n-\tarch_subdir = 'arm'\n-elif host_machine.cpu_family().startswith('ppc')\n-\tarch_subdir = 'ppc'\n-endif\n subdir(arch_subdir)\n dpdk_conf.set('RTE_COMPILE_TIME_CPUFLAGS', ','.join(compile_time_cpuflags))\n \ndiff --git a/lib/librte_eal/arm/include/meson.build b/lib/librte_eal/arm/include/meson.build\nindex 1721743240..73b750a18f 100644\n--- a/lib/librte_eal/arm/include/meson.build\n+++ b/lib/librte_eal/arm/include/meson.build\n@@ -1,8 +1,6 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation.\n \n-includes += include_directories('.')\n-\n arch_headers = files(\n \t'rte_atomic_32.h',\n \t'rte_atomic_64.h',\ndiff --git a/lib/librte_eal/ppc/include/meson.build b/lib/librte_eal/ppc/include/meson.build\nindex 3a91c984c4..230c44aa95 100644\n--- a/lib/librte_eal/ppc/include/meson.build\n+++ b/lib/librte_eal/ppc/include/meson.build\n@@ -1,8 +1,6 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2018 Luca Boccassi <bluca@debian.org>\n \n-includes += include_directories('.')\n-\n arch_headers = files(\n \t'rte_atomic.h',\n \t'rte_byteorder.h',\ndiff --git a/lib/librte_eal/x86/include/meson.build b/lib/librte_eal/x86/include/meson.build\nindex d336d522c0..f0e998c2fe 100644\n--- a/lib/librte_eal/x86/include/meson.build\n+++ b/lib/librte_eal/x86/include/meson.build\n@@ -1,8 +1,6 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-includes += include_directories('.')\n-\n arch_headers = files(\n \t'rte_atomic_32.h',\n \t'rte_atomic_64.h',\ndiff --git a/meson.build b/meson.build\nindex d36580438e..8ee79f78d5 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -24,12 +24,21 @@ dpdk_libs_disabled = []\n dpdk_drvs_disabled = []\n abi_version_file = files('ABI_VERSION')\n \n+if host_machine.cpu_family().startswith('x86')\n+\tarch_subdir = 'x86'\n+elif host_machine.cpu_family().startswith('arm') or host_machine.cpu_family().startswith('aarch')\n+\tarch_subdir = 'arm'\n+elif host_machine.cpu_family().startswith('ppc')\n+\tarch_subdir = 'ppc'\n+endif\n+\n # configure the build, and make sure configs here and in config folder are\n # able to be included in any file. We also store a global array of include dirs\n # for passing to pmdinfogen scripts\n global_inc = include_directories('.', 'config',\n \t'lib/librte_eal/include',\n \t'lib/librte_eal/@0@/include'.format(host_machine.system()),\n+\t'lib/librte_eal/@0@/include'.format(arch_subdir),\n )\n subdir('config')\n \n", "prefixes": [ "v3", "01/17" ] }