Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6854/?format=api
{ "id": 6854, "url": "http://patches.dpdk.org/api/patches/6854/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1441143062-2557-6-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1441143062-2557-6-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1441143062-2557-6-git-send-email-thomas.monjalon@6wind.com", "date": "2015-09-01T21:30:59", "name": "[dpdk-dev,6/9] lpm: remove deprecated field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "076f87ea2402b8752d99bc72d8a2c0db2ea567d1", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1441143062-2557-6-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/6854/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/6854/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 357538E75;\n\tTue, 1 Sep 2015 23:32:28 +0200 (CEST)", "from mail-wi0-f182.google.com (mail-wi0-f182.google.com\n\t[209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 3FFEC8D9B\n\tfor <dev@dpdk.org>; Tue, 1 Sep 2015 23:32:27 +0200 (CEST)", "by wicmc4 with SMTP id mc4so46786703wic.0\n\tfor <dev@dpdk.org>; Tue, 01 Sep 2015 14:32:27 -0700 (PDT)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by smtp.gmail.com with ESMTPSA id\n\tej5sm29085583wjd.22.2015.09.01.14.32.25\n\tfor <dev@dpdk.org> (version=TLSv1/SSLv3 cipher=OTHER);\n\tTue, 01 Sep 2015 14:32:26 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=YtEr+KzwBuuh1TEXGptI8UFicdet9UPvolaGvs2yhdI=;\n\tb=iwf/qAhccCQZZZ2ml55/82aOj1uzROuYTeDUD/v3iNC5oQwWq6JeQOrnDYIbU5XxKS\n\tRHft+4Tf23YceF+Of48dUsWKnyBhnrtJ0Lqg1+Rbdc+sUMnW7tmwsKtBXDwfl9HbdREp\n\tWcbOY+yUewAOXEGwSfN3k/7rS20eWrt4psdQMSth5MKH/G/IlzyDjVaJQjEMmRQrG7r/\n\tx4fprZP1b4eV+Z4sz6imLI/Ic0m+T2/7K4wHXXHKCCnsue/GsO4Kpv0qc87yZAy5cZ9b\n\tkH2xL3bRhMXK72P1pQFzHxO0zQrRgc6k/guUzqkSVhiha9QhUy1f5skWLSAMNR+lCFcs\n\tH2TQ==", "X-Gm-Message-State": "ALoCoQn4d39cTpfFst0CankYHKL7xrdCW+Jrr9kASB/8hiychupTln1itzp7kvkJGBuYbzMSWXcm", "X-Received": "by 10.180.72.6 with SMTP id z6mr236878wiu.57.1441143147066;\n\tTue, 01 Sep 2015 14:32:27 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Tue, 1 Sep 2015 23:30:59 +0200", "Message-Id": "<1441143062-2557-6-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.1", "In-Reply-To": "<1441138697-25157-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1441138697-25157-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH 6/9] lpm: remove deprecated field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n app/test/test_func_reentrancy.c | 4 ++--\n app/test/test_lpm.c | 4 ++--\n doc/guides/rel_notes/deprecation.rst | 3 ---\n lib/librte_lpm/Makefile | 2 +-\n lib/librte_lpm/rte_lpm.h | 11 -----------\n 5 files changed, 5 insertions(+), 19 deletions(-)", "diff": "diff --git a/app/test/test_func_reentrancy.c b/app/test/test_func_reentrancy.c\nindex be61773..dbecc52 100644\n--- a/app/test/test_func_reentrancy.c\n+++ b/app/test/test_func_reentrancy.c\n@@ -366,7 +366,7 @@ lpm_create_free(__attribute__((unused)) void *arg)\n \n \t/* create the same lpm simultaneously on all threads */\n \tfor (i = 0; i < MAX_ITER_TIMES; i++) {\n-\t\tlpm = rte_lpm_create(\"fr_test_once\", SOCKET_ID_ANY, 4, RTE_LPM_HEAP);\n+\t\tlpm = rte_lpm_create(\"fr_test_once\", SOCKET_ID_ANY, 4, 0);\n \t\tif ((NULL == lpm) && (rte_lpm_find_existing(\"fr_test_once\") == NULL))\n \t\t\treturn -1;\n \t}\n@@ -374,7 +374,7 @@ lpm_create_free(__attribute__((unused)) void *arg)\n \t/* create mutiple fbk tables simultaneously */\n \tfor (i = 0; i < MAX_LPM_ITER_TIMES; i++) {\n \t\tsnprintf(lpm_name, sizeof(lpm_name), \"fr_test_%d_%d\", lcore_self, i);\n-\t\tlpm = rte_lpm_create(lpm_name, SOCKET_ID_ANY, 4, RTE_LPM_HEAP);\n+\t\tlpm = rte_lpm_create(lpm_name, SOCKET_ID_ANY, 4, 0);\n \t\tif (NULL == lpm)\n \t\t\treturn -1;\n \ndiff --git a/app/test/test_lpm.c b/app/test/test_lpm.c\nindex 6d8823e..8b4ded9 100644\n--- a/app/test/test_lpm.c\n+++ b/app/test/test_lpm.c\n@@ -165,7 +165,7 @@ test2(void)\n {\n \tstruct rte_lpm *lpm = NULL;\n \n-\tlpm = rte_lpm_create(__func__, SOCKET_ID_ANY, MAX_RULES, RTE_LPM_HEAP);\n+\tlpm = rte_lpm_create(__func__, SOCKET_ID_ANY, MAX_RULES, 0);\n \tTEST_LPM_ASSERT(lpm != NULL);\n \n \trte_lpm_free(lpm);\n@@ -607,7 +607,7 @@ test10(void)\n \n \t/* Add rule that covers a TBL24 range previously invalid & lookup\n \t * (& delete & lookup) */\n-\tlpm = rte_lpm_create(__func__, SOCKET_ID_ANY, MAX_RULES, RTE_LPM_HEAP);\n+\tlpm = rte_lpm_create(__func__, SOCKET_ID_ANY, MAX_RULES, 0);\n \tTEST_LPM_ASSERT(lpm != NULL);\n \n \tip = IPv4(128, 0, 0, 0);\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 3fa4c90..c40764a 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -18,9 +18,6 @@ Deprecation Notices\n \n * The function rte_jhash2 is deprecated and should be removed.\n \n-* The field mem_location of the rte_lpm structure is deprecated and should be\n- removed as well as the macros RTE_LPM_HEAP and RTE_LPM_MEMZONE.\n-\n * The following fields have been deprecated in rte_eth_stats:\n imissed, ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,\n tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff\ndiff --git a/lib/librte_lpm/Makefile b/lib/librte_lpm/Makefile\nindex 0a7a888..688cfc9 100644\n--- a/lib/librte_lpm/Makefile\n+++ b/lib/librte_lpm/Makefile\n@@ -39,7 +39,7 @@ CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)\n \n EXPORT_MAP := rte_lpm_version.map\n \n-LIBABIVER := 1\n+LIBABIVER := 2\n \n # all source are stored in SRCS-y\n SRCS-$(CONFIG_RTE_LIBRTE_LPM) := rte_lpm.c rte_lpm6.c\ndiff --git a/lib/librte_lpm/rte_lpm.h b/lib/librte_lpm/rte_lpm.h\nindex 11f0c04..c299ce2 100644\n--- a/lib/librte_lpm/rte_lpm.h\n+++ b/lib/librte_lpm/rte_lpm.h\n@@ -56,16 +56,6 @@ extern \"C\" {\n /** Max number of characters in LPM name. */\n #define RTE_LPM_NAMESIZE 32\n \n-/** @deprecated Possible location to allocate memory. This was for last\n- * parameter of rte_lpm_create(), but is now redundant. The LPM table is always\n- * allocated in memory using librte_malloc which uses a memzone. */\n-#define RTE_LPM_HEAP 0\n-\n-/** @deprecated Possible location to allocate memory. This was for last\n- * parameter of rte_lpm_create(), but is now redundant. The LPM table is always\n- * allocated in memory using librte_malloc which uses a memzone. */\n-#define RTE_LPM_MEMZONE 1\n-\n /** Maximum depth value possible for IPv4 LPM. */\n #define RTE_LPM_MAX_DEPTH 32\n \n@@ -154,7 +144,6 @@ struct rte_lpm_rule_info {\n struct rte_lpm {\n \t/* LPM metadata. */\n \tchar name[RTE_LPM_NAMESIZE]; /**< Name of the lpm. */\n-\tint mem_location; /**< @deprecated @see RTE_LPM_HEAP and RTE_LPM_MEMZONE. */\n \tuint32_t max_rules; /**< Max. balanced rules per lpm. */\n \tstruct rte_lpm_rule_info rule_info[RTE_LPM_MAX_DEPTH]; /**< Rule info table. */\n \n", "prefixes": [ "dpdk-dev", "6/9" ] }