Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6853/?format=api
{ "id": 6853, "url": "http://patches.dpdk.org/api/patches/6853/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1441143062-2557-5-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1441143062-2557-5-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1441143062-2557-5-git-send-email-thomas.monjalon@6wind.com", "date": "2015-09-01T21:30:58", "name": "[dpdk-dev,5/9] mem: remove dummy malloc library", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b0411ebbb87f9f8cf624fd3598584070ed7c9b25", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1441143062-2557-5-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/6853/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/6853/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7D8A58D9E;\n\tTue, 1 Sep 2015 23:32:27 +0200 (CEST)", "from mail-wi0-f180.google.com (mail-wi0-f180.google.com\n\t[209.85.212.180]) by dpdk.org (Postfix) with ESMTP id B96308E5A\n\tfor <dev@dpdk.org>; Tue, 1 Sep 2015 23:32:25 +0200 (CEST)", "by wicjd9 with SMTP id jd9so46851081wic.1\n\tfor <dev@dpdk.org>; Tue, 01 Sep 2015 14:32:25 -0700 (PDT)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by smtp.gmail.com with ESMTPSA id\n\tej5sm29085583wjd.22.2015.09.01.14.32.24\n\tfor <dev@dpdk.org> (version=TLSv1/SSLv3 cipher=OTHER);\n\tTue, 01 Sep 2015 14:32:24 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=usZPfwm1g/Q5BgjAUAe5+WaxZBoBBH+ZOvZGB+es0Ho=;\n\tb=bOlzg71mxEQ9dTXzfHg3oN4kjh95WT8WiUEygYjzvb9B5Ul33qdwUMDFnEDxe7NyEm\n\tVrarUhwOBgqjcy9rSsJxcUfJ6BMUtmVAUF3oIin0apjiGXhyi4q0g2EE7vh3ACx45OE5\n\t7/HZJrzgK88cCXoefm5ZsbYZ1uuxWg40d0AKRcw2fwBtl1tAh7SsRdY4W4eIFUXmiN8T\n\tfTNNzYJ0P23EZiVELPZ6u98bF7ifgMgJWeWKZihYg2kTe1s2GlMAIxWocQshewLNTeHy\n\tUo4lQZgNar7GlbgUReU2ooyVJEaQ5wBYlAFD3RyJ5c+eGfhAIyGUHwrR8n2E964iYQkt\n\th40w==", "X-Gm-Message-State": "ALoCoQnlT2OdUYZ/AteR+vciFpluQKX2Gek11lA/5fWuylvPm8fXXhhigCn6RZD2/R1VX821o7jY", "X-Received": "by 10.194.109.36 with SMTP id hp4mr39251533wjb.4.1441143145595; \n\tTue, 01 Sep 2015 14:32:25 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Tue, 1 Sep 2015 23:30:58 +0200", "Message-Id": "<1441143062-2557-5-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.1", "In-Reply-To": "<1441138697-25157-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1441138697-25157-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH 5/9] mem: remove dummy malloc library", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The malloc library is now part of the EAL.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n MAINTAINERS | 1 -\n doc/guides/prog_guide/dev_kit_build_system.rst | 2 +-\n doc/guides/prog_guide/env_abstraction_layer.rst | 2 +-\n doc/guides/prog_guide/source_org.rst | 1 -\n .../thread_safety_intel_dpdk_functions.rst | 2 +-\n doc/guides/rel_notes/deprecation.rst | 5 ---\n lib/Makefile | 1 -\n lib/librte_malloc/Makefile | 48 ----------------------\n lib/librte_malloc/rte_malloc_empty.c | 34 ---------------\n lib/librte_malloc/rte_malloc_version.map | 3 --\n mk/rte.app.mk | 1 -\n 11 files changed, 3 insertions(+), 97 deletions(-)\n delete mode 100644 lib/librte_malloc/Makefile\n delete mode 100644 lib/librte_malloc/rte_malloc_empty.c\n delete mode 100644 lib/librte_malloc/rte_malloc_version.map", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex 17d4265..080a8e8 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -102,7 +102,6 @@ F: lib/librte_eal/common/include/rte_malloc.h\n F: lib/librte_eal/common/*malloc*\n F: lib/librte_eal/common/eal_common_mem*\n F: lib/librte_eal/common/eal_hugepages.h\n-F: lib/librte_malloc/\n F: doc/guides/prog_guide/env_abstraction_layer.rst\n F: app/test/test_func_reentrancy.c\n F: app/test/test_malloc.c\ndiff --git a/doc/guides/prog_guide/dev_kit_build_system.rst b/doc/guides/prog_guide/dev_kit_build_system.rst\nindex 7dc2de6..dd3e3d0 100644\n--- a/doc/guides/prog_guide/dev_kit_build_system.rst\n+++ b/doc/guides/prog_guide/dev_kit_build_system.rst\n@@ -85,7 +85,7 @@ Each build directory contains include files, libraries, and applications:\n \n librte_cmdline.a librte_lpm.a librte_mempool.a librte_ring.a\n \n- librte_eal.a librte_malloc.a librte_pmd_e1000.a librte_timer.a\n+ librte_eal.a librte_pmd_e1000.a librte_timer.a\n \n \n ~/DEV/DPDK$ ls i686-native-linuxapp-gcc/include/\ndiff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst\nindex f1b3ff1..a03e40d 100644\n--- a/doc/guides/prog_guide/env_abstraction_layer.rst\n+++ b/doc/guides/prog_guide/env_abstraction_layer.rst\n@@ -115,7 +115,7 @@ The physical address of the reserved memory for that memory zone is also returne\n \n .. note::\n \n- Memory reservations done using the APIs provided by the rte_malloc library are also backed by pages from the hugetlbfs filesystem.\n+ Memory reservations done using the APIs provided by rte_malloc are also backed by pages from the hugetlbfs filesystem.\n \n Xen Dom0 support without hugetbls\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ndiff --git a/doc/guides/prog_guide/source_org.rst b/doc/guides/prog_guide/source_org.rst\nindex b81e965..ae11b3b 100644\n--- a/doc/guides/prog_guide/source_org.rst\n+++ b/doc/guides/prog_guide/source_org.rst\n@@ -74,7 +74,6 @@ The lib directory contains::\n +-- librte_kni # Kernel NIC interface\n +-- librte_kvargs # Argument parsing library\n +-- librte_lpm # Longest prefix match library\n- +-- librte_malloc # Malloc-like functions\n +-- librte_mbuf # Packet and control mbuf manipulation\n +-- librte_mempool # Memory pool manager (fixed sized objects)\n +-- librte_meter # QoS metering library\ndiff --git a/doc/guides/prog_guide/thread_safety_intel_dpdk_functions.rst b/doc/guides/prog_guide/thread_safety_intel_dpdk_functions.rst\nindex 0034bf4..403e5fc 100644\n--- a/doc/guides/prog_guide/thread_safety_intel_dpdk_functions.rst\n+++ b/doc/guides/prog_guide/thread_safety_intel_dpdk_functions.rst\n@@ -73,7 +73,7 @@ Performance Insensitive API\n \n Outside of the performance sensitive areas described in Section 25.1,\n the DPDK provides a thread-safe API for most other libraries.\n-For example, malloc(librte_malloc) and memzone functions are safe for use in multi-threaded and multi-process environments.\n+For example, malloc and memzone functions are safe for use in multi-threaded and multi-process environments.\n \n The setup and configuration of the PMD is not performance sensitive, but is not thread safe either.\n It is possible that the multiple read/writes during PMD setup and configuration could be corrupted in a multi-thread environment.\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 604a899..3fa4c90 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -21,11 +21,6 @@ Deprecation Notices\n * The field mem_location of the rte_lpm structure is deprecated and should be\n removed as well as the macros RTE_LPM_HEAP and RTE_LPM_MEMZONE.\n \n-* librte_malloc library has been integrated into librte_eal. The 2.1 release\n- creates a dummy/empty malloc library to fulfill binaries with dynamic linking\n- dependencies on librte_malloc.so. Such dummy library will not be created from\n- release 2.2 so binaries will need to be rebuilt.\n-\n * The following fields have been deprecated in rte_eth_stats:\n imissed, ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,\n tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff\ndiff --git a/lib/Makefile b/lib/Makefile\nindex 2055539..9727b83 100644\n--- a/lib/Makefile\n+++ b/lib/Makefile\n@@ -33,7 +33,6 @@ include $(RTE_SDK)/mk/rte.vars.mk\n \n DIRS-y += librte_compat\n DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_eal\n-DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_malloc\n DIRS-$(CONFIG_RTE_LIBRTE_RING) += librte_ring\n DIRS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += librte_mempool\n DIRS-$(CONFIG_RTE_LIBRTE_MBUF) += librte_mbuf\ndiff --git a/lib/librte_malloc/Makefile b/lib/librte_malloc/Makefile\ndeleted file mode 100644\nindex 9558f3d..0000000\n--- a/lib/librte_malloc/Makefile\n+++ /dev/null\n@@ -1,48 +0,0 @@\n-# BSD LICENSE\n-#\n-# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.\n-# All rights reserved.\n-#\n-# Redistribution and use in source and binary forms, with or without\n-# modification, are permitted provided that the following conditions\n-# are met:\n-#\n-# * Redistributions of source code must retain the above copyright\n-# notice, this list of conditions and the following disclaimer.\n-# * Redistributions in binary form must reproduce the above copyright\n-# notice, this list of conditions and the following disclaimer in\n-# the documentation and/or other materials provided with the\n-# distribution.\n-# * Neither the name of Intel Corporation nor the names of its\n-# contributors may be used to endorse or promote products derived\n-# from this software without specific prior written permission.\n-#\n-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n-# \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n-# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n-# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n-# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n-include $(RTE_SDK)/mk/rte.vars.mk\n-\n-# library name\n-LIB = librte_malloc.a\n-\n-LIBABIVER := 1\n-\n-CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3\n-\n-EXPORT_MAP := rte_malloc_version.map\n-\n-# all source are stored in SRCS-y\n-SRCS-$(CONFIG_RTE_LIBRTE_EAL) := rte_malloc_empty.c\n-\n-# this lib needs eal\n-DEPDIRS-$(CONFIG_RTE_LIBRTE_EAL) += lib/librte_eal\n-\n-include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_malloc/rte_malloc_empty.c b/lib/librte_malloc/rte_malloc_empty.c\ndeleted file mode 100644\nindex 4892a61..0000000\n--- a/lib/librte_malloc/rte_malloc_empty.c\n+++ /dev/null\n@@ -1,34 +0,0 @@\n-/*-\n- * BSD LICENSE\n- *\n- * Copyright(c) 2010-2015 Intel Corporation. All rights reserved.\n- * All rights reserved.\n- *\n- * Redistribution and use in source and binary forms, with or without\n- * modification, are permitted provided that the following conditions\n- * are met:\n- *\n- * * Redistributions of source code must retain the above copyright\n- * notice, this list of conditions and the following disclaimer.\n- * * Redistributions in binary form must reproduce the above copyright\n- * notice, this list of conditions and the following disclaimer in\n- * the documentation and/or other materials provided with the\n- * distribution.\n- * * Neither the name of Intel Corporation nor the names of its\n- * contributors may be used to endorse or promote products derived\n- * from this software without specific prior written permission.\n- *\n- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n- * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n- */\n-\n-/* Empty file to be able to create a dummy library for deprecation policy */\ndiff --git a/lib/librte_malloc/rte_malloc_version.map b/lib/librte_malloc/rte_malloc_version.map\ndeleted file mode 100644\nindex 63cb5fc..0000000\n--- a/lib/librte_malloc/rte_malloc_version.map\n+++ /dev/null\n@@ -1,3 +0,0 @@\n-DPDK_2.0 {\n-\tlocal: *;\n-};\ndiff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex 3871205..9e1909e 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -114,7 +114,6 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_KVARGS) += -lrte_kvargs\n _LDLIBS-$(CONFIG_RTE_LIBRTE_MBUF) += -lrte_mbuf\n _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += -lrte_ip_frag\n _LDLIBS-$(CONFIG_RTE_LIBRTE_ETHER) += -lethdev\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_MALLOC) += -lrte_malloc\n _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += -lrte_mempool\n _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring\n _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) += -lrte_eal\n", "prefixes": [ "dpdk-dev", "5/9" ] }