Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68071/?format=api
{ "id": 68071, "url": "http://patches.dpdk.org/api/patches/68071/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200409172502.1693-9-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200409172502.1693-9-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200409172502.1693-9-l.wojciechow@partner.samsung.com", "date": "2020-04-09T17:24:57", "name": "[v3,08/13] app/test: add rte security session stats get tests", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "96bdc060cff3d72f55e7798e82f0dc2f6180fd79", "submitter": { "id": 1628, "url": "http://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200409172502.1693-9-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 9272, "url": "http://patches.dpdk.org/api/series/9272/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9272", "date": "2020-04-09T17:24:49", "name": "Fixes and unit tests for librte_security", "version": 3, "mbox": "http://patches.dpdk.org/series/9272/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/68071/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/68071/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB21CA0597;\n\tThu, 9 Apr 2020 19:26:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 010391D418;\n\tThu, 9 Apr 2020 19:25:46 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id D94691C437\n for <dev@dpdk.org>; Thu, 9 Apr 2020 19:25:35 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200409172535euoutp028695180a251d15b8539bee62f4d7506d~ENri1vdtd2096020960euoutp02j\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:35 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200409172535eucas1p23dd5f75264f146bbd0c1ac7d366f4380~ENrinqmks0369803698eucas1p2o\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:35 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id F3.F2.61286.F8A5F8E5; Thu, 9\n Apr 2020 18:25:35 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200409172534eucas1p2852ae56687fd5bae343437b07198c070~ENrh-zb3t2381823818eucas1p2-\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:34 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200409172534eusmtrp1a3a2fa212b5a0eae301aed532a02bec0~ENrh-V7Mh2463624636eusmtrp1K\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:34 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id EC.B9.08375.E8A5F8E5; Thu, 9\n Apr 2020 18:25:34 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200409172534eusmtip15054d345eda775610733ae487cd42248~ENrhsDg5f0696806968eusmtip1U\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:34 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200409172535euoutp028695180a251d15b8539bee62f4d7506d~ENri1vdtd2096020960euoutp02j", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1586453135;\n bh=acA+ii0yOmD1r+6N7MuYyRPvxP2ro9kXIxZa9EtWUq4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=tsx6aCSSYnSO9oAvOiAfQTugJ7UP6NaJdiuutwjD6hMXKupNgYojDsEQCFDly0s6n\n wpclchC2FJaUVDO0fWowURSPcery/xwgOw+pDZOq9xumUlATBg55oDZ4w/MqCc47S4\n wpvOZV49WCbbyTj1bdkdWxnofeVJ7ECuy2IlsVcw=", "X-AuditID": "cbfec7f2-ef1ff7000001ef66-37-5e8f5a8f27cb", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "", "Cc": "dev@dpdk.org", "Date": "Thu, 9 Apr 2020 19:24:57 +0200", "Message-Id": "<20200409172502.1693-9-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200409172502.1693-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsWy7djP87r9Uf1xBm0dIhbvPm1ncmD0+LVg\n KWsAYxSXTUpqTmZZapG+XQJXxpxdn5gKJphWHLr0j6WB8ZBuFyMnh4SAicSCCd+ZQWwhgRWM\n EvdfG3cxcgHZ7UwS0160MEI4bUwS85rmMsN0zHh9kAkisZxR4s6yd6xwVbMe3GcEqWITsJU4\n MvMrK4gtIsAisfL7dxYQm1lAQOLxvWdgcWEBH4l5DVfAbBYBVYml27uBbA4OXgEXidN36iGW\n yUus3nAAbDGngKvEreOXmEF2SQisYJM43HgV6iIXieb/7VC2sMSr41vYIWwZidOTe1ggGrYx\n Slz9/ZMRwtnPKHG9dwVUlbXE4X+/2UA2MwtoSqzfpQ8RdpS42/qZHSQsIcAnceOtIMT9fBKT\n tk1nhgjzSnS0CUFU60k87ZnKCLP2z9onLBAlHhIn14RBgucyo8TH1UsZJzDKz0LYtYCRcRWj\n eGppcW56arFhXmq5XnFibnFpXrpecn7uJkZgBJ/+d/zTDsavl5IOMQpwMCrx8Bow9McJsSaW\n FVfmHmKU4GBWEuH1buqNE+JNSaysSi3Kjy8qzUktPsQozcGiJM5rvOhlrJBAemJJanZqakFq\n EUyWiYNTqoHRtXWF8bMzHObVrvs/q932W8qvs+LPAqHbUVP3h8lcMvDnWHX4S+DsbjXzD2Jf\n LN74SH6VZLbOi+P4PNE1/PiNWk5rzikrzklf2Pkj4e1MSe+uLMaTad+y4mVXmm79VKDDz/2S\n J+pD+SMx37Z6KaXa2lJvdz+R8zy+65+bb3/J97PjnFCSjIkSS3FGoqEWc1FxIgC/JYrP3AIA\n AA==", "\n H4sIAAAAAAAAA+NgFlrFLMWRmVeSWpSXmKPExsVy+t/xu7p9Uf1xBvuX6Fi8+7SdyYHR49eC\n pawBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6\n GXN2fWIqmGBacejSP5YGxkO6XYycHBICJhIzXh9k6mLk4hASWMoosbN7GmsXIwdQQkbiwyUB\n iBphiT/XutggalqYJCasOs4EkmATsJU4MvMrK4gtIsAisfL7dxYQm1lAQOLxvWdgcWEBH4l5\n DVfAbBYBVYml27vB5vMKuEicvlMPMV9eYvWGA8wgNqeAq8St45fAbCGBeonbXX8YJzDyLWBk\n WMUoklpanJueW2yoV5yYW1yal66XnJ+7iREYTtuO/dy8g/HSxuBDjAIcjEo8vAYM/XFCrIll\n xZW5hxglOJiVRHi9m3rjhHhTEiurUovy44tKc1KLDzGaAt00kVlKNDkfGOp5JfGGpobmFpaG\n 5sbmxmYWSuK8HQIHY4QE0hNLUrNTUwtSi2D6mDg4pRoYxYQemyU8mci/eXVosOTEXZMeTjq9\n 64LRiUNntzNf3/PVf/ObixuzmziaVuQn3Wuvn65jnGb3Su5T/T4TBSF5oWmcJ52mrl5Yby6f\n 7Kp4weVhccyK2V6Jn3Y+WMlftKt5TpLbiaZiN1Px2+VpwhJ1PYYWjvHBq6Qj9vPWlX1iNNnd\n JDVdc1OgEktxRqKhFnNRcSIAHEK6Vj0CAAA=" ], "X-CMS-MailID": "20200409172534eucas1p2852ae56687fd5bae343437b07198c070", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200409172534eucas1p2852ae56687fd5bae343437b07198c070", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200409172534eucas1p2852ae56687fd5bae343437b07198c070", "References": "<20200408031351.4288-1-l.wojciechow@partner.samsung.com>\n <20200409172502.1693-1-l.wojciechow@partner.samsung.com>\n <CGME20200409172534eucas1p2852ae56687fd5bae343437b07198c070@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v3 08/13] app/test: add rte security session\n\tstats get tests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add unit tests for rte_security_session_stats_get function.\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n app/test/test_security.c | 173 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 173 insertions(+)", "diff": "diff --git a/app/test/test_security.c b/app/test/test_security.c\nindex 9c5e7d0da..c495449b0 100644\n--- a/app/test/test_security.c\n+++ b/app/test/test_security.c\n@@ -292,6 +292,36 @@ mock_session_get_size(void *device)\n \treturn mock_session_get_size_exp.ret;\n }\n \n+/**\n+ * session_stats_get mockup\n+ *\n+ * Verified parameters: device, sess, stats.\n+ */\n+static struct mock_session_stats_get_data {\n+\tvoid *device;\n+\tstruct rte_security_session *sess;\n+\tstruct rte_security_stats *stats;\n+\n+\tint ret;\n+\n+\tint called;\n+\tint failed;\n+} mock_session_stats_get_exp = {NULL, NULL, NULL, 0, 0, 0};\n+\n+static int\n+mock_session_stats_get(void *device,\n+\t\tstruct rte_security_session *sess,\n+\t\tstruct rte_security_stats *stats)\n+{\n+\tmock_session_stats_get_exp.called++;\n+\n+\tMOCK_TEST_ASSERT_POINTER_PARAMETER(mock_session_stats_get_exp, device);\n+\tMOCK_TEST_ASSERT_POINTER_PARAMETER(mock_session_stats_get_exp, sess);\n+\tMOCK_TEST_ASSERT_POINTER_PARAMETER(mock_session_stats_get_exp, stats);\n+\n+\treturn mock_session_stats_get_exp.ret;\n+}\n+\n /**\n * session_destroy mockup\n *\n@@ -334,6 +364,7 @@ struct rte_security_ops mock_ops = {\n \t.session_create = mock_session_create,\n \t.session_update = mock_session_update,\n \t.session_get_size = mock_session_get_size,\n+\t.session_stats_get = mock_session_stats_get,\n \t.session_destroy = mock_session_destroy,\n };\n \n@@ -427,11 +458,13 @@ ut_setup(void)\n \tmock_session_create_exp.called = 0;\n \tmock_session_update_exp.called = 0;\n \tmock_session_get_size_exp.called = 0;\n+\tmock_session_stats_get_exp.called = 0;\n \tmock_session_destroy_exp.called = 0;\n \n \tmock_session_create_exp.failed = 0;\n \tmock_session_update_exp.failed = 0;\n \tmock_session_get_size_exp.failed = 0;\n+\tmock_session_stats_get_exp.failed = 0;\n \tmock_session_destroy_exp.failed = 0;\n \n \treturn TEST_SUCCESS;\n@@ -977,6 +1010,133 @@ test_session_get_size_success(void)\n }\n \n \n+/**\n+ * rte_security_session_stats_get tests\n+ */\n+\n+/**\n+ * Test execution of rte_security_session_stats_get with NULL instance\n+ */\n+static int\n+test_session_stats_get_inv_context(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tstruct rte_security_stats stats;\n+\n+\tint ret = rte_security_session_stats_get(NULL, ut_params->sess, &stats);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_stats_get,\n+\t\t\tret, -EINVAL, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_stats_get_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_stats_get with invalid\n+ * security operations structure (NULL)\n+ */\n+static int\n+test_session_stats_get_inv_context_ops(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tstruct rte_security_stats stats;\n+\tut_params->ctx.ops = NULL;\n+\n+\tint ret = rte_security_session_stats_get(&ut_params->ctx,\n+\t\t\tut_params->sess, &stats);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_stats_get,\n+\t\t\tret, -EINVAL, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_stats_get_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_stats_get with empty\n+ * security operations\n+ */\n+static int\n+test_session_stats_get_inv_context_ops_fun(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tstruct rte_security_stats stats;\n+\tut_params->ctx.ops = &empty_ops;\n+\n+\tint ret = rte_security_session_stats_get(&ut_params->ctx,\n+\t\t\tut_params->sess, &stats);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_stats_get,\n+\t\t\tret, -ENOTSUP, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_stats_get_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_stats_get with NULL stats parameter\n+ */\n+static int\n+test_session_stats_get_inv_stats(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tint ret = rte_security_session_stats_get(&ut_params->ctx,\n+\t\t\tut_params->sess, NULL);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_stats_get,\n+\t\t\tret, -EINVAL, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_stats_get_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_stats_get when session_stats_get\n+ * security operation fails\n+ */\n+static int\n+test_session_stats_get_ops_failure(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tstruct rte_security_stats stats;\n+\n+\tmock_session_stats_get_exp.device = NULL;\n+\tmock_session_stats_get_exp.sess = ut_params->sess;\n+\tmock_session_stats_get_exp.stats = &stats;\n+\tmock_session_stats_get_exp.ret = -1;\n+\n+\tint ret = rte_security_session_stats_get(&ut_params->ctx,\n+\t\t\tut_params->sess, &stats);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_stats_get,\n+\t\t\tret, -1, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_stats_get_exp, 1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_stats_get in successful execution\n+ * path\n+ */\n+static int\n+test_session_stats_get_success(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tstruct rte_security_stats stats;\n+\n+\tmock_session_stats_get_exp.device = NULL;\n+\tmock_session_stats_get_exp.sess = ut_params->sess;\n+\tmock_session_stats_get_exp.stats = &stats;\n+\tmock_session_stats_get_exp.ret = 0;\n+\n+\tint ret = rte_security_session_stats_get(&ut_params->ctx,\n+\t\t\tut_params->sess, &stats);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_stats_get,\n+\t\t\tret, 0, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_stats_get_exp, 1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+\n /**\n * Declaration of testcases\n */\n@@ -1028,6 +1188,19 @@ static struct unit_test_suite security_testsuite = {\n \t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n \t\t\t\ttest_session_get_size_success),\n \n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_stats_get_inv_context),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_stats_get_inv_context_ops),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_stats_get_inv_context_ops_fun),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_stats_get_inv_stats),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_stats_get_ops_failure),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_stats_get_success),\n+\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\n", "prefixes": [ "v3", "08/13" ] }