Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67291/?format=api
{ "id": 67291, "url": "http://patches.dpdk.org/api/patches/67291/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200327101823.12646-18-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200327101823.12646-18-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200327101823.12646-18-mk@semihalf.com", "date": "2020-03-27T10:18:11", "name": "[17/29] net/ena: add support for large LLQ headers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d88335573e5165ffa3f343a6dbc19b98ecf6a687", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200327101823.12646-18-mk@semihalf.com/mbox/", "series": [ { "id": 9077, "url": "http://patches.dpdk.org/api/series/9077/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9077", "date": "2020-03-27T10:17:54", "name": "Update ENA driver to v2.1.0", "version": 1, "mbox": "http://patches.dpdk.org/series/9077/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/67291/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/67291/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 31F04A0589;\n\tFri, 27 Mar 2020 11:32:03 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6509E1C199;\n\tFri, 27 Mar 2020 11:29:43 +0100 (CET)", "from mail-lj1-f194.google.com (mail-lj1-f194.google.com\n [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 325511C119\n for <dev@dpdk.org>; Fri, 27 Mar 2020 11:29:33 +0100 (CET)", "by mail-lj1-f194.google.com with SMTP id 19so9610373ljj.7\n for <dev@dpdk.org>; Fri, 27 Mar 2020 03:29:33 -0700 (PDT)", "from localhost.localdomain (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id i11sm2789587lfo.84.2020.03.27.03.29.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2020 03:29:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=Nlxn0UL9TpQdzDv83NkI185u8GUv4l17wupW0ANAp2A=;\n b=Es6Qx7laEJywNyrsGyupxt0L1YzT6xlD04pqcliFXBT/eSUOTsW1swISMqrY9fKU65\n iHwFpNs8HDCTe/Q7JRYan36K8Fgtc7Z4SeYYsMRAJODVFANYZPSLsZzR3xP3KNpsQ+uE\n w9CDuQZzFI3pU6QJRKe74t7l5HQF6/alm+4MG0GgnPJoPFtUYnAE+YMZdwdI9KDvGxd9\n 3KFDJ9SFkQJJWJQd3oFGUrsN4w2uD93ah75VFjiz7Mr+Q7YE+DNYnte1rI5DBC8KCOjx\n dU5Oy91i5n/Av/1+cHNzKD7Phic00fMz/ghja/hmV9IMcmCl8I1MKiO6qyL2fdM0qQMA\n rXJw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=Nlxn0UL9TpQdzDv83NkI185u8GUv4l17wupW0ANAp2A=;\n b=GAEXNXZVowweCTvMGWx7gVXMQWrD1KQCZL90AKJnHeWQ6o8BpdxwUMqSY7yt9xNz7b\n MmDifu+tB+i9eduqjkGKNjrBVCpB4jbCPTSRk0rBSKxz9XGaI8J0PLmp3DX3kVT/FL/p\n YoLetNcOYi/19LTt/YzJ34tjgzIvpVx7qHjmRAp1ywCpWKqGnaI2oqbtDyc8Y4oxORgs\n TYalLaoWKZEmM1g8PZieiTPQDgIgicaUFUJe4rnGzQ75pBZ+640UzvlxiAmhEuvlzXWn\n 8SMverMZEHGH9QtYq1rzDfEHvpNY1OQMZUZKdyBILcfJijakt8u4PhsqUxZYiHeoT52t\n Ogcw==", "X-Gm-Message-State": "AGi0PuYPZJGLIO6d0I/uiQ0sB+D+9gkzW0N4RTL0GANx2mAQhbGdyqB3\n TfUwGLAKd7XshZdU/aFEQQfHjG+3o/aB5A==", "X-Google-Smtp-Source": "\n APiQypI5LQ3BRtU4Fm3ufFNdbfTLNArBDHszS1oYxsafWeGHXe8yYtPqYK32yXepmWUlUVmmdEsiqQ==", "X-Received": "by 2002:a2e:9097:: with SMTP id l23mr5016089ljg.173.1585304972529;\n Fri, 27 Mar 2020 03:29:32 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>", "Date": "Fri, 27 Mar 2020 11:18:11 +0100", "Message-Id": "<20200327101823.12646-18-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200327101823.12646-1-mk@semihalf.com>", "References": "<20200327101823.12646-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 17/29] net/ena: add support for large LLQ headers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If the device supports larger LLQ (Low Latency Queue) headers, the user\ncan activate them by enabling CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS\nflag in the configuration file.\n\nIf the device isn't supporting this feature, the default value will be\nused.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n config/common_base | 1 +\n doc/guides/nics/ena.rst | 5 +++++\n drivers/net/ena/ena_ethdev.c | 33 ++++++++++++++++++++++++++++++---\n 3 files changed, 36 insertions(+), 3 deletions(-)", "diff": "diff --git a/config/common_base b/config/common_base\nindex c31175f9d6..31f508b3cc 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -266,6 +266,7 @@ CONFIG_RTE_LIBRTE_ENA_DEBUG_RX=n\n CONFIG_RTE_LIBRTE_ENA_DEBUG_TX=n\n CONFIG_RTE_LIBRTE_ENA_DEBUG_TX_FREE=n\n CONFIG_RTE_LIBRTE_ENA_COM_DEBUG=n\n+CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS=n\n \n #\n # Compile burst-oriented Cisco ENIC PMD driver\ndiff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst\nindex bbf27f235a..a953068cac 100644\n--- a/doc/guides/nics/ena.rst\n+++ b/doc/guides/nics/ena.rst\n@@ -95,6 +95,11 @@ Configuration information\n * **CONFIG_RTE_LIBRTE_ENA_COM_DEBUG** (default n): Enables or disables debug\n logging of low level tx/rx logic in ena_com(base) within the ENA PMD driver.\n \n+ * **CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS** (default n): Enables or\n+ disables usage of large LLQ headers. This option will have effect only if\n+ the device also supports large LLQ headers. Otherwise, the default value\n+ will be used.\n+\n **ENA Configuration Parameters**\n \n * **Number of Queues**\ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex e1d1a9a7b6..b8bf31be7c 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -894,6 +894,19 @@ ena_calc_io_queue_size(struct ena_calc_queue_size_ctx *ctx)\n \tmax_rx_queue_size = rte_align32prevpow2(max_rx_queue_size);\n \tmax_tx_queue_size = rte_align32prevpow2(max_tx_queue_size);\n \n+#ifdef RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS\n+\tif ((llq->entry_size_ctrl_supported & ENA_ADMIN_LIST_ENTRY_SIZE_256B) &&\n+\t (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV)) {\n+\t\tmax_tx_queue_size /= 2;\n+\t\tPMD_INIT_LOG(INFO,\n+\t\t\t\"Forcing large headers and decreasing maximum TX queue size to %d\\n\",\n+\t\t\tmax_tx_queue_size);\n+\t} else {\n+\t\tPMD_INIT_LOG(ERR,\n+\t\t\t\"Forcing large headers failed: LLQ is disabled or device does not support large headers\\n\");\n+\t}\n+#endif\n+\n \tif (unlikely(max_rx_queue_size == 0 || max_tx_queue_size == 0)) {\n \t\tPMD_INIT_LOG(ERR, \"Invalid queue size\");\n \t\treturn -EFAULT;\n@@ -1595,14 +1608,28 @@ static void ena_timer_wd_callback(__rte_unused struct rte_timer *timer,\n }\n \n static inline void\n-set_default_llq_configurations(struct ena_llq_configurations *llq_config)\n+set_default_llq_configurations(struct ena_llq_configurations *llq_config,\n+\t\t\t struct ena_admin_feature_llq_desc *llq)\n {\n \tllq_config->llq_header_location = ENA_ADMIN_INLINE_HEADER;\n-\tllq_config->llq_ring_entry_size = ENA_ADMIN_LIST_ENTRY_SIZE_128B;\n \tllq_config->llq_stride_ctrl = ENA_ADMIN_MULTIPLE_DESCS_PER_ENTRY;\n \tllq_config->llq_num_decs_before_header =\n \t\tENA_ADMIN_LLQ_NUM_DESCS_BEFORE_HEADER_2;\n+#ifdef RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS\n+\tif ((llq->entry_size_ctrl_supported & ENA_ADMIN_LIST_ENTRY_SIZE_256B)) {\n+\t\tllq_config->llq_ring_entry_size =\n+\t\t\tENA_ADMIN_LIST_ENTRY_SIZE_256B;\n+\t\tllq_config->llq_ring_entry_size_value = 256;\n+\t} else {\n+\t\tllq_config->llq_ring_entry_size =\n+\t\t\tENA_ADMIN_LIST_ENTRY_SIZE_128B;\n+\t\tllq_config->llq_ring_entry_size_value = 128;\n+\t}\n+#else\n+\tllq_config->llq_ring_entry_size = ENA_ADMIN_LIST_ENTRY_SIZE_128B;\n \tllq_config->llq_ring_entry_size_value = 128;\n+\tRTE_SET_USED(llq);\n+#endif\n }\n \n static int\n@@ -1749,7 +1776,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \tadapter->wd_state = wd_state;\n \n-\tset_default_llq_configurations(&llq_config);\n+\tset_default_llq_configurations(&llq_config, &get_feat_ctx.llq);\n \trc = ena_set_queues_placement_policy(adapter, ena_dev,\n \t\t\t\t\t &get_feat_ctx.llq, &llq_config);\n \tif (unlikely(rc)) {\n", "prefixes": [ "17/29" ] }