Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 66687,
    "url": "http://patches.dpdk.org/api/patches/66687/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200316074603.10998-13-leyi.rong@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200316074603.10998-13-leyi.rong@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200316074603.10998-13-leyi.rong@intel.com",
    "date": "2020-03-16T07:46:03",
    "name": "[12/12] net/iavf: add RSS hash parsing in SSE path",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "772368a4e57dd14d71425a9e3b04b64abf431712",
    "submitter": {
        "id": 1204,
        "url": "http://patches.dpdk.org/api/people/1204/?format=api",
        "name": "Leyi Rong",
        "email": "leyi.rong@intel.com"
    },
    "delegate": {
        "id": 31221,
        "url": "http://patches.dpdk.org/api/users/31221/?format=api",
        "username": "yexl",
        "first_name": "xiaolong",
        "last_name": "ye",
        "email": "xiaolong.ye@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200316074603.10998-13-leyi.rong@intel.com/mbox/",
    "series": [
        {
            "id": 8918,
            "url": "http://patches.dpdk.org/api/series/8918/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8918",
            "date": "2020-03-16T07:45:51",
            "name": "framework for advanced iAVF PMD",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8918/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/66687/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/66687/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B967AA0563;\n\tMon, 16 Mar 2020 08:59:41 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 361AB1C118;\n\tMon, 16 Mar 2020 08:57:46 +0100 (CET)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 7A4EC1C0D9\n for <dev@dpdk.org>; Mon, 16 Mar 2020 08:57:42 +0100 (CET)",
            "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Mar 2020 00:57:42 -0700",
            "from dpdk-lrong-srv-04.sh.intel.com ([10.67.119.221])\n by orsmga004.jf.intel.com with ESMTP; 16 Mar 2020 00:57:40 -0700"
        ],
        "IronPort-SDR": [
            "\n Y+xP3d1sSMOVtn2Sjpkf+hf6lGN0BUSXdrY7b+NWW2XHfkqWt9O6L5AdZH5ib3s8O8ue+YGE6q\n Gif9wb8BSJxQ==",
            "\n Kknr9pRxkdQ5MaktsqwdcBIzSlVRPqjDUcMCFs8apMdGlYcXZ/sZ11zFqnL9wkFsbfrPY7I9iM\n Rq3+oTHP2FkQ=="
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.70,559,1574150400\"; d=\"scan'208\";a=\"390622562\"",
        "From": "Leyi Rong <leyi.rong@intel.com>",
        "To": "qi.z.zhang@intel.com,\n\txiaolong.ye@intel.com",
        "Cc": "dev@dpdk.org,\n\tLeyi Rong <leyi.rong@intel.com>",
        "Date": "Mon, 16 Mar 2020 15:46:03 +0800",
        "Message-Id": "<20200316074603.10998-13-leyi.rong@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200316074603.10998-1-leyi.rong@intel.com>",
        "References": "<20200316074603.10998-1-leyi.rong@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 12/12] net/iavf: add RSS hash parsing in SSE path",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Support RSS hash parsing from Flex Rx\ndescriptor in SSE data path.\n\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/iavf/iavf_rxtx_vec_sse.c | 86 ++++++++++++++++++++++------\n 1 file changed, 70 insertions(+), 16 deletions(-)",
    "diff": "diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf_rxtx_vec_sse.c\nindex eb784938f..a615f22e2 100644\n--- a/drivers/net/iavf/iavf_rxtx_vec_sse.c\n+++ b/drivers/net/iavf/iavf_rxtx_vec_sse.c\n@@ -650,7 +650,7 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq,\n \t/* mask to shuffle from desc. to mbuf */\n \tconst __m128i shuf_msk = _mm_set_epi8\n \t\t\t(0xFF, 0xFF,\n-\t\t\t 0xFF, 0xFF,  /* rss not supported */\n+\t\t\t 0xFF, 0xFF,  /* rss hash parsed separately */\n \t\t\t 11, 10,      /* octet 10~11, 16 bits vlan_macip */\n \t\t\t 5, 4,        /* octet 4~5, 16 bits data_len */\n \t\t\t 0xFF, 0xFF,  /* skip high 16 bits pkt_len, zero out */\n@@ -741,7 +741,7 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq,\n \t     pos += IAVF_VPMD_DESCS_PER_LOOP,\n \t     rxdp += IAVF_VPMD_DESCS_PER_LOOP) {\n \t\t__m128i descs[IAVF_VPMD_DESCS_PER_LOOP];\n-\t\t__m128i pkt_mb1, pkt_mb2, pkt_mb3, pkt_mb4;\n+\t\t__m128i pkt_mb0, pkt_mb1, pkt_mb2, pkt_mb3;\n \t\t__m128i staterr, sterr_tmp1, sterr_tmp2;\n \t\t/* 2 64 bit or 4 32 bit mbuf pointers in one XMM reg. */\n \t\t__m128i mbp1;\n@@ -787,8 +787,12 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq,\n \t\trte_compiler_barrier();\n \n \t\t/* D.1 pkt 3,4 convert format from desc to pktmbuf */\n-\t\tpkt_mb4 = _mm_shuffle_epi8(descs[3], shuf_msk);\n-\t\tpkt_mb3 = _mm_shuffle_epi8(descs[2], shuf_msk);\n+\t\tpkt_mb3 = _mm_shuffle_epi8(descs[3], shuf_msk);\n+\t\tpkt_mb2 = _mm_shuffle_epi8(descs[2], shuf_msk);\n+\n+\t\t/* D.1 pkt 1,2 convert format from desc to pktmbuf */\n+\t\tpkt_mb1 = _mm_shuffle_epi8(descs[1], shuf_msk);\n+\t\tpkt_mb0 = _mm_shuffle_epi8(descs[0], shuf_msk);\n \n \t\t/* C.1 4=>2 filter staterr info only */\n \t\tsterr_tmp2 = _mm_unpackhi_epi32(descs[3], descs[2]);\n@@ -798,12 +802,66 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq,\n \t\tflex_desc_to_olflags_v(rxq, descs, &rx_pkts[pos]);\n \n \t\t/* D.2 pkt 3,4 set in_port/nb_seg and remove crc */\n-\t\tpkt_mb4 = _mm_add_epi16(pkt_mb4, crc_adjust);\n \t\tpkt_mb3 = _mm_add_epi16(pkt_mb3, crc_adjust);\n+\t\tpkt_mb2 = _mm_add_epi16(pkt_mb2, crc_adjust);\n \n-\t\t/* D.1 pkt 1,2 convert format from desc to pktmbuf */\n-\t\tpkt_mb2 = _mm_shuffle_epi8(descs[1], shuf_msk);\n-\t\tpkt_mb1 = _mm_shuffle_epi8(descs[0], shuf_msk);\n+\t\t/* D.2 pkt 1,2 set in_port/nb_seg and remove crc */\n+\t\tpkt_mb1 = _mm_add_epi16(pkt_mb1, crc_adjust);\n+\t\tpkt_mb0 = _mm_add_epi16(pkt_mb0, crc_adjust);\n+\n+\t\t/**\n+\t\t * needs to load 2nd 16B of each desc for RSS hash parsing,\n+\t\t * will cause performance drop to get into this context.\n+\t\t */\n+\t\tif (rxq->vsi->adapter->eth_dev->data->dev_conf.rxmode.offloads &\n+\t\t\t\tDEV_RX_OFFLOAD_RSS_HASH) {\n+\t\t\t/* load bottom half of every 32B desc */\n+\t\t\tconst __m128i raw_desc_bh3 =\n+\t\t\t\t_mm_load_si128\n+\t\t\t\t\t((void *)(&rxdp[3].wb.status_error1));\n+\t\t\trte_compiler_barrier();\n+\t\t\tconst __m128i raw_desc_bh2 =\n+\t\t\t\t_mm_load_si128\n+\t\t\t\t\t((void *)(&rxdp[2].wb.status_error1));\n+\t\t\trte_compiler_barrier();\n+\t\t\tconst __m128i raw_desc_bh1 =\n+\t\t\t\t_mm_load_si128\n+\t\t\t\t\t((void *)(&rxdp[1].wb.status_error1));\n+\t\t\trte_compiler_barrier();\n+\t\t\tconst __m128i raw_desc_bh0 =\n+\t\t\t\t_mm_load_si128\n+\t\t\t\t\t((void *)(&rxdp[0].wb.status_error1));\n+\n+\t\t\t/**\n+\t\t\t * to shift the 32b RSS hash value to the\n+\t\t\t * highest 32b of each 128b before mask\n+\t\t\t */\n+\t\t\t__m128i rss_hash3 =\n+\t\t\t\t_mm_slli_epi64(raw_desc_bh3, 32);\n+\t\t\t__m128i rss_hash2 =\n+\t\t\t\t_mm_slli_epi64(raw_desc_bh2, 32);\n+\t\t\t__m128i rss_hash1 =\n+\t\t\t\t_mm_slli_epi64(raw_desc_bh1, 32);\n+\t\t\t__m128i rss_hash0 =\n+\t\t\t\t_mm_slli_epi64(raw_desc_bh0, 32);\n+\n+\t\t\t__m128i rss_hash_msk =\n+\t\t\t\t_mm_set_epi32(0xFFFFFFFF, 0, 0, 0);\n+\n+\t\t\trss_hash3 = _mm_and_si128\n+\t\t\t\t\t(rss_hash3, rss_hash_msk);\n+\t\t\trss_hash2 = _mm_and_si128\n+\t\t\t\t\t(rss_hash2, rss_hash_msk);\n+\t\t\trss_hash1 = _mm_and_si128\n+\t\t\t\t\t(rss_hash1, rss_hash_msk);\n+\t\t\trss_hash0 = _mm_and_si128\n+\t\t\t\t\t(rss_hash0, rss_hash_msk);\n+\n+\t\t\tpkt_mb3 = _mm_or_si128(pkt_mb3, rss_hash3);\n+\t\t\tpkt_mb2 = _mm_or_si128(pkt_mb2, rss_hash2);\n+\t\t\tpkt_mb1 = _mm_or_si128(pkt_mb1, rss_hash1);\n+\t\t\tpkt_mb0 = _mm_or_si128(pkt_mb0, rss_hash0);\n+\t\t} /* if() on RSS hash parsing */\n \n \t\t/* C.2 get 4 pkts staterr value  */\n \t\tstaterr = _mm_unpacklo_epi32(sterr_tmp1, sterr_tmp2);\n@@ -811,14 +869,10 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq,\n \t\t/* D.3 copy final 3,4 data to rx_pkts */\n \t\t_mm_storeu_si128\n \t\t\t((void *)&rx_pkts[pos + 3]->rx_descriptor_fields1,\n-\t\t\t pkt_mb4);\n+\t\t\t pkt_mb3);\n \t\t_mm_storeu_si128\n \t\t\t((void *)&rx_pkts[pos + 2]->rx_descriptor_fields1,\n-\t\t\t pkt_mb3);\n-\n-\t\t/* D.2 pkt 1,2 set in_port/nb_seg and remove crc */\n-\t\tpkt_mb2 = _mm_add_epi16(pkt_mb2, crc_adjust);\n-\t\tpkt_mb1 = _mm_add_epi16(pkt_mb1, crc_adjust);\n+\t\t\t pkt_mb2);\n \n \t\t/* C* extract and record EOP bit */\n \t\tif (split_packet) {\n@@ -842,9 +896,9 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq,\n \t\t/* D.3 copy final 1,2 data to rx_pkts */\n \t\t_mm_storeu_si128\n \t\t\t((void *)&rx_pkts[pos + 1]->rx_descriptor_fields1,\n-\t\t\t pkt_mb2);\n+\t\t\t pkt_mb1);\n \t\t_mm_storeu_si128((void *)&rx_pkts[pos]->rx_descriptor_fields1,\n-\t\t\t\t pkt_mb1);\n+\t\t\t\t pkt_mb0);\n \t\tflex_desc_to_ptype_v(descs, &rx_pkts[pos], ptype_tbl);\n \t\t/* C.4 calc avaialbe number of desc */\n \t\tvar = __builtin_popcountll(_mm_cvtsi128_si64(staterr));\n",
    "prefixes": [
        "12/12"
    ]
}