Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66639/?format=api
{ "id": 66639, "url": "http://patches.dpdk.org/api/patches/66639/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200313091835.58039-7-gavin.hu@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200313091835.58039-7-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200313091835.58039-7-gavin.hu@arm.com", "date": "2020-03-13T09:18:34", "name": "[RFC,v1,6/7] net/ena: use c11 atomic for statistics", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "842e3ad392979c2640be83463a1e3d86b961e0c0", "submitter": { "id": 1018, "url": "http://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200313091835.58039-7-gavin.hu@arm.com/mbox/", "series": [ { "id": 8902, "url": "http://patches.dpdk.org/api/series/8902/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8902", "date": "2020-03-13T09:18:28", "name": "relax barriers for ENA PMD and small fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/8902/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66639/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66639/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 32EEEA0567;\n\tFri, 13 Mar 2020 10:20:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 68A9C1C036;\n\tFri, 13 Mar 2020 10:20:15 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 24A811C06C\n for <dev@dpdk.org>; Fri, 13 Mar 2020 10:20:13 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB39731B;\n Fri, 13 Mar 2020 02:20:12 -0700 (PDT)", "from net-arm-thunderx2-04.shanghai.arm.com\n (net-arm-thunderx2-04.shanghai.arm.com [10.169.40.184])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 07F7D3F67D;\n Fri, 13 Mar 2020 02:20:08 -0700 (PDT)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, david.marchand@redhat.com, thomas@monjalon.net,\n mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, igorch@amazon.com,\n mw@semihalf.com, Honnappa.Nagarahalli@arm.com, ruifeng.wang@arm.com,\n phil.yang@arm.com, joyce.kong@arm.com", "Date": "Fri, 13 Mar 2020 17:18:34 +0800", "Message-Id": "<20200313091835.58039-7-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200313091835.58039-1-gavin.hu@arm.com>", "References": "<20200313091835.58039-1-gavin.hu@arm.com>", "Subject": "[dpdk-dev] [PATCH RFC v1 6/7] net/ena: use c11 atomic for statistics", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The statistics logging are in the data path, as rte_atomic APIs enforce\nunnecessary barriers on aarch64, this patch uses c11 atomic APIs with\nthe __ATOMIC_RELAXED memory ordering to give CPU more freedom to optimize\nby making use of out-of-order execution.\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n drivers/net/ena/ena_ethdev.c | 38 ++++++++++++++++++++++++------------\n drivers/net/ena/ena_ethdev.h | 8 ++++----\n 2 files changed, 29 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex c268788fd..8b566aecd 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -8,7 +8,6 @@\n #include <rte_ethdev_driver.h>\n #include <rte_ethdev_pci.h>\n #include <rte_tcp.h>\n-#include <rte_atomic.h>\n #include <rte_dev.h>\n #include <rte_errno.h>\n #include <rte_version.h>\n@@ -902,10 +901,14 @@ static void ena_stats_restart(struct rte_eth_dev *dev)\n {\n \tstruct ena_adapter *adapter = dev->data->dev_private;\n \n-\trte_atomic64_init(&adapter->drv_stats->ierrors);\n-\trte_atomic64_init(&adapter->drv_stats->oerrors);\n-\trte_atomic64_init(&adapter->drv_stats->rx_nombuf);\n-\trte_atomic64_init(&adapter->drv_stats->rx_drops);\n+\t__atomic_store_n(&adapter->drv_stats->ierrors, 1,\n+\t\t __ATOMIC_RELAXED);\n+\t__atomic_store_n(&adapter->drv_stats->oerrors, 1,\n+\t\t __ATOMIC_RELAXED);\n+\t__atomic_store_n(&adapter->drv_stats->rx_nombuf, 1,\n+\t\t __ATOMIC_RELAXED);\n+\t__atomic_store_n(&adapter->drv_stats->rx_drops, 1,\n+\t\t __ATOMIC_RELAXED);\n }\n \n static int ena_stats_get(struct rte_eth_dev *dev,\n@@ -939,10 +942,14 @@ static int ena_stats_get(struct rte_eth_dev *dev,\n \t\t\t\t\tena_stats.tx_bytes_low);\n \n \t/* Driver related stats */\n-\tstats->imissed = rte_atomic64_read(&adapter->drv_stats->rx_drops);\n-\tstats->ierrors = rte_atomic64_read(&adapter->drv_stats->ierrors);\n-\tstats->oerrors = rte_atomic64_read(&adapter->drv_stats->oerrors);\n-\tstats->rx_nombuf = rte_atomic64_read(&adapter->drv_stats->rx_nombuf);\n+\tstats->imissed = __atomic_load_n(&adapter->drv_stats->rx_drops,\n+\t\t __ATOMIC_RELAXED);\n+\tstats->ierrors = __atomic_load_n(&adapter->drv_stats->ierrors,\n+\t\t __ATOMIC_RELAXED);\n+\tstats->oerrors = __atomic_load_n(&adapter->drv_stats->oerrors,\n+\t\t __ATOMIC_RELAXED);\n+\tstats->rx_nombuf = __atomic_load_n(&adapter->drv_stats->rx_nombuf,\n+\t\t __ATOMIC_RELAXED);\n \n \tmax_rings_stats = RTE_MIN(dev->data->nb_rx_queues,\n \t\tRTE_ETHDEV_QUEUE_STAT_CNTRS);\n@@ -1376,7 +1383,8 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count)\n \t/* get resources for incoming packets */\n \trc = rte_mempool_get_bulk(rxq->mb_pool, (void **)mbufs, count);\n \tif (unlikely(rc < 0)) {\n-\t\trte_atomic64_inc(&rxq->adapter->drv_stats->rx_nombuf);\n+\t\t__atomic_add_fetch(&rxq->adapter->drv_stats->rx_nombuf, 1,\n+\t\t\t\t__ATOMIC_RELAXED);\n \t\t++rxq->rx_stats.mbuf_alloc_fail;\n \t\tPMD_RX_LOG(DEBUG, \"there are no enough free buffers\");\n \t\treturn 0;\n@@ -2074,7 +2082,9 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \n \t\tif (unlikely(mbuf_head->ol_flags &\n \t\t\t\t(PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD))) {\n-\t\t\trte_atomic64_inc(&rx_ring->adapter->drv_stats->ierrors);\n+\t\t\t__atomic_add_fetch\n+\t\t\t\t(&rx_ring->adapter->drv_stats->ierrors,\n+\t\t\t\t1, __ATOMIC_RELAXED);\n \t\t\t++rx_ring->rx_stats.bad_csum;\n \t\t}\n \n@@ -2214,7 +2224,8 @@ static int ena_check_and_linearize_mbuf(struct ena_ring *tx_ring,\n \trc = rte_pktmbuf_linearize(mbuf);\n \tif (unlikely(rc)) {\n \t\tPMD_DRV_LOG(WARNING, \"Mbuf linearize failed\\n\");\n-\t\trte_atomic64_inc(&tx_ring->adapter->drv_stats->ierrors);\n+\t\t__atomic_add_fetch(&tx_ring->adapter->drv_stats->ierrors,\n+\t\t\t 1, __ATOMIC_RELAXED);\n \t\t++tx_ring->tx_stats.linearize_failed;\n \t\treturn rc;\n \t}\n@@ -2682,7 +2693,8 @@ static void ena_keep_alive(void *adapter_data,\n \n \tdesc = (struct ena_admin_aenq_keep_alive_desc *)aenq_e;\n \trx_drops = ((uint64_t)desc->rx_drops_high << 32) | desc->rx_drops_low;\n-\trte_atomic64_set(&adapter->drv_stats->rx_drops, rx_drops);\n+\t__atomic_store_n(&adapter->drv_stats->rx_drops, rx_drops,\n+\t\t __ATOMIC_RELAXED);\n }\n \n /**\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex af5eeea28..e7d39c09f 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -129,10 +129,10 @@ enum ena_adapter_state {\n };\n \n struct ena_driver_stats {\n-\trte_atomic64_t ierrors;\n-\trte_atomic64_t oerrors;\n-\trte_atomic64_t rx_nombuf;\n-\trte_atomic64_t rx_drops;\n+\tuint64_t ierrors;\n+\tuint64_t oerrors;\n+\tuint64_t rx_nombuf;\n+\tuint64_t rx_drops;\n };\n \n struct ena_stats_dev {\n", "prefixes": [ "RFC", "v1", "6/7" ] }