Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66629/?format=api
{ "id": 66629, "url": "http://patches.dpdk.org/api/patches/66629/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200313081614.195335-2-ruifeng.wang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200313081614.195335-2-ruifeng.wang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200313081614.195335-2-ruifeng.wang@arm.com", "date": "2020-03-13T08:16:11", "name": "[v3,1/4] test: enable tests to run in no-huge mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "55218349c0baecde84c70fdea86c31f203b168b0", "submitter": { "id": 1198, "url": "http://patches.dpdk.org/api/people/1198/?format=api", "name": "Ruifeng Wang", "email": "ruifeng.wang@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200313081614.195335-2-ruifeng.wang@arm.com/mbox/", "series": [ { "id": 8901, "url": "http://patches.dpdk.org/api/series/8901/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8901", "date": "2020-03-13T08:16:10", "name": "no-huge unit test", "version": 3, "mbox": "http://patches.dpdk.org/series/8901/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66629/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66629/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 78984A0567;\n\tFri, 13 Mar 2020 09:17:08 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5D9761C028;\n\tFri, 13 Mar 2020 09:17:08 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id E41553B5;\n Fri, 13 Mar 2020 09:17:06 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C2C731B;\n Fri, 13 Mar 2020 01:17:06 -0700 (PDT)", "from net-arm-thunderx2-02.shanghai.arm.com\n (net-arm-thunderx2-02.shanghai.arm.com [10.169.40.171])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 493793F67D;\n Fri, 13 Mar 2020 01:17:02 -0700 (PDT)" ], "From": "Ruifeng Wang <ruifeng.wang@arm.com>", "To": "aconole@redhat.com, maicolgabriel@hotmail.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com,\n yipeng1.wang@intel.com, sameh.gobriel@intel.com", "Cc": "dev@dpdk.org, david.marchand@redhat.com, anatoly.burakov@intel.com,\n gavin.hu@arm.com, honnappa.nagarahalli@arm.com, juraj.linkes@pantheon.tech,\n nd@arm.com, Ruifeng Wang <ruifeng.wang@arm.com>, stable@dpdk.org", "Date": "Fri, 13 Mar 2020 16:16:11 +0800", "Message-Id": "<20200313081614.195335-2-ruifeng.wang@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200313081614.195335-1-ruifeng.wang@arm.com>", "References": "<20200225073236.135581-1-ruifeng.wang@arm.com>\n <20200313081614.195335-1-ruifeng.wang@arm.com>", "Subject": "[dpdk-dev] [PATCH v3 1/4] test: enable tests to run in no-huge mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When running with '--no-huge' flag, tests failed with messages as:\n ACL context creation with invalid NUMA should have failed!\n fbk hash creation should have failed\n test_table_pipeline: Check pipeline invalid params failed.\n\nThese cases test against invalid socket ID as input parameter, and\nexpect error return. But function calls return success because\ninvalid sock ID is overwritten to SOCKET_ID_ANY when in no-huge mode.\n\nThe tests against invalid socket ID are skipped in no-huge mode.\n\nFixes: 5640171c528a (\"malloc: fix external heap allocation in no-huge mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\n---\n app/test/test_acl.c | 22 ++++++++++++----------\n app/test/test_hash.c | 7 +++++--\n app/test/test_table_pipeline.c | 12 +++++++-----\n 3 files changed, 24 insertions(+), 17 deletions(-)", "diff": "diff --git a/app/test/test_acl.c b/app/test/test_acl.c\nindex 501de35da..316bf4d06 100644\n--- a/app/test/test_acl.c\n+++ b/app/test/test_acl.c\n@@ -1397,16 +1397,18 @@ test_invalid_parameters(void)\n \t} else\n \t\trte_acl_free(acx);\n \n-\t/* invalid NUMA node */\n-\tmemcpy(¶m, &acl_param, sizeof(param));\n-\tparam.socket_id = RTE_MAX_NUMA_NODES + 1;\n-\n-\tacx = rte_acl_create(¶m);\n-\tif (acx != NULL) {\n-\t\tprintf(\"Line %i: ACL context creation with invalid NUMA \"\n-\t\t\t\t\"should have failed!\\n\", __LINE__);\n-\t\trte_acl_free(acx);\n-\t\treturn -1;\n+\tif (rte_eal_has_hugepages()) {\n+\t\t/* invalid NUMA node */\n+\t\tmemcpy(¶m, &acl_param, sizeof(param));\n+\t\tparam.socket_id = RTE_MAX_NUMA_NODES + 1;\n+\n+\t\tacx = rte_acl_create(¶m);\n+\t\tif (acx != NULL) {\n+\t\t\tprintf(\"Line %i: ACL context creation with invalid \"\n+\t\t\t\t\t\"NUMA should have failed!\\n\", __LINE__);\n+\t\t\trte_acl_free(acx);\n+\t\t\treturn -1;\n+\t\t}\n \t}\n \n \t/* NULL name */\ndiff --git a/app/test/test_hash.c b/app/test/test_hash.c\nindex fbd5725c6..ab978ea68 100644\n--- a/app/test/test_hash.c\n+++ b/app/test/test_hash.c\n@@ -1136,8 +1136,11 @@ fbk_hash_unit_test(void)\n \thandle = rte_fbk_hash_create(&invalid_params_7);\n \tRETURN_IF_ERROR_FBK(handle != NULL, \"fbk hash creation should have failed\");\n \n-\thandle = rte_fbk_hash_create(&invalid_params_8);\n-\tRETURN_IF_ERROR_FBK(handle != NULL, \"fbk hash creation should have failed\");\n+\tif (rte_eal_has_hugepages()) {\n+\t\thandle = rte_fbk_hash_create(&invalid_params_8);\n+\t\tRETURN_IF_ERROR_FBK(handle != NULL,\n+\t\t\t\t\t\"fbk hash creation should have failed\");\n+\t}\n \n \thandle = rte_fbk_hash_create(&invalid_params_same_name_1);\n \tRETURN_IF_ERROR_FBK(handle == NULL, \"fbk hash creation should have succeeded\");\ndiff --git a/app/test/test_table_pipeline.c b/app/test/test_table_pipeline.c\nindex 441338ac0..bc412c308 100644\n--- a/app/test/test_table_pipeline.c\n+++ b/app/test/test_table_pipeline.c\n@@ -190,11 +190,13 @@ check_pipeline_invalid_params(void)\n \t\tgoto fail;\n \t}\n \n-\tp = rte_pipeline_create(&pipeline_params_3);\n-\tif (p != NULL) {\n-\t\tRTE_LOG(INFO, PIPELINE, \"%s: Configure pipeline with invalid \"\n-\t\t\t\"socket\\n\", __func__);\n-\t\tgoto fail;\n+\tif (rte_eal_has_hugepages()) {\n+\t\tp = rte_pipeline_create(&pipeline_params_3);\n+\t\tif (p != NULL) {\n+\t\t\tRTE_LOG(INFO, PIPELINE, \"%s: Configure pipeline with \"\n+\t\t\t\t\"invalid socket\\n\", __func__);\n+\t\t\tgoto fail;\n+\t\t}\n \t}\n \n \t/* Check pipeline consistency */\n", "prefixes": [ "v3", "1/4" ] }