Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66522/?format=api
{ "id": 66522, "url": "http://patches.dpdk.org/api/patches/66522/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1583862551-2049-9-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1583862551-2049-9-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1583862551-2049-9-git-send-email-phil.yang@arm.com", "date": "2020-03-10T17:49:09", "name": "[08/10] service: identify service running on another core correctly", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b541eb43ac015098328c57abf3220a3dacb6ce0d", "submitter": { "id": 833, "url": "http://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1583862551-2049-9-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 8875, "url": "http://patches.dpdk.org/api/series/8875/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8875", "date": "2020-03-10T17:49:01", "name": "generic rte atomic APIs deprecate proposal", "version": 1, "mbox": "http://patches.dpdk.org/series/8875/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66522/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66522/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E07C1A0566;\n\tTue, 10 Mar 2020 18:51:24 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 16AA41C0D0;\n\tTue, 10 Mar 2020 18:50:29 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 8C5271C0D0;\n Tue, 10 Mar 2020 18:50:27 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F2921FB;\n Tue, 10 Mar 2020 10:50:27 -0700 (PDT)", "from phil-VirtualBox.arm.com (A010647.Arm.com [10.170.243.28])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D1D383F534;\n Tue, 10 Mar 2020 10:50:22 -0700 (PDT)" ], "From": "Phil Yang <phil.yang@arm.com>", "To": "thomas@monjalon.net, harry.van.haaren@intel.com,\n konstantin.ananyev@intel.com, stephen@networkplumber.org,\n maxime.coquelin@redhat.com, dev@dpdk.org", "Cc": "david.marchand@redhat.com, jerinj@marvell.com, hemant.agrawal@nxp.com,\n Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, ruifeng.wang@arm.com,\n joyce.kong@arm.com, nd@arm.com,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, stable@dpdk.org", "Date": "Wed, 11 Mar 2020 01:49:09 +0800", "Message-Id": "<1583862551-2049-9-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1583862551-2049-1-git-send-email-phil.yang@arm.com>", "References": "<1583862551-2049-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH 08/10] service: identify service running on\n\tanother core correctly", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n\nThe logic to identify if the MT unsafe service is running on another\ncore can return -EBUSY spuriously. In such cases, running the service\nbecomes more costlier than using atomic operations. Assume that the\napplication passes the right parameters and reduce the number of\ninstructions for all cases.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\n---\n lib/librte_eal/common/rte_service.c | 26 ++++++++------------------\n 1 file changed, 8 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c\nindex b37fc56..0186024 100644\n--- a/lib/librte_eal/common/rte_service.c\n+++ b/lib/librte_eal/common/rte_service.c\n@@ -357,7 +357,7 @@ service_runner_do_callback(struct rte_service_spec_impl *s,\n /* Expects the service 's' is valid. */\n static int32_t\n service_run(uint32_t i, struct core_state *cs, uint64_t service_mask,\n-\t struct rte_service_spec_impl *s)\n+\t struct rte_service_spec_impl *s, uint32_t serialize_mt_unsafe)\n {\n \tif (!s)\n \t\treturn -EINVAL;\n@@ -371,7 +371,7 @@ service_run(uint32_t i, struct core_state *cs, uint64_t service_mask,\n \n \tcs->service_active_on_lcore[i] = 1;\n \n-\tif (service_mt_safe(s) == 0) {\n+\tif ((service_mt_safe(s) == 0) && (serialize_mt_unsafe == 1)) {\n \t\tif (!rte_atomic32_cmpset((uint32_t *)&s->execute_lock, 0, 1))\n \t\t\treturn -EBUSY;\n \n@@ -409,24 +409,14 @@ rte_service_run_iter_on_app_lcore(uint32_t id, uint32_t serialize_mt_unsafe)\n \n \tSERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);\n \n-\t/* Atomically add this core to the mapped cores first, then examine if\n-\t * we can run the service. This avoids a race condition between\n-\t * checking the value, and atomically adding to the mapped count.\n+\t/* Increment num_mapped_cores to indicate that the service is\n+\t * is running on a core.\n \t */\n-\tif (serialize_mt_unsafe)\n-\t\trte_atomic32_inc(&s->num_mapped_cores);\n+\trte_atomic32_inc(&s->num_mapped_cores);\n \n-\tif (service_mt_safe(s) == 0 &&\n-\t\t\trte_atomic32_read(&s->num_mapped_cores) > 1) {\n-\t\tif (serialize_mt_unsafe)\n-\t\t\trte_atomic32_dec(&s->num_mapped_cores);\n-\t\treturn -EBUSY;\n-\t}\n-\n-\tint ret = service_run(id, cs, UINT64_MAX, s);\n+\tint ret = service_run(id, cs, UINT64_MAX, s, serialize_mt_unsafe);\n \n-\tif (serialize_mt_unsafe)\n-\t\trte_atomic32_dec(&s->num_mapped_cores);\n+\trte_atomic32_dec(&s->num_mapped_cores);\n \n \treturn ret;\n }\n@@ -446,7 +436,7 @@ service_runner_func(void *arg)\n \t\t\tif (!service_valid(i))\n \t\t\t\tcontinue;\n \t\t\t/* return value ignored as no change to code flow */\n-\t\t\tservice_run(i, cs, service_mask, service_get(i));\n+\t\t\tservice_run(i, cs, service_mask, service_get(i), 1);\n \t\t}\n \n \t\tcs->loops++;\n", "prefixes": [ "08/10" ] }