Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66469/?format=api
{ "id": 66469, "url": "http://patches.dpdk.org/api/patches/66469/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200309145442.28926-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200309145442.28926-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200309145442.28926-1-david.marchand@redhat.com", "date": "2020-03-09T14:54:42", "name": "mem: mark pages as not accessed when reserving VA", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a341b55484dfc025e5584adc38b170df6e3efc09", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200309145442.28926-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 8852, "url": "http://patches.dpdk.org/api/series/8852/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8852", "date": "2020-03-09T14:54:42", "name": "mem: mark pages as not accessed when reserving VA", "version": 1, "mbox": "http://patches.dpdk.org/series/8852/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66469/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66469/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3E3BAA052E;\n\tMon, 9 Mar 2020 15:55:43 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C6EA51C08E;\n\tMon, 9 Mar 2020 15:55:42 +0100 (CET)", "from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 359AA1C0B3\n for <dev@dpdk.org>; Mon, 9 Mar 2020 15:55:41 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-386-SlIrKS3KPpC-a4ucKWQ8Lg-1; Mon, 09 Mar 2020 10:55:37 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 14D328017CC;\n Mon, 9 Mar 2020 14:55:36 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-36.brq.redhat.com [10.40.204.36])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 9E12865E80;\n Mon, 9 Mar 2020 14:55:31 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1583765740;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=jE+RjU9pOuVC1wqofvLSbIlQCdzPDgoOqxHknGMg/+8=;\n b=DyyLBMaFzX1abWNcEU6EMjpZfZD/GHDzYqLZc8p/1R6MRwfmRji8Y3T5glSChCKIxu4dyJ\n JBDEoAnz63znJonrtIB907VGUiPvs+hDE0fho4XtkHa3cE4SzVpbXC5DKXKd1rL8KMQgco\n sbRQlMU6Mqcaaayk9aqvENTmqB6Neas=", "X-MC-Unique": "SlIrKS3KPpC-a4ucKWQ8Lg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "echaudro@redhat.com, aconole@redhat.com, maxime.coquelin@redhat.com,\n stable@dpdk.org, Andrea Arcangeli <aarcange@redhat.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Mon, 9 Mar 2020 15:54:42 +0100", "Message-Id": "<20200309145442.28926-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH] mem: mark pages as not accessed when reserving VA", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When the memory allocator reserves virtual addresses, it still does not\nknow what they will be used for.\nBesides, huge areas are reserved for memory hotplug in multiprocess\nsetups. But most of the pages are unused in the whole life of the\nprocesses.\n\nChange protection mode to PROT_NONE when only reserving VA.\nThe memory allocator already switches to the right mode when making use\nof it.\n\nIt also has the nice effect of getting those pages skipped by the kernel\nwhen calling mlockall() or when a coredump gets generated.\n\nCc: stable@dpdk.org\n\nSuggested-by: Andrea Arcangeli <aarcange@redhat.com>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/librte_eal/common/eal_common_memory.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c\nindex 4a9cc1f19..cc7d54e0c 100644\n--- a/lib/librte_eal/common/eal_common_memory.c\n+++ b/lib/librte_eal/common/eal_common_memory.c\n@@ -97,7 +97,7 @@ eal_get_virtual_area(void *requested_addr, size_t *size,\n \t\t\treturn NULL;\n \t\t}\n \n-\t\tmapped_addr = mmap(requested_addr, (size_t)map_sz, PROT_READ,\n+\t\tmapped_addr = mmap(requested_addr, (size_t)map_sz, PROT_NONE,\n \t\t\t\tmmap_flags, -1, 0);\n \t\tif (mapped_addr == MAP_FAILED && allow_shrink)\n \t\t\t*size -= page_sz;\n", "prefixes": [] }