Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66432/?format=api
{ "id": 66432, "url": "http://patches.dpdk.org/api/patches/66432/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200309114357.31800-16-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200309114357.31800-16-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200309114357.31800-16-qi.z.zhang@intel.com", "date": "2020-03-09T11:43:44", "name": "[15/28] net/ice/base: capitalize abbreviations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f9dc9b2dd88ed96d859f4f0ca00ba4f374c766fa", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200309114357.31800-16-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 8843, "url": "http://patches.dpdk.org/api/series/8843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8843", "date": "2020-03-09T11:43:29", "name": "update ice base code", "version": 1, "mbox": "http://patches.dpdk.org/series/8843/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66432/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66432/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4FBC6A052E;\n\tMon, 9 Mar 2020 12:43:01 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BFCCC1C136;\n\tMon, 9 Mar 2020 12:41:02 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id E5A121C135\n for <dev@dpdk.org>; Mon, 9 Mar 2020 12:41:00 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 09 Mar 2020 04:41:00 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n by fmsmga002.fm.intel.com with ESMTP; 09 Mar 2020 04:40:58 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,533,1574150400\"; d=\"scan'208\";a=\"276483586\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com,\n\tbeilei.xing@intel.com", "Cc": "xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Tony Nguyen <anthony.l.nguyen@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 9 Mar 2020 19:43:44 +0800", "Message-Id": "<20200309114357.31800-16-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200309114357.31800-1-qi.z.zhang@intel.com>", "References": "<20200309114357.31800-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 15/28] net/ice/base: capitalize abbreviations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix abbreviations as found by abbrevcheck\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_dcb.c | 8 +++---\n drivers/net/ice/base/ice_fdir.c | 6 ++---\n drivers/net/ice/base/ice_flex_pipe.c | 52 ++++++++++++++++++------------------\n drivers/net/ice/base/ice_flex_type.h | 6 ++---\n drivers/net/ice/base/ice_switch.c | 1 -\n 5 files changed, 36 insertions(+), 37 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_dcb.c b/drivers/net/ice/base/ice_dcb.c\nindex 7048dbd02..63c981b8e 100644\n--- a/drivers/net/ice/base/ice_dcb.c\n+++ b/drivers/net/ice/base/ice_dcb.c\n@@ -1323,13 +1323,13 @@ enum ice_status ice_set_dcb_cfg(struct ice_port_info *pi)\n }\n \n /**\n- * ice_aq_query_port_ets - query port ets configuration\n+ * ice_aq_query_port_ets - query port ETS configuration\n * @pi: port information structure\n * @buf: pointer to buffer\n * @buf_size: buffer size in bytes\n * @cd: pointer to command details structure or NULL\n *\n- * query current port ets configuration\n+ * query current port ETS configuration\n */\n enum ice_status\n ice_aq_query_port_ets(struct ice_port_info *pi,\n@@ -1416,13 +1416,13 @@ ice_update_port_tc_tree_cfg(struct ice_port_info *pi,\n }\n \n /**\n- * ice_query_port_ets - query port ets configuration\n+ * ice_query_port_ets - query port ETS configuration\n * @pi: port information structure\n * @buf: pointer to buffer\n * @buf_size: buffer size in bytes\n * @cd: pointer to command details structure or NULL\n *\n- * query current port ets configuration and update the\n+ * query current port ETS configuration and update the\n * SW DB with the TC changes\n */\n enum ice_status\ndiff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c\nindex ba002586b..90e7e082f 100644\n--- a/drivers/net/ice/base/ice_fdir.c\n+++ b/drivers/net/ice/base/ice_fdir.c\n@@ -628,13 +628,13 @@ static void ice_pkt_insert_u8(u8 *pkt, int offset, u8 data)\n }\n \n /**\n- * ice_pkt_insert_u8_tc - insert a u8 value into a memory buffer for tc ipv6.\n+ * ice_pkt_insert_u8_tc - insert a u8 value into a memory buffer for TC ipv6.\n * @pkt: packet buffer\n * @offset: offset into buffer\n * @data: 8 bit value to convert and insert into pkt at offset\n *\n- * This function is designed for inserting Traffic Class (tc) for IPv6,\n- * since that tc is not aligned in number of bytes. Here we split it out\n+ * This function is designed for inserting Traffic Class (TC) for IPv6,\n+ * since that TC is not aligned in number of bytes. Here we split it out\n * into two part and fill each byte with data copy from pkt, then insert\n * the two bytes data one by one.\n */\ndiff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex 8a27637f8..2e64adbe4 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -2105,7 +2105,7 @@ ice_find_prot_off(struct ice_hw *hw, enum ice_block blk, u8 prof, u8 fv_idx,\n * @ptg: pointer to variable that receives the PTG\n *\n * This function will search the PTGs for a particular ptype, returning the\n- * PTG ID that contains it through the ptg parameter, with the value of\n+ * PTG ID that contains it through the PTG parameter, with the value of\n * ICE_DEFAULT_PTG (0) meaning it is part the default PTG.\n */\n static enum ice_status\n@@ -2122,9 +2122,9 @@ ice_ptg_find_ptype(struct ice_hw *hw, enum ice_block blk, u16 ptype, u8 *ptg)\n * ice_ptg_alloc_val - Allocates a new packet type group ID by value\n * @hw: pointer to the hardware structure\n * @blk: HW block\n- * @ptg: the ptg to allocate\n+ * @ptg: the PTG to allocate\n *\n- * This function allocates a given packet type group ID specified by the ptg\n+ * This function allocates a given packet type group ID specified by the PTG\n * parameter.\n */\n static void ice_ptg_alloc_val(struct ice_hw *hw, enum ice_block blk, u8 ptg)\n@@ -2137,9 +2137,9 @@ static void ice_ptg_alloc_val(struct ice_hw *hw, enum ice_block blk, u8 ptg)\n * @hw: pointer to the hardware structure\n * @blk: HW block\n * @ptype: the ptype to remove\n- * @ptg: the ptg to remove the ptype from\n+ * @ptg: the PTG to remove the ptype from\n *\n- * This function will remove the ptype from the specific ptg, and move it to\n+ * This function will remove the ptype from the specific PTG, and move it to\n * the default PTG (ICE_DEFAULT_PTG).\n */\n static enum ice_status\n@@ -2182,7 +2182,7 @@ ice_ptg_remove_ptype(struct ice_hw *hw, enum ice_block blk, u16 ptype, u8 ptg)\n * @hw: pointer to the hardware structure\n * @blk: HW block\n * @ptype: the ptype to add or move\n- * @ptg: the ptg to add or move the ptype to\n+ * @ptg: the PTG to add or move the ptype to\n *\n * This function will either add or move a ptype to a particular PTG depending\n * on if the ptype is already part of another group. Note that using a\n@@ -2235,7 +2235,7 @@ struct ice_blk_size_details {\n \tu16 xlt2;\t\t\t/* # XLT2 entries */\n \tu16 prof_tcam;\t\t\t/* # profile ID TCAM entries */\n \tu16 prof_id;\t\t\t/* # profile IDs */\n-\tu8 prof_cdid_bits;\t\t/* # cdid one-hot bits used in key */\n+\tu8 prof_cdid_bits;\t\t/* # CDID one-hot bits used in key */\n \tu16 prof_redir;\t\t\t/* # profile redirection entries */\n \tu16 es;\t\t\t\t/* # extraction sequence entries */\n \tu16 fvw;\t\t\t/* # field vector words */\n@@ -2354,9 +2354,9 @@ ice_vsig_find_vsi(struct ice_hw *hw, enum ice_block blk, u16 vsi, u16 *vsig)\n * ice_vsig_alloc_val - allocate a new VSIG by value\n * @hw: pointer to the hardware structure\n * @blk: HW block\n- * @vsig: the vsig to allocate\n+ * @vsig: the VSIG to allocate\n *\n- * This function will allocate a given VSIG specified by the vsig parameter.\n+ * This function will allocate a given VSIG specified by the VSIG parameter.\n */\n static u16 ice_vsig_alloc_val(struct ice_hw *hw, enum ice_block blk, u16 vsig)\n {\n@@ -3789,7 +3789,7 @@ enum ice_status ice_init_hw_tbls(struct ice_hw *hw)\n * @blk: the block in which to write profile ID to\n * @ptg: packet type group (PTG) portion of key\n * @vsig: VSIG portion of key\n- * @cdid: cdid portion of key\n+ * @cdid: CDID portion of key\n * @flags: flag portion of key\n * @vl_msk: valid mask\n * @dc_msk: don't care mask\n@@ -3846,7 +3846,7 @@ ice_prof_gen_key(struct ice_hw *hw, enum ice_block blk, u8 ptg, u16 vsig,\n * @prof_id: profile ID\n * @ptg: packet type group (PTG) portion of key\n * @vsig: VSIG portion of key\n- * @cdid: cdid portion of key\n+ * @cdid: CDID: portion of key\n * @flags: flag portion of key\n * @vl_msk: valid mask\n * @dc_msk: don't care mask\n@@ -4404,8 +4404,8 @@ ice_get_ptype_attrib_info(enum ice_ptype_attrib_type type,\n }\n \n /**\n- * ice_add_prof_attrib - add any ptg with attributes to profile\n- * @prof: pointer to the profile to which ptg entries will be added\n+ * ice_add_prof_attrib - add any PTG with attributes to profile\n+ * @prof: pointer to the profile to which PTG entries will be added\n * @ptg: PTG to be added\n * @ptype: PTYPE that needs to be looked up\n * @attr: array of attributes that will be considered\n@@ -4547,7 +4547,7 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],\n \t\t\t\tif (status == ICE_ERR_MAX_LIMIT)\n \t\t\t\t\tbreak;\n \t\t\t\tif (status) {\n-\t\t\t\t\t/* This is simple a ptype/ptg with no\n+\t\t\t\t\t/* This is simple a ptype/PTG with no\n \t\t\t\t\t * attribute\n \t\t\t\t\t */\n \t\t\t\t\tprof->ptg[prof->ptg_cnt] = ptg;\n@@ -5034,7 +5034,7 @@ ice_move_vsi(struct ice_hw *hw, enum ice_block blk, u16 vsi, u16 vsig,\n }\n \n /**\n- * ice_set_tcam_flags - set tcam flag don't care mask\n+ * ice_set_tcam_flags - set TCAM flag don't care mask\n * @mask: mask for flags\n * @dc_mask: pointer to the don't care mask\n */\n@@ -5048,9 +5048,9 @@ static void ice_set_tcam_flags(u16 mask, u8 dc_mask[ICE_TCAM_KEY_VAL_SZ])\n }\n \n /**\n- * ice_rem_chg_tcam_ent - remove a specific tcam entry from change list\n+ * ice_rem_chg_tcam_ent - remove a specific TCAM entry from change list\n * @hw: pointer to the HW struct\n- * @idx: the index of the tcam entry to remove\n+ * @idx: the index of the TCAM entry to remove\n * @chg: the list of change structures to search\n */\n static void\n@@ -5071,7 +5071,7 @@ ice_rem_chg_tcam_ent(struct ice_hw *hw, u16 idx, struct LIST_HEAD_TYPE *chg)\n * @hw: pointer to the HW struct\n * @blk: hardware block\n * @enable: true to enable, false to disable\n- * @vsig: the vsig of the TCAM entry\n+ * @vsig: the VSIG of the TCAM entry\n * @tcam: pointer the TCAM info structure of the TCAM to disable\n * @chg: the change list\n *\n@@ -5089,13 +5089,13 @@ ice_prof_tcam_ena_dis(struct ice_hw *hw, enum ice_block blk, bool enable,\n \tu8 dc_msk[ICE_TCAM_KEY_VAL_SZ] = { 0xFF, 0xFF, 0x00, 0x00, 0x00 };\n \tu8 nm_msk[ICE_TCAM_KEY_VAL_SZ] = { 0x00, 0x00, 0x00, 0x00, 0x00 };\n \n-\t/* if disabling, free the tcam */\n+\t/* if disabling, free the TCAM */\n \tif (!enable) {\n \t\tstatus = ice_rel_tcam_idx(hw, blk, tcam->tcam_idx);\n \n-\t\t/* if we have already created a change for this tcam entry, then\n+\t\t/* if we have already created a change for this TCAM entry, then\n \t\t * we need to remove that entry, in order to prevent writing to\n-\t\t * a tcam entry we no longer will have ownership of.\n+\t\t * a TCAM entry we no longer will have ownership of.\n \t\t */\n \t\tice_rem_chg_tcam_ent(hw, tcam->tcam_idx, chg);\n \t\ttcam->tcam_idx = 0;\n@@ -5103,7 +5103,7 @@ ice_prof_tcam_ena_dis(struct ice_hw *hw, enum ice_block blk, bool enable,\n \t\treturn status;\n \t}\n \n-\t/* for re-enabling, reallocate a tcam */\n+\t/* for re-enabling, reallocate a TCAM */\n \tstatus = ice_alloc_tcam_ent(hw, blk, &tcam->tcam_idx);\n \tif (status)\n \t\treturn status;\n@@ -5113,7 +5113,7 @@ ice_prof_tcam_ena_dis(struct ice_hw *hw, enum ice_block blk, bool enable,\n \tif (!p)\n \t\treturn ICE_ERR_NO_MEMORY;\n \n-\t/* set don't care masks for tcam flags */\n+\t/* set don't care masks for TCAM flags */\n \tice_set_tcam_flags(tcam->attr.mask, dc_msk);\n \n \tstatus = ice_tcam_write_entry(hw, blk, tcam->tcam_idx, tcam->prof_id,\n@@ -5324,7 +5324,7 @@ ice_add_prof_id_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsig, u64 hdl,\n \t\tp->vsig = vsig;\n \t\tp->tcam_idx = t->tcam[i].tcam_idx;\n \n-\t\t/* set don't care masks for tcam flags */\n+\t\t/* set don't care masks for TCAM flags */\n \t\tice_set_tcam_flags(t->tcam[i].attr.mask, dc_msk);\n \n \t\t/* write the TCAM entry */\n@@ -5412,7 +5412,7 @@ ice_create_prof_id_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl,\n * @blk: hardware block\n * @vsi: the initial VSI that will be in VSIG\n * @lst: the list of profile that will be added to the VSIG\n- * @new_vsig: return of new vsig\n+ * @new_vsig: return of new VSIG\n * @chg: the change list\n */\n static enum ice_status\n@@ -5553,7 +5553,7 @@ ice_add_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl)\n \t\tu16 or_vsig;\n \t\tu16 ref;\n \n-\t\t/* found in vsig */\n+\t\t/* found in VSIG */\n \t\tor_vsig = vsig;\n \n \t\t/* make sure that there is no overlap/conflict between the new\ndiff --git a/drivers/net/ice/base/ice_flex_type.h b/drivers/net/ice/base/ice_flex_type.h\nindex 1be98ea52..c122196e9 100644\n--- a/drivers/net/ice/base/ice_flex_type.h\n+++ b/drivers/net/ice/base/ice_flex_type.h\n@@ -642,8 +642,8 @@ struct ice_xlt1 {\n #define ICE_XLT2_CNT\t768\n #define ICE_MAX_VSIGS\t768\n \n-/* Vsig bit layout:\n- * [0:12]: incremental vsig index 1 to ICE_MAX_VSIGS\n+/* VSIG bit layout:\n+ * [0:12]: incremental VSIG index 1 to ICE_MAX_VSIGS\n * [13:15]: PF number of device\n */\n #define ICE_VSIG_IDX_M\t(0x1FFF)\n@@ -713,7 +713,7 @@ struct ice_prof_tcam {\n \tu16 count;\n \tu16 max_prof_id;\n \tstruct ice_prof_tcam_entry *t;\n-\tu8 cdid_bits; /* # cdid bits to use in key, 0, 2, 4, or 8 */\n+\tu8 cdid_bits; /* # CDID bits to use in key, 0, 2, 4, or 8 */\n };\n \n struct ice_prof_redir {\ndiff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex adcda9645..225842dc1 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -3180,7 +3180,6 @@ ice_add_mac_rule(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list,\n \t\tgoto ice_add_mac_exit;\n \t}\n \n-\n \t/* Allocate switch rule buffer for the bulk update for unicast */\n \ts_rule_size = ICE_SW_RULE_RX_TX_ETH_HDR_SIZE;\n \ts_rule = (struct ice_aqc_sw_rules_elem *)\n", "prefixes": [ "15/28" ] }