Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66418/?format=api
{ "id": 66418, "url": "http://patches.dpdk.org/api/patches/66418/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200309114357.31800-2-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200309114357.31800-2-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200309114357.31800-2-qi.z.zhang@intel.com", "date": "2020-03-09T11:43:30", "name": "[01/28] net/ice/base: fix uninitialized stack variables", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9758ffabc757fa106195e489cff1ea18a0dcefcd", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200309114357.31800-2-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 8843, "url": "http://patches.dpdk.org/api/series/8843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8843", "date": "2020-03-09T11:43:29", "name": "update ice base code", "version": 1, "mbox": "http://patches.dpdk.org/series/8843/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66418/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66418/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6C213A052E;\n\tMon, 9 Mar 2020 12:40:43 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 006E01C011;\n\tMon, 9 Mar 2020 12:40:35 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 133EE1BFFA;\n Mon, 9 Mar 2020 12:40:32 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 09 Mar 2020 04:40:32 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n by fmsmga002.fm.intel.com with ESMTP; 09 Mar 2020 04:40:30 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,533,1574150400\"; d=\"scan'208\";a=\"276483474\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com,\n\tbeilei.xing@intel.com", "Cc": "xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n stable@dpdk.org, Jesse Brandeburg <jesse.brandeburg@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 9 Mar 2020 19:43:30 +0800", "Message-Id": "<20200309114357.31800-2-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200309114357.31800-1-qi.z.zhang@intel.com>", "References": "<20200309114357.31800-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 01/28] net/ice/base: fix uninitialized stack\n\tvariables", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Via code inspection, I found that some partially initialized\nstack variables were being passed along to called functions,\nwhich could eventually result in those uninitialized members\nbeing used. To fix this, make sure the local variables are\nzeroed out before partially initializing them. This should\nprevent any unintended consequences from using stack memory that\nmight have junk in it.\n\nIn addition to the memsets, this patch also initializes one\nmember in one function, that needed to be initialized to non-zero.\n\nFixes: fed0c5ca5f19 (\"net/ice/base: support programming a new switch recipe\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_switch.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex 085f34406..e88d0f7fe 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -6227,9 +6227,12 @@ ice_adv_add_update_vsi_list(struct ice_hw *hw,\n \t\tif (status)\n \t\t\treturn status;\n \n+\t\tice_memset(&tmp_fltr, 0, sizeof(tmp_fltr), ICE_NONDMA_MEM);\n \t\ttmp_fltr.fltr_rule_id = cur_fltr->fltr_rule_id;\n \t\ttmp_fltr.fltr_act = ICE_FWD_TO_VSI_LIST;\n \t\ttmp_fltr.fwd_id.vsi_list_id = vsi_list_id;\n+\t\ttmp_fltr.lkup_type = ICE_SW_LKUP_LAST;\n+\n \t\t/* Update the previous switch rule of \"forward to VSI\" to\n \t\t * \"fwd to VSI list\"\n \t\t */\n@@ -6473,6 +6476,7 @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,\n \tif (rinfo->sw_act.fltr_act == ICE_FWD_TO_VSI) {\n \t\tstruct ice_fltr_info tmp_fltr;\n \n+\t\tice_memset(&tmp_fltr, 0, sizeof(tmp_fltr), ICE_NONDMA_MEM);\n \t\ttmp_fltr.fltr_rule_id =\n \t\t\tLE16_TO_CPU(s_rule->pdata.lkup_tx_rx.index);\n \t\ttmp_fltr.fltr_act = ICE_FWD_TO_VSI;\n@@ -6557,6 +6561,8 @@ ice_adv_rem_update_vsi_list(struct ice_hw *hw, u16 vsi_handle,\n \t\t\t\t\t\t lkup_type);\n \t\tif (status)\n \t\t\treturn status;\n+\n+\t\tice_memset(&tmp_fltr, 0, sizeof(tmp_fltr), ICE_NONDMA_MEM);\n \t\ttmp_fltr.fltr_rule_id = fm_list->rule_info.fltr_rule_id;\n \t\tfm_list->rule_info.sw_act.fltr_act = ICE_FWD_TO_VSI;\n \t\ttmp_fltr.fltr_act = ICE_FWD_TO_VSI;\n", "prefixes": [ "01/28" ] }