Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66335/?format=api
{ "id": 66335, "url": "http://patches.dpdk.org/api/patches/66335/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200306095742.18080-17-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200306095742.18080-17-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200306095742.18080-17-hemant.agrawal@nxp.com", "date": "2020-03-06T09:57:42", "name": "[v2,16/16] net/dpaa2: do not prefetch annotaion for physical mode", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "f8fc385828ead6870747e58e72dc434302d2e5af", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200306095742.18080-17-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 8810, "url": "http://patches.dpdk.org/api/series/8810/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8810", "date": "2020-03-06T09:57:26", "name": "NXP DPAAx fixes and enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/8810/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66335/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/66335/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4C021A056A;\n\tFri, 6 Mar 2020 11:02:27 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 101931C0D2;\n\tFri, 6 Mar 2020 11:00:12 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id CC8E41C045\n for <dev@dpdk.org>; Fri, 6 Mar 2020 10:59:57 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id B0373200217;\n Fri, 6 Mar 2020 10:59:57 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 572E8200AD8;\n Fri, 6 Mar 2020 10:59:55 +0100 (CET)", "from bf-netperf1.ap.com (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 846D5402D5;\n Fri, 6 Mar 2020 17:59:52 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tNipun Gupta <nipun.gupta@nxp.com>", "Date": "Fri, 6 Mar 2020 15:27:42 +0530", "Message-Id": "<20200306095742.18080-17-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200306095742.18080-1-hemant.agrawal@nxp.com>", "References": "<20200302145829.27808-1-hemant.agrawal@nxp.com>\n <20200306095742.18080-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 16/16] net/dpaa2: do not prefetch annotaion\n\tfor physical mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nWhen IOVA is physical address do not prefetch the annotation\nof the next frame, as there is a cost involved there to convert\nthe physical address to virtual address.\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 6 ++--\n drivers/net/dpaa2/dpaa2_rxtx.c | 40 +++++++++++++++----------\n 2 files changed, 28 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\nindex bde1441f4..6b07b628a 100644\n--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\n+++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n * Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.\n- * Copyright 2016-2019 NXP\n+ * Copyright 2016-2020 NXP\n *\n */\n \n@@ -403,8 +403,8 @@ static phys_addr_t dpaa2_mem_vtop(uint64_t vaddr)\n #else\t/* RTE_LIBRTE_DPAA2_USE_PHYS_IOVA */\n \n #define DPAA2_MBUF_VADDR_TO_IOVA(mbuf) ((mbuf)->buf_addr)\n-#define DPAA2_VADDR_TO_IOVA(_vaddr) (_vaddr)\n-#define DPAA2_IOVA_TO_VADDR(_iova) (_iova)\n+#define DPAA2_VADDR_TO_IOVA(_vaddr) (phys_addr_t)(_vaddr)\n+#define DPAA2_IOVA_TO_VADDR(_iova) (void *)(_iova)\n #define DPAA2_MODIFY_IOVA_TO_VADDR(_mem, _type)\n \n #endif /* RTE_LIBRTE_DPAA2_USE_PHYS_IOVA */\ndiff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c\nindex d809e0f4b..4d024a85f 100644\n--- a/drivers/net/dpaa2/dpaa2_rxtx.c\n+++ b/drivers/net/dpaa2/dpaa2_rxtx.c\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n * Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.\n- * Copyright 2016-2019 NXP\n+ * Copyright 2016-2020 NXP\n *\n */\n \n@@ -324,8 +324,8 @@ static inline struct rte_mbuf *__attribute__((hot))\n eth_fd_to_mbuf(const struct qbman_fd *fd,\n \t int port_id)\n {\n-\tstruct rte_mbuf *mbuf = DPAA2_INLINE_MBUF_FROM_BUF(\n-\t\tDPAA2_IOVA_TO_VADDR(DPAA2_GET_FD_ADDR(fd)),\n+\tvoid *iova_addr = DPAA2_IOVA_TO_VADDR(DPAA2_GET_FD_ADDR(fd));\n+\tstruct rte_mbuf *mbuf = DPAA2_INLINE_MBUF_FROM_BUF(iova_addr,\n \t\t rte_dpaa2_bpid_info[DPAA2_GET_FD_BPID(fd)].meta_data_size);\n \n \t/* need to repopulated some of the fields,\n@@ -350,8 +350,7 @@ eth_fd_to_mbuf(const struct qbman_fd *fd,\n \t\tdpaa2_dev_rx_parse_new(mbuf, fd);\n \telse\n \t\tmbuf->packet_type = dpaa2_dev_rx_parse(mbuf,\n-\t\t\t(void *)((size_t)DPAA2_IOVA_TO_VADDR(DPAA2_GET_FD_ADDR(fd))\n-\t\t\t + DPAA2_FD_PTA_SIZE));\n+\t\t\t(void *)((size_t)iova_addr + DPAA2_FD_PTA_SIZE));\n \n \tDPAA2_PMD_DP_DEBUG(\"to mbuf - mbuf =%p, mbuf->buf_addr =%p, off = %d,\"\n \t\t\"fd_off=%d fd =%\" PRIx64 \", meta = %d bpid =%d, len=%d\\n\",\n@@ -518,7 +517,7 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tint ret, num_rx = 0, pull_size;\n \tuint8_t pending, status;\n \tstruct qbman_swp *swp;\n-\tconst struct qbman_fd *fd, *next_fd;\n+\tconst struct qbman_fd *fd;\n \tstruct qbman_pull_desc pulldesc;\n \tstruct queue_storage_info_t *q_storage = dpaa2_q->q_storage;\n \tstruct rte_eth_dev_data *eth_data = dpaa2_q->eth_data;\n@@ -617,12 +616,15 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t}\n \t\tfd = qbman_result_DQ_fd(dq_storage);\n \n+#ifndef RTE_LIBRTE_DPAA2_USE_PHYS_IOVA\n \t\tif (dpaa2_svr_family != SVR_LX2160A) {\n-\t\t\tnext_fd = qbman_result_DQ_fd(dq_storage + 1);\n+\t\t\tconst struct qbman_fd *next_fd =\n+\t\t\t\tqbman_result_DQ_fd(dq_storage + 1);\n \t\t\t/* Prefetch Annotation address for the parse results */\n-\t\t\trte_prefetch0((void *)(size_t)(DPAA2_GET_FD_ADDR(\n-\t\t\t\t next_fd) + DPAA2_FD_PTA_SIZE + 16));\n+\t\t\trte_prefetch0(DPAA2_IOVA_TO_VADDR((DPAA2_GET_FD_ADDR(\n+\t\t\t\tnext_fd) + DPAA2_FD_PTA_SIZE + 16)));\n \t\t}\n+#endif\n \n \t\tif (unlikely(DPAA2_FD_GET_FORMAT(fd) == qbman_fd_sg))\n \t\t\tbufs[num_rx] = eth_sg_fd_to_mbuf(fd, eth_data->port_id);\n@@ -753,7 +755,7 @@ dpaa2_dev_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tint ret, num_rx = 0, next_pull = nb_pkts, num_pulled;\n \tuint8_t pending, status;\n \tstruct qbman_swp *swp;\n-\tconst struct qbman_fd *fd, *next_fd;\n+\tconst struct qbman_fd *fd;\n \tstruct qbman_pull_desc pulldesc;\n \tstruct rte_eth_dev_data *eth_data = dpaa2_q->eth_data;\n \n@@ -821,11 +823,19 @@ dpaa2_dev_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\t}\n \t\t\tfd = qbman_result_DQ_fd(dq_storage);\n \n-\t\t\tnext_fd = qbman_result_DQ_fd(dq_storage + 1);\n-\t\t\t/* Prefetch Annotation address for the parse results */\n-\t\t\trte_prefetch0(\n-\t\t\t\t(void *)(size_t)(DPAA2_GET_FD_ADDR(next_fd)\n-\t\t\t\t\t+ DPAA2_FD_PTA_SIZE + 16));\n+#ifndef RTE_LIBRTE_DPAA2_USE_PHYS_IOVA\n+\t\t\tif (dpaa2_svr_family != SVR_LX2160A) {\n+\t\t\t\tconst struct qbman_fd *next_fd =\n+\t\t\t\t\tqbman_result_DQ_fd(dq_storage + 1);\n+\n+\t\t\t\t/* Prefetch Annotation address for the parse\n+\t\t\t\t * results.\n+\t\t\t\t */\n+\t\t\t\trte_prefetch0((DPAA2_IOVA_TO_VADDR(\n+\t\t\t\t\tDPAA2_GET_FD_ADDR(next_fd) +\n+\t\t\t\t\tDPAA2_FD_PTA_SIZE + 16)));\n+\t\t\t}\n+#endif\n \n \t\t\tif (unlikely(DPAA2_FD_GET_FORMAT(fd) == qbman_fd_sg))\n \t\t\t\tbufs[num_rx] = eth_sg_fd_to_mbuf(fd,\n", "prefixes": [ "v2", "16/16" ] }