Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66296/?format=api
{ "id": 66296, "url": "http://patches.dpdk.org/api/patches/66296/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1583405273-14176-6-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1583405273-14176-6-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1583405273-14176-6-git-send-email-arybchenko@solarflare.com", "date": "2020-03-05T10:47:51", "name": "[5/7] net/sfc: generalise flow parsing", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a5b86863b529069b2efa8a42411a056b7c18dc6b", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1583405273-14176-6-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 8796, "url": "http://patches.dpdk.org/api/series/8796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8796", "date": "2020-03-05T10:47:46", "name": "net/sfc: prepare rte_flow to have one more backend", "version": 1, "mbox": "http://patches.dpdk.org/series/8796/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66296/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66296/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2791DA0573;\n\tThu, 5 Mar 2020 11:48:59 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8F9971C029;\n\tThu, 5 Mar 2020 11:48:14 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id D20FC1BFEB\n for <dev@dpdk.org>; Thu, 5 Mar 2020 11:48:08 +0100 (CET)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 6E4E3800069\n for <dev@dpdk.org>; Thu, 5 Mar 2020 10:48:07 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1395.4; Thu, 5 Mar 2020 10:48:01 +0000", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1395.4 via Frontend Transport; Thu, 5 Mar 2020 10:48:01 +0000", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 025Am1Ja016225;\n Thu, 5 Mar 2020 10:48:01 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 574931611DB;\n Thu, 5 Mar 2020 10:48:01 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Thu, 5 Mar 2020 10:47:51 +0000", "Message-ID": "<1583405273-14176-6-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1583405273-14176-1-git-send-email-arybchenko@solarflare.com>", "References": "<1583405273-14176-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1020-25270.003", "X-TM-AS-Result": "No-0.031800-8.000000-10", "X-TMASE-MatchedRID": "fkBqx08G71JhNdhmbyNY5R5dqSUtZTxbNV9S7O+u3Ka4M3bcbfcMpsiT\n Wug2C4DNNNN0dk/lb45w5T4Iaj538mJZXQNDzktS+CjwEqX1p7lKgIbix5+XxHQWhLVqLFM10/6\n Rc2rmS5nh7Fy6XIdlM1SCmfT2v3te3qZ3A4FG8d1lpwNsTvdlKfL75LLJV7i3E4klva9z5JxbhN\n +qQevtG4a1iltxHuFzigMIcFldjOsdAyevMk7vZ+uhtmmz4+rYAzwceAn9JLOen0qBdy7fjPpcD\n ADsgrla4vM1YF6AJbbCCfuIMF6xLVgXepbcl7r7shj6AiUDVLiegZY9YJrgPbqNWHHNep0LZlfl\n h3vhuk+DhWPg8szu7jr0+R05AcJcWChHz4SXTGRr++b0EvDd62U5c9zTFd2lvU24pLfQFmdAgUh\n ku2yAbQNQf6dUs3KIKyog/1PG+0mjWzyQbry2i37cGd19dSFd", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-0.031800-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1020-25270.003", "X-MDID": "1583405288-Fawkr6rE3gua", "Subject": "[dpdk-dev] [PATCH 5/7] net/sfc: generalise flow parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nGeneralise flow attribute parsing function in regard to transfer attribute.\nAdd a method table and factor out VNIC-specific parsing code as a callback.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_flow.c | 101 +++++++++++++++++++++++++++----------\n drivers/net/sfc/sfc_flow.h | 6 +++\n 2 files changed, 81 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex 2ddde6168..ed91c3cef 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -24,6 +24,34 @@\n #include \"sfc_log.h\"\n #include \"sfc_dp_rx.h\"\n \n+struct sfc_flow_ops_by_spec {\n+\tsfc_flow_parse_cb_t\t*parse;\n+};\n+\n+static sfc_flow_parse_cb_t sfc_flow_parse_rte_to_filter;\n+\n+static const struct sfc_flow_ops_by_spec sfc_flow_ops_filter = {\n+\t.parse = sfc_flow_parse_rte_to_filter,\n+};\n+\n+static const struct sfc_flow_ops_by_spec *\n+sfc_flow_get_ops_by_spec(struct rte_flow *flow)\n+{\n+\tstruct sfc_flow_spec *spec = &flow->spec;\n+\tconst struct sfc_flow_ops_by_spec *ops = NULL;\n+\n+\tswitch (spec->type) {\n+\tcase SFC_FLOW_SPEC_FILTER:\n+\t\tops = &sfc_flow_ops_filter;\n+\t\tbreak;\n+\tdefault:\n+\t\tSFC_ASSERT(false);\n+\t\tbreak;\n+\t}\n+\n+\treturn ops;\n+}\n+\n /*\n * Currently, filter-based (VNIC) flow API is implemented in such a manner\n * that each flow rule is converted to one or more hardware filters.\n@@ -1108,35 +1136,35 @@ sfc_flow_parse_attr(const struct rte_flow_attr *attr,\n \t\t\t\t \"Groups are not supported\");\n \t\treturn -rte_errno;\n \t}\n-\tif (attr->priority != 0) {\n-\t\trte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY, attr,\n-\t\t\t\t \"Priorities are not supported\");\n-\t\treturn -rte_errno;\n-\t}\n \tif (attr->egress != 0) {\n \t\trte_flow_error_set(error, ENOTSUP,\n \t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, attr,\n \t\t\t\t \"Egress is not supported\");\n \t\treturn -rte_errno;\n \t}\n-\tif (attr->transfer != 0) {\n+\tif (attr->ingress == 0) {\n \t\trte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER, attr,\n-\t\t\t\t \"Transfer is not supported\");\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, attr,\n+\t\t\t\t \"Ingress is compulsory\");\n \t\treturn -rte_errno;\n \t}\n-\tif (attr->ingress == 0) {\n+\tif (attr->transfer == 0) {\n+\t\tif (attr->priority != 0) {\n+\t\t\trte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,\n+\t\t\t\t\t attr, \"Priorities are unsupported\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t\tspec->type = SFC_FLOW_SPEC_FILTER;\n+\t\tspec_filter->template.efs_flags |= EFX_FILTER_FLAG_RX;\n+\t\tspec_filter->template.efs_rss_context = EFX_RSS_CONTEXT_DEFAULT;\n+\t} else {\n \t\trte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, attr,\n-\t\t\t\t \"Only ingress is supported\");\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER, attr,\n+\t\t\t\t \"Transfer is not supported\");\n \t\treturn -rte_errno;\n \t}\n \n-\tspec->type = SFC_FLOW_SPEC_FILTER;\n-\tspec_filter->template.efs_flags |= EFX_FILTER_FLAG_RX;\n-\tspec_filter->template.efs_rss_context = EFX_RSS_CONTEXT_DEFAULT;\n-\n \treturn 0;\n }\n \n@@ -2277,20 +2305,15 @@ sfc_flow_validate_match_flags(struct sfc_adapter *sa,\n }\n \n static int\n-sfc_flow_parse(struct rte_eth_dev *dev,\n-\t const struct rte_flow_attr *attr,\n-\t const struct rte_flow_item pattern[],\n-\t const struct rte_flow_action actions[],\n-\t struct rte_flow *flow,\n-\t struct rte_flow_error *error)\n+sfc_flow_parse_rte_to_filter(struct rte_eth_dev *dev,\n+\t\t\t const struct rte_flow_item pattern[],\n+\t\t\t const struct rte_flow_action actions[],\n+\t\t\t struct rte_flow *flow,\n+\t\t\t struct rte_flow_error *error)\n {\n \tstruct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);\n \tint rc;\n \n-\trc = sfc_flow_parse_attr(attr, flow, error);\n-\tif (rc != 0)\n-\t\tgoto fail_bad_value;\n-\n \trc = sfc_flow_parse_pattern(pattern, flow, error);\n \tif (rc != 0)\n \t\tgoto fail_bad_value;\n@@ -2309,6 +2332,32 @@ sfc_flow_parse(struct rte_eth_dev *dev,\n \treturn rc;\n }\n \n+static int\n+sfc_flow_parse(struct rte_eth_dev *dev,\n+\t const struct rte_flow_attr *attr,\n+\t const struct rte_flow_item pattern[],\n+\t const struct rte_flow_action actions[],\n+\t struct rte_flow *flow,\n+\t struct rte_flow_error *error)\n+{\n+\tconst struct sfc_flow_ops_by_spec *ops;\n+\tint rc;\n+\n+\trc = sfc_flow_parse_attr(attr, flow, error);\n+\tif (rc != 0)\n+\t\treturn rc;\n+\n+\tops = sfc_flow_get_ops_by_spec(flow);\n+\tif (ops == NULL || ops->parse == NULL) {\n+\t\trte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n+\t\t\t\t \"No backend to handle this flow\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\treturn ops->parse(dev, pattern, actions, flow, error);\n+}\n+\n static struct rte_flow *\n sfc_flow_zmalloc(struct rte_flow_error *error)\n {\ndiff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h\nindex 70f0cdf12..19db8fce5 100644\n--- a/drivers/net/sfc/sfc_flow.h\n+++ b/drivers/net/sfc/sfc_flow.h\n@@ -85,6 +85,12 @@ void sfc_flow_fini(struct sfc_adapter *sa);\n int sfc_flow_start(struct sfc_adapter *sa);\n void sfc_flow_stop(struct sfc_adapter *sa);\n \n+typedef int (sfc_flow_parse_cb_t)(struct rte_eth_dev *dev,\n+\t\t\t\t const struct rte_flow_item items[],\n+\t\t\t\t const struct rte_flow_action actions[],\n+\t\t\t\t struct rte_flow *flow,\n+\t\t\t\t struct rte_flow_error *error);\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "5/7" ] }