Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 66224,
    "url": "http://patches.dpdk.org/api/patches/66224/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200303175938.14292-7-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200303175938.14292-7-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200303175938.14292-7-stephen@networkplumber.org",
    "date": "2020-03-03T17:59:38",
    "name": "[6/6] net/bnxt: sanitize max_l2_ctx",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "a8e79de9a90eed33d39416c6d095a54ff265ec75",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1766,
        "url": "http://patches.dpdk.org/api/users/1766/?format=api",
        "username": "ajitkhaparde",
        "first_name": "Ajit",
        "last_name": "Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200303175938.14292-7-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 8766,
            "url": "http://patches.dpdk.org/api/series/8766/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8766",
            "date": "2020-03-03T17:59:32",
            "name": "net/bnxt: bounds checking patches",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8766/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/66224/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/66224/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7136BA0571;\n\tTue,  3 Mar 2020 19:00:43 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 170C61C07D;\n\tTue,  3 Mar 2020 18:59:53 +0100 (CET)",
            "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 56C1E1C044\n for <dev@dpdk.org>; Tue,  3 Mar 2020 18:59:50 +0100 (CET)",
            "by mail-pf1-f195.google.com with SMTP id j9so1840840pfa.8\n for <dev@dpdk.org>; Tue, 03 Mar 2020 09:59:50 -0800 (PST)",
            "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id w195sm22012158pfd.65.2020.03.03.09.59.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 03 Mar 2020 09:59:48 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=BR2FGVaXEaIy8R2p8pSAKFFtFJubdo86cCSrcBUH+ls=;\n b=JhW9NHMP/o7FD7qrGBBR634YSx/hQwYwn7PX6OsqTYdBvhN7/sJVc0X9JXEXRv6xxM\n 0haVzn9YKEhr6FSwI6n+xX8GHuZ4rxLcW3TYe/VVDsoKUhIykoMuMdvZed77zQu/v16M\n /6B8/pyuSgt8sZ9oUOVjFYPltT56ge9JgisA4d/cN9Lv4Osnan2FroGu6BYx0SPrdisB\n uinbO2woCofQKgN0hayC6NZwPANbpAM6PrDaaot1pom7Rvj+X85ZNcsUWVpDR9widgcm\n llPaG+H7KxVQNbEFHQSkB7VG+TuOgcP547VoOH7oecXSVnBEmomTX4FjnZM/vAP5XaJI\n ZYnw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=BR2FGVaXEaIy8R2p8pSAKFFtFJubdo86cCSrcBUH+ls=;\n b=jd3zhsktlaypkZAnmNyrX0W3YshVxzMMFs4PIitpNKVa4Cgy0m7U1pRO9yIUFwPpIc\n C8t/SfF/NNfxdgbcnFyTK4X12NAgWIXqmrX9s2VaNqsDAQ8hwaBxftUpQdCNxURjLsJx\n zulku0Qw1l9yYNbeD635SqFrRmliFE6CcJ4DXGl4NtA9Z/3iRY2RN80MYF1V/Zd50Qil\n ip/KcTmc5zFlJqNBx+UxRyZOG3ZcrWPgk0Hs478zcFyNPHVPOpd2l1dELwgRmu+oWvHc\n oxINozWhIQkHbHyn2HdqKmgB1nZR17178FSy8jgoPYh1YKhqgKPUjGmu1l8039p+FYz3\n RoBA==",
        "X-Gm-Message-State": "ANhLgQ1kkvyRaz+b5lbWGIeq8LOeGfRjCkx5bjy/ZNn+Uivfpemi3Bd9\n rg6whCNYyMGnQ9bztreE7tJ2yw==",
        "X-Google-Smtp-Source": "\n ADFU+vuZpRyjQSXmLzoIdQxfQW4tQmsl29OmRYYj+Hph1tL6crSFYemfjeS3y+6pd4AQZdchD/jZtQ==",
        "X-Received": "by 2002:a62:5bc7:: with SMTP id p190mr5257975pfb.16.1583258389548;\n Tue, 03 Mar 2020 09:59:49 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "ajit.khaparde@broadcom.com,\n\tsomnath.kotur@broadcom.com",
        "Cc": "dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,\n Christopher Ertl <Christopher.Ertl@microsoft.com>",
        "Date": "Tue,  3 Mar 2020 09:59:38 -0800",
        "Message-Id": "<20200303175938.14292-7-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20200303175938.14292-1-stephen@networkplumber.org>",
        "References": "<20200303175938.14292-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 6/6] net/bnxt: sanitize max_l2_ctx",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "If max_l2_ctx is very large, then adding the additional value\ncould cause wraparound.\n\nReported-by: Christopher Ertl <Christopher.Ertl@microsoft.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex d878320aa110..099e04fa550a 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -651,8 +651,15 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp)\n \tbp->first_vf_id = rte_le_to_cpu_16(resp->first_vf_id);\n \tbp->max_rx_em_flows = rte_le_to_cpu_16(resp->max_rx_em_flows);\n \tbp->max_l2_ctx = rte_le_to_cpu_16(resp->max_l2_ctxs);\n-\tif (!BNXT_CHIP_THOR(bp))\n-\t\tbp->max_l2_ctx += bp->max_rx_em_flows;\n+\tif (!BNXT_CHIP_THOR(bp)) {\n+\t\tuint16_t max_l2_ctx;\n+\n+\t\tif (rte_add_overflow(bp->max_l2_ctx, bp->max_rx_em_flows,\n+\t\t\t\t     &max_l2_ctx))\n+\t\t\treturn -EINVAL;\n+\t\tbp->max_l2_ctx = max_l2_ctx;\n+\t}\n+\n \t/* TODO: For now, do not support VMDq/RFS on VFs. */\n \tif (BNXT_PF(bp)) {\n \t\tif (bp->pf.max_vfs)\n",
    "prefixes": [
        "6/6"
    ]
}