Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66169/?format=api
{ "id": 66169, "url": "http://patches.dpdk.org/api/patches/66169/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200302143209.11854-9-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200302143209.11854-9-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200302143209.11854-9-hemant.agrawal@nxp.com", "date": "2020-03-02T14:32:07", "name": "[08/10] net/enetc: use bulk free in Tx clean", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "85565999bf1b112bcc30a5b550a5e02039e659e0", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200302143209.11854-9-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 8741, "url": "http://patches.dpdk.org/api/series/8741/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8741", "date": "2020-03-02T14:31:59", "name": "net/enetc: optimization and cleanup", "version": 1, "mbox": "http://patches.dpdk.org/series/8741/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66169/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66169/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 17A7EA0568;\n\tMon, 2 Mar 2020 10:01:46 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 71FA01C0B0;\n\tMon, 2 Mar 2020 10:00:27 +0100 (CET)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by dpdk.org (Postfix) with ESMTP id C21F01C038\n for <dev@dpdk.org>; Mon, 2 Mar 2020 10:00:20 +0100 (CET)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id A7FBB1A0FDF;\n Mon, 2 Mar 2020 10:00:20 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 291391A0FA6;\n Mon, 2 Mar 2020 10:00:18 +0100 (CET)", "from bf-netperf1.ap.com (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id DAE5C402ED;\n Mon, 2 Mar 2020 17:00:14 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, g.singh@nxp.com,\n Alex Marginean <alexandru.marginean@nxp.com>", "Date": "Mon, 2 Mar 2020 20:02:07 +0530", "Message-Id": "<20200302143209.11854-9-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200302143209.11854-1-hemant.agrawal@nxp.com>", "References": "<20200302143209.11854-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 08/10] net/enetc: use bulk free in Tx clean", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Alex Marginean <alexandru.marginean@nxp.com>\n\nUse rte_pktmbuf_free_bulk to release all mbufs at once. This is flagged\nas obsolete/not yet stable in DPDK but seems to be functional.\nDon't count the released frames, it's no longer needed in the caller.\n\nSigned-off-by: Alex Marginean <alexandru.marginean@nxp.com>\n---\n drivers/net/enetc/Makefile | 1 +\n drivers/net/enetc/enetc_rxtx.c | 32 ++++++++++++++++++++++++--------\n drivers/net/enetc/meson.build | 1 +\n 3 files changed, 26 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/enetc/Makefile b/drivers/net/enetc/Makefile\nindex 7276026e3..7f7a85f64 100644\n--- a/drivers/net/enetc/Makefile\n+++ b/drivers/net/enetc/Makefile\n@@ -11,6 +11,7 @@ LIB = librte_pmd_enetc.a\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n CFLAGS += -I$(RTE_SDK)/drivers/common/dpaax\n+CFLAGS += -DALLOW_EXPERIMENTAL_API\n EXPORT_MAP := rte_pmd_enetc_version.map\n SRCS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc_ethdev.c\n SRCS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc_rxtx.c\ndiff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c\nindex 8b85c5371..1acc43a08 100644\n--- a/drivers/net/enetc/enetc_rxtx.c\n+++ b/drivers/net/enetc/enetc_rxtx.c\n@@ -20,8 +20,9 @@ static int\n enetc_clean_tx_ring(struct enetc_bdr *tx_ring)\n {\n \tint tx_frm_cnt = 0;\n-\tstruct enetc_swbd *tx_swbd;\n-\tint i, hwci;\n+\tstruct enetc_swbd *tx_swbd, *tx_swbd_base;\n+\tint i, hwci, bd_count;\n+\tstruct rte_mbuf *m[ENETC_RXBD_BUNDLE];\n \n \t/* we don't need barriers here, we just want a relatively current value\n \t * from HW.\n@@ -29,8 +30,10 @@ enetc_clean_tx_ring(struct enetc_bdr *tx_ring)\n \thwci = (int)(rte_read32_relaxed(tx_ring->tcisr) &\n \t\t ENETC_TBCISR_IDX_MASK);\n \n+\ttx_swbd_base = tx_ring->q_swbd;\n+\tbd_count = tx_ring->bd_count;\n \ti = tx_ring->next_to_clean;\n-\ttx_swbd = &tx_ring->q_swbd[i];\n+\ttx_swbd = &tx_swbd_base[i];\n \n \t/* we're only reading the CI index once here, which means HW may update\n \t * it while we're doing clean-up. We could read the register in a loop\n@@ -42,20 +45,33 @@ enetc_clean_tx_ring(struct enetc_bdr *tx_ring)\n \t * meantime.\n \t */\n \twhile (i != hwci) {\n-\t\trte_pktmbuf_free(tx_swbd->buffer_addr);\n+\t\t/* It seems calling rte_pktmbuf_free is wasting a lot of cycles,\n+\t\t * make a list and call _free when it's done.\n+\t\t */\n+\t\tif (tx_frm_cnt == ENETC_RXBD_BUNDLE) {\n+\t\t\trte_pktmbuf_free_bulk(m, tx_frm_cnt);\n+\t\t\ttx_frm_cnt = 0;\n+\t\t}\n+\n+\t\tm[tx_frm_cnt] = tx_swbd->buffer_addr;\n \t\ttx_swbd->buffer_addr = NULL;\n-\t\ttx_swbd++;\n+\n \t\ti++;\n-\t\tif (unlikely(i == tx_ring->bd_count)) {\n+\t\ttx_swbd++;\n+\t\tif (unlikely(i == bd_count)) {\n \t\t\ti = 0;\n-\t\t\ttx_swbd = &tx_ring->q_swbd[0];\n+\t\t\ttx_swbd = tx_swbd_base;\n \t\t}\n \n \t\ttx_frm_cnt++;\n \t}\n \n+\tif (tx_frm_cnt)\n+\t\trte_pktmbuf_free_bulk(m, tx_frm_cnt);\n+\n \ttx_ring->next_to_clean = i;\n-\treturn tx_frm_cnt++;\n+\n+\treturn 0;\n }\n \n uint16_t\ndiff --git a/drivers/net/enetc/meson.build b/drivers/net/enetc/meson.build\nindex bea54bea8..af11c0960 100644\n--- a/drivers/net/enetc/meson.build\n+++ b/drivers/net/enetc/meson.build\n@@ -11,3 +11,4 @@ sources = files('enetc_ethdev.c',\n \t\t'enetc_rxtx.c')\n \n includes += include_directories('base')\n+allow_experimental_apis = true\n", "prefixes": [ "08/10" ] }