Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 66168,
    "url": "http://patches.dpdk.org/api/patches/66168/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200302143209.11854-8-hemant.agrawal@nxp.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200302143209.11854-8-hemant.agrawal@nxp.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200302143209.11854-8-hemant.agrawal@nxp.com",
    "date": "2020-03-02T14:32:06",
    "name": "[07/10] net/enetc: use bulk alloc in Rx refill ring",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "48cc9ce0ca3b7d9d9d21f17b5820934f683cfdec",
    "submitter": {
        "id": 477,
        "url": "http://patches.dpdk.org/api/people/477/?format=api",
        "name": "Hemant Agrawal",
        "email": "hemant.agrawal@nxp.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200302143209.11854-8-hemant.agrawal@nxp.com/mbox/",
    "series": [
        {
            "id": 8741,
            "url": "http://patches.dpdk.org/api/series/8741/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8741",
            "date": "2020-03-02T14:31:59",
            "name": "net/enetc: optimization and cleanup",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8741/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/66168/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/66168/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 31000A0568;\n\tMon,  2 Mar 2020 10:01:34 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2AF5E1C08E;\n\tMon,  2 Mar 2020 10:00:26 +0100 (CET)",
            "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by dpdk.org (Postfix) with ESMTP id E07A81C02C\n for <dev@dpdk.org>; Mon,  2 Mar 2020 10:00:19 +0100 (CET)",
            "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id C52841A0FC8;\n Mon,  2 Mar 2020 10:00:19 +0100 (CET)",
            "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 437091A0FB4;\n Mon,  2 Mar 2020 10:00:17 +0100 (CET)",
            "from bf-netperf1.ap.com (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 0C67F402D5;\n Mon,  2 Mar 2020 17:00:13 +0800 (SGT)"
        ],
        "From": "Hemant Agrawal <hemant.agrawal@nxp.com>",
        "To": "ferruh.yigit@intel.com",
        "Cc": "dev@dpdk.org, g.singh@nxp.com,\n Alex Marginean <alexandru.marginean@nxp.com>",
        "Date": "Mon,  2 Mar 2020 20:02:06 +0530",
        "Message-Id": "<20200302143209.11854-8-hemant.agrawal@nxp.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200302143209.11854-1-hemant.agrawal@nxp.com>",
        "References": "<20200302143209.11854-1-hemant.agrawal@nxp.com>",
        "X-Virus-Scanned": "ClamAV using ClamSMTP",
        "Subject": "[dpdk-dev] [PATCH 07/10] net/enetc: use bulk alloc in Rx refill ring",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Alex Marginean <alexandru.marginean@nxp.com>\n\nSince we know in advance that we're going to fill in multiple descriptors\nit's convenient to allocate the buffers in batches.\n\nSigned-off-by: Alex Marginean <alexandru.marginean@nxp.com>\n---\n drivers/net/enetc/enetc_rxtx.c | 21 +++++++++++++++++----\n 1 file changed, 17 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c\nindex 262ed8a0f..8b85c5371 100644\n--- a/drivers/net/enetc/enetc_rxtx.c\n+++ b/drivers/net/enetc/enetc_rxtx.c\n@@ -14,6 +14,8 @@\n #include \"enetc.h\"\n #include \"enetc_logs.h\"\n \n+#define ENETC_RXBD_BUNDLE 16 /* Number of buffers to allocate at once */\n+\n static int\n enetc_clean_tx_ring(struct enetc_bdr *tx_ring)\n {\n@@ -107,15 +109,25 @@ enetc_refill_rx_ring(struct enetc_bdr *rx_ring, const int buff_cnt)\n {\n \tstruct enetc_swbd *rx_swbd;\n \tunion enetc_rx_bd *rxbd;\n-\tint i, j;\n+\tint i, j, k = ENETC_RXBD_BUNDLE;\n+\tstruct rte_mbuf *m[ENETC_RXBD_BUNDLE];\n+\tstruct rte_mempool *mb_pool;\n \n \ti = rx_ring->next_to_use;\n+\tmb_pool = rx_ring->mb_pool;\n \trx_swbd = &rx_ring->q_swbd[i];\n \trxbd = ENETC_RXBD(*rx_ring, i);\n \tfor (j = 0; j < buff_cnt; j++) {\n-\t\trx_swbd->buffer_addr = (void *)(uintptr_t)\n-\t\t\trte_cpu_to_le_64((uint64_t)(uintptr_t)\n-\t\t\t\t\trte_pktmbuf_alloc(rx_ring->mb_pool));\n+\t\t/* bulk alloc for the next up to 8 BDs */\n+\t\tif (k == ENETC_RXBD_BUNDLE) {\n+\t\t\tk = 0;\n+\t\t\tint m_cnt = RTE_MIN(buff_cnt - j, ENETC_RXBD_BUNDLE);\n+\n+\t\t\tif (rte_pktmbuf_alloc_bulk(mb_pool, m, m_cnt))\n+\t\t\t\treturn -1;\n+\t\t}\n+\n+\t\trx_swbd->buffer_addr = m[k];\n \t\trxbd->w.addr = (uint64_t)(uintptr_t)\n \t\t\t       rx_swbd->buffer_addr->buf_iova +\n \t\t\t       rx_swbd->buffer_addr->data_off;\n@@ -124,6 +136,7 @@ enetc_refill_rx_ring(struct enetc_bdr *rx_ring, const int buff_cnt)\n \t\trx_swbd++;\n \t\trxbd++;\n \t\ti++;\n+\t\tk++;\n \t\tif (unlikely(i == rx_ring->bd_count)) {\n \t\t\ti = 0;\n \t\t\trxbd = ENETC_RXBD(*rx_ring, 0);\n",
    "prefixes": [
        "07/10"
    ]
}