Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66166/?format=api
{ "id": 66166, "url": "http://patches.dpdk.org/api/patches/66166/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200302143209.11854-6-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200302143209.11854-6-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200302143209.11854-6-hemant.agrawal@nxp.com", "date": "2020-03-02T14:32:04", "name": "[05/10] net/enetc: improve batching Rx ring refill", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "337aa8772e85b5f638021b95993e0f52b8e6c702", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200302143209.11854-6-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 8741, "url": "http://patches.dpdk.org/api/series/8741/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8741", "date": "2020-03-02T14:31:59", "name": "net/enetc: optimization and cleanup", "version": 1, "mbox": "http://patches.dpdk.org/series/8741/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66166/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66166/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9300DA0568;\n\tMon, 2 Mar 2020 10:01:12 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9DB211C07B;\n\tMon, 2 Mar 2020 10:00:23 +0100 (CET)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by dpdk.org (Postfix) with ESMTP id 35E921C01B\n for <dev@dpdk.org>; Mon, 2 Mar 2020 10:00:18 +0100 (CET)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 172321A0FC1;\n Mon, 2 Mar 2020 10:00:18 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 8BC9A1A0FA6;\n Mon, 2 Mar 2020 10:00:15 +0100 (CET)", "from bf-netperf1.ap.com (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 4B64840324;\n Mon, 2 Mar 2020 17:00:12 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, g.singh@nxp.com,\n Alex Marginean <alexandru.marginean@nxp.com>", "Date": "Mon, 2 Mar 2020 20:02:04 +0530", "Message-Id": "<20200302143209.11854-6-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200302143209.11854-1-hemant.agrawal@nxp.com>", "References": "<20200302143209.11854-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 05/10] net/enetc: improve batching Rx ring refill", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Alex Marginean <alexandru.marginean@nxp.com>\n\nMove from doing batch refill of Rx ring from bundles of 8 to once per\nenetc_clean_rx_ring call. One benefit is that we're cleaning up all the\nBDs that we just processed, which should still be cached. The other is\nthat hardware Rx index stays a little back and doesn't cause contention on\nthe BDs processed in the Rx loop.\n\nSigned-off-by: Alex Marginean <alexandru.marginean@nxp.com>\n---\n drivers/net/enetc/enetc_rxtx.c | 10 ++--------\n 1 file changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c\nindex 958e3a21d..262ed8a0f 100644\n--- a/drivers/net/enetc/enetc_rxtx.c\n+++ b/drivers/net/enetc/enetc_rxtx.c\n@@ -14,8 +14,6 @@\n #include \"enetc.h\"\n #include \"enetc_logs.h\"\n \n-#define ENETC_RXBD_BUNDLE 8 /* Number of BDs to update at once */\n-\n static int\n enetc_clean_tx_ring(struct enetc_bdr *tx_ring)\n {\n@@ -305,12 +303,6 @@ enetc_clean_rx_ring(struct enetc_bdr *rx_ring,\n \t\tunion enetc_rx_bd *rxbd;\n \t\tuint32_t bd_status;\n \n-\t\tif (cleaned_cnt >= ENETC_RXBD_BUNDLE) {\n-\t\t\tint count = enetc_refill_rx_ring(rx_ring, cleaned_cnt);\n-\n-\t\t\tcleaned_cnt -= count;\n-\t\t}\n-\n \t\trxbd = ENETC_RXBD(*rx_ring, i);\n \t\tbd_status = rte_le_to_cpu_32(rxbd->r.lstatus);\n \t\tif (!bd_status)\n@@ -337,6 +329,8 @@ enetc_clean_rx_ring(struct enetc_bdr *rx_ring,\n \t\trx_frm_cnt++;\n \t}\n \n+\tenetc_refill_rx_ring(rx_ring, cleaned_cnt);\n+\n \treturn rx_frm_cnt;\n }\n \n", "prefixes": [ "05/10" ] }