Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66091/?format=api
{ "id": 66091, "url": "http://patches.dpdk.org/api/patches/66091/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200227141840.15835-3-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200227141840.15835-3-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200227141840.15835-3-i.dyukov@samsung.com", "date": "2020-02-27T14:16:14", "name": "[v5,2/4] net/virtio: add link speed devarg", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a09cc8ec124c4bf0aa1f564513c760b385b2ecbf", "submitter": { "id": 783, "url": "http://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200227141840.15835-3-i.dyukov@samsung.com/mbox/", "series": [ { "id": 8709, "url": "http://patches.dpdk.org/api/series/8709/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8709", "date": "2020-02-27T14:16:12", "name": "net/virtio: add link speed devarg", "version": 5, "mbox": "http://patches.dpdk.org/series/8709/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66091/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66091/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3E4C9A055F;\n\tThu, 27 Feb 2020 15:20:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CABEB1BFD3;\n\tThu, 27 Feb 2020 15:20:25 +0100 (CET)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id CA1511F1C\n for <dev@dpdk.org>; Thu, 27 Feb 2020 15:20:24 +0100 (CET)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200227142024euoutp027f5fc369b23e9cae9dce25bd5855e117~3SD3eyDKP2266022660euoutp029\n for <dev@dpdk.org>; Thu, 27 Feb 2020 14:20:24 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200227142023eucas1p2c98d78dbf2e87c7495df6307f87f0727~3SD2M3LDd1431114311eucas1p2c;\n Thu, 27 Feb 2020 14:20:23 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id A5.84.60679.720D75E5; Thu, 27\n Feb 2020 14:20:23 +0000 (GMT)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200227142022eucas1p2b3cebb5af8470f715bffe20367226bff~3SD10ZXJ11637716377eucas1p2O;\n Thu, 27 Feb 2020 14:20:22 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200227142022eusmtrp2e00f48706405ae8fc10fb2b55061a8d7~3SD1zv4hp2816928169eusmtrp2E;\n Thu, 27 Feb 2020 14:20:22 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id DB.89.08375.620D75E5; Thu, 27\n Feb 2020 14:20:22 +0000 (GMT)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n 20200227142022eusmtip2c1ca722837d314c0f46faffa07d3f7f8~3SD1UAzjA1312413124eusmtip2C;\n Thu, 27 Feb 2020 14:20:22 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200227142024euoutp027f5fc369b23e9cae9dce25bd5855e117~3SD3eyDKP2266022660euoutp029", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1582813224;\n bh=0prRFzPe9J8TuMkjIkIaK1G//w3sfm9lk3YvbCSucPY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ph9eB+de5rPc3TlfCjIgyjYNJCdvHMjk/aOEpwnx2hn1N0bhAA4SxHrcSpJZ5+VkJ\n IcdsplbDX6b3OXgRiy18WXpDqfbVHnK+HcX8QdRizhRoHAE/9AgM11yw2Cj4WAr5Dh\n xCNvrxunTH+iqQ3mqvzEQUHsR2TwDPmbkTMDkqOg=", "X-AuditID": "cbfec7f4-0cbff7000001ed07-5e-5e57d027c853", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,\n amorenoz@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com", "Cc": "Ivan Dyukov <i.dyukov@samsung.com>", "Date": "Thu, 27 Feb 2020 17:16:14 +0300", "Message-Id": "<20200227141840.15835-3-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200227141840.15835-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsWy7djPc7rqF8LjDJ6d4bZo3fGAxeLdp+1M\n FrMuNbFbHOvcw2KxteE/k8WfN6YWmy9OYnJg9/i1YCmrx+I9L5k83u+7yubRt2UVYwBLFJdN\n SmpOZllqkb5dAlfGkkkL2Qr2mlT8XvuTsYHxslYXIweHhICJxP/H6V2MXBxCAisYJbrW9zBB\n OF8YJaZ872eDcD4zSuxeso61i5ETrGPBjnlQieWMEkueTIVyvjJKPPqzhgmkik1AQ+J0xzyw\n WSIC7YwSq6a0sIAkmAXUJD70vAezhQUsJSbNOAtmswioSmy+uZwdxOYFind1/YdaJy+xesMB\n ZhCbU8BKYn7LO0aQoRICr9kkljceY4cocpH4v24XI4QtLPHq+BaouIzE/53zmSDsaonvm66z\n QzR3MErcW9QKVWQvseX1OXZQcDALaEqs36UPEXaU2H/yFysklPgkbrwVhLifT2LStunMEGFe\n iY42IYhqJYkDJy9BhSUk/v7mgQh7SLx+8xwapJsZJTo+dDFOYJSfhbBrASPjKkbx1NLi3PTU\n YqO81HK94sTc4tK8dL3k/NxNjMDUcPrf8S87GHf9STrEKMDBqMTDu2BHeJwQa2JZcWXuIUYJ\n DmYlEd6NX0PjhHhTEiurUovy44tKc1KLDzFKc7AoifMaL3oZKySQnliSmp2aWpBaBJNl4uCU\n amBUuvSVb4PPprmZL8sl3piZKChkeqlfUY1WV5r4oYKDw8Qq1VI98IfsM+PgqLbHR/Q+/O2U\n vyUdfOVABctux7wnaoY7kgRuZWwJd7cXv3/zlKxdGqPpBbd/0kuNOE7YeHPv3qN04dVzPQmX\n Kys6XmpeK89VXiNm+/mj8V6x+Bs2sQ8+7zqz5L4SS3FGoqEWc1FxIgAllMlLCQMAAA==", "\n H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xe7pqF8LjDD49MbBo3fGAxeLdp+1M\n FrMuNbFbHOvcw2KxteE/k8WfN6YWmy9OYnJg9/i1YCmrx+I9L5k83u+7yubRt2UVYwBLlJ5N\n UX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllqkb5dgl7GkkkL2Qr2\n mlT8XvuTsYHxslYXIyeHhICJxIId89i6GLk4hASWMkrsu3INyOEASkhIvH7CDFEjLPHnWhdU\n zWdGib/v9rKDJNgENCROd8xjAkmICPQzSmz89Rusg1lATeJDz3sWEFtYwFJi0oyzYDaLgKrE\n 5pvLwZp5geJdXf9ZITbIS6zecACsl1PASmJ+yztGEFtIIF7i4/fz7BMY+RYwMqxiFEktLc5N\n zy021CtOzC0uzUvXS87P3cQIDNVtx35u3sF4aWPwIUYBDkYlHt4FO8LjhFgTy4orcw8xSnAw\n K4nwbvwaGifEm5JYWZValB9fVJqTWnyI0RToqInMUqLJ+cA4yiuJNzQ1NLewNDQ3Njc2s1AS\n 5+0QOBgjJJCeWJKanZpakFoE08fEwSnVwOicemGip8t/ds07u9T+PX7NFtB1cPXWYDkRn9Ux\n ip8CHv87xLvd+O8yzTijsl+fvO1Zpl/peFO4xdAu68TsiCT90133b21p/PS7a5l2si9D2j3b\n N1/2hXz/8SHu/v0isfNMZ6VeZyk0ih47dneO6ekNT5/e3edzYO4N6T2qKm/Tz/it2b+973eA\n EktxRqKhFnNRcSIAGNLfymsCAAA=" ], "X-CMS-MailID": "20200227142022eucas1p2b3cebb5af8470f715bffe20367226bff", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200227142022eucas1p2b3cebb5af8470f715bffe20367226bff", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200227142022eucas1p2b3cebb5af8470f715bffe20367226bff", "References": "<20200226075503.GA108150@intel.com>\n <20200227141840.15835-1-i.dyukov@samsung.com>\n <CGME20200227142022eucas1p2b3cebb5af8470f715bffe20367226bff@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v5 2/4] net/virtio: add link speed devarg", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some applications like pktgen use link speed to calculate\ntransmission rate. It limits outcome traffic to hardcoded 10G.\n\nThis patch adds speed devarg which allows to configure\nlink speed of virtio device.\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n doc/guides/nics/virtio.rst | 7 +++\n drivers/net/virtio/virtio_ethdev.c | 97 +++++++++++++++++++++++++-----\n drivers/net/virtio/virtio_pci.h | 1 +\n 3 files changed, 89 insertions(+), 16 deletions(-)", "diff": "diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst\nindex d1f5fb898..0341907ef 100644\n--- a/doc/guides/nics/virtio.rst\n+++ b/doc/guides/nics/virtio.rst\n@@ -356,6 +356,13 @@ Below devargs are supported by the PCI virtio driver:\n a virtio device needs to work in vDPA mode.\n (Default: 0 (disabled))\n \n+#. ``speed``:\n+\n+ It is used to specify link speed of virtio device. Link speed is a part of\n+ link status structure. It could be requested by application using\n+ rte_eth_link_get_nowait function.\n+ (Default: 10000 (10G))\n+\n Below devargs are supported by the virtio-user vdev:\n \n #. ``path``:\ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex d2c7f8c61..1fc1f1139 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -45,6 +45,10 @@ static int virtio_dev_promiscuous_enable(struct rte_eth_dev *dev);\n static int virtio_dev_promiscuous_disable(struct rte_eth_dev *dev);\n static int virtio_dev_allmulticast_enable(struct rte_eth_dev *dev);\n static int virtio_dev_allmulticast_disable(struct rte_eth_dev *dev);\n+static uint32_t virtio_dev_speed_capa_get(uint32_t speed);\n+static int virtio_dev_devargs_parse(struct rte_devargs *devargs,\n+\tint *vdpa,\n+\tuint32_t *speed);\n static int virtio_dev_info_get(struct rte_eth_dev *dev,\n \t\t\t\tstruct rte_eth_dev_info *dev_info);\n static int virtio_dev_link_update(struct rte_eth_dev *dev,\n@@ -1861,6 +1865,7 @@ int\n eth_virtio_dev_init(struct rte_eth_dev *eth_dev)\n {\n \tstruct virtio_hw *hw = eth_dev->data->dev_private;\n+\tuint32_t speed = ETH_SPEED_NUM_10G;\n \tint ret;\n \n \tif (sizeof(struct virtio_net_hdr_mrg_rxbuf) > RTE_PKTMBUF_HEADROOM) {\n@@ -1886,7 +1891,11 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)\n \n \t\treturn 0;\n \t}\n-\n+\tret = virtio_dev_devargs_parse(eth_dev->device->devargs,\n+\t\t NULL, &speed);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\thw->speed = speed;\n \t/*\n \t * Pass the information to the rte_eth_dev_close() that it should also\n \t * release the private port resources.\n@@ -1954,6 +1963,7 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n \treturn 0;\n }\n \n+\n static int vdpa_check_handler(__rte_unused const char *key,\n \t\tconst char *value, void *ret_val)\n {\n@@ -1965,33 +1975,89 @@ static int vdpa_check_handler(__rte_unused const char *key,\n \treturn 0;\n }\n \n+\n+static uint32_t\n+virtio_dev_speed_capa_get(uint32_t speed)\n+{\n+\tswitch (speed) {\n+\tcase ETH_SPEED_NUM_10G:\n+\t\treturn ETH_LINK_SPEED_10G;\n+\tcase ETH_SPEED_NUM_20G:\n+\t\treturn ETH_LINK_SPEED_20G;\n+\tcase ETH_SPEED_NUM_25G:\n+\t\treturn ETH_LINK_SPEED_25G;\n+\tcase ETH_SPEED_NUM_40G:\n+\t\treturn ETH_LINK_SPEED_40G;\n+\tcase ETH_SPEED_NUM_50G:\n+\t\treturn ETH_LINK_SPEED_50G;\n+\tcase ETH_SPEED_NUM_56G:\n+\t\treturn ETH_LINK_SPEED_56G;\n+\tcase ETH_SPEED_NUM_100G:\n+\t\treturn ETH_LINK_SPEED_100G;\n+\tdefault:\n+\t\treturn 0;\n+\t}\n+}\n+\n+\n+#define VIRTIO_ARG_SPEED \"speed\"\n+#define VIRTIO_ARG_VDPA \"vdpa\"\n+\n+\n+static int\n+link_speed_handler(const char *key __rte_unused,\n+\t\tconst char *value, void *ret_val)\n+{\n+\tuint32_t val;\n+\tif (!value || !ret_val)\n+\t\treturn -EINVAL;\n+\tval = strtoul(value, NULL, 0);\n+\t/* validate input */\n+\tif (virtio_dev_speed_capa_get(val) == 0)\n+\t\treturn -EINVAL;\n+\t*(uint32_t *)ret_val = val;\n+\n+\treturn 0;\n+}\n+\n+\n static int\n-virtio_dev_devargs_parse(struct rte_devargs *devargs, int *vdpa)\n+virtio_dev_devargs_parse(struct rte_devargs *devargs, int *vdpa,\n+\tuint32_t *speed)\n {\n \tstruct rte_kvargs *kvlist;\n-\tconst char *key = \"vdpa\";\n \tint ret = 0;\n \n \tif (devargs == NULL)\n \t\treturn 0;\n \n \tkvlist = rte_kvargs_parse(devargs->args, NULL);\n-\tif (kvlist == NULL)\n+\tif (kvlist == NULL) {\n+\t\tPMD_INIT_LOG(ERR, \"error when parsing param\");\n \t\treturn 0;\n-\n-\tif (!rte_kvargs_count(kvlist, key))\n-\t\tgoto exit;\n-\n-\tif (vdpa) {\n+\t}\n+\tif (vdpa && rte_kvargs_count(kvlist, VIRTIO_ARG_VDPA) == 1) {\n \t\t/* vdpa mode selected when there's a key-value pair:\n \t\t * vdpa=1\n \t\t */\n-\t\tret = rte_kvargs_process(kvlist, key,\n+\t\tret = rte_kvargs_process(kvlist, VIRTIO_ARG_VDPA,\n \t\t\t\tvdpa_check_handler, vdpa);\n-\t\tif (ret < 0)\n+\t\tif (ret < 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Failed to parse %s\",\n+\t\t\t\tVIRTIO_ARG_VDPA);\n \t\t\tgoto exit;\n+\t\t}\n+\t}\n+\tif (speed && rte_kvargs_count(kvlist, VIRTIO_ARG_SPEED) == 1) {\n+\t\tret = rte_kvargs_process(kvlist,\n+\t\t\t\t\tVIRTIO_ARG_SPEED,\n+\t\t\t\t\tlink_speed_handler, speed);\n+\t\tif (ret < 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Failed to parse %s\",\n+\t\t\t\t\tVIRTIO_ARG_SPEED);\n+\t\t\tgoto exit;\n+\t\t}\n \t}\n-\n \n exit:\n \trte_kvargs_free(kvlist);\n@@ -2004,7 +2070,7 @@ static int eth_virtio_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tint vdpa = 0;\n \tint ret = 0;\n \n-\tret = virtio_dev_devargs_parse(pci_dev->device.devargs, &vdpa);\n+\tret = virtio_dev_devargs_parse(pci_dev->device.devargs, &vdpa, NULL);\n \tif (ret < 0) {\n \t\tPMD_INIG_LOG(ERR, \"devargs parsing is failed\");\n \t\treturn ret;\n@@ -2385,7 +2451,7 @@ virtio_dev_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complet\n \n \tmemset(&link, 0, sizeof(link));\n \tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n-\tlink.link_speed = ETH_SPEED_NUM_10G;\n+\tlink.link_speed = hw->speed;\n \tlink.link_autoneg = ETH_LINK_FIXED;\n \n \tif (!hw->started) {\n@@ -2440,8 +2506,7 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n {\n \tuint64_t tso_mask, host_features;\n \tstruct virtio_hw *hw = dev->data->dev_private;\n-\n-\tdev_info->speed_capa = ETH_LINK_SPEED_10G; /* fake value */\n+\tdev_info->speed_capa = virtio_dev_speed_capa_get(hw->speed);\n \n \tdev_info->max_rx_queues =\n \t\tRTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES);\ndiff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h\nindex a38cb45ad..59012d55a 100644\n--- a/drivers/net/virtio/virtio_pci.h\n+++ b/drivers/net/virtio/virtio_pci.h\n@@ -253,6 +253,7 @@ struct virtio_hw {\n \tuint16_t port_id;\n \tuint8_t mac_addr[RTE_ETHER_ADDR_LEN];\n \tuint32_t notify_off_multiplier;\n+\tuint32_t speed; /* link speed in MB */\n \tuint8_t *isr;\n \tuint16_t *notify_base;\n \tstruct virtio_pci_common_cfg *common_cfg;\n", "prefixes": [ "v5", "2/4" ] }