Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65773/?format=api
{ "id": 65773, "url": "http://patches.dpdk.org/api/patches/65773/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200212220708.492297-7-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200212220708.492297-7-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200212220708.492297-7-thomas@monjalon.net", "date": "2020-02-12T22:07:08", "name": "[v5,6/6] net/mlx: fix overlinking with meson and glue dlopen", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fb9984e6c174493002516363f2a2977a41c335a6", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200212220708.492297-7-thomas@monjalon.net/mbox/", "series": [ { "id": 8518, "url": "http://patches.dpdk.org/api/series/8518/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8518", "date": "2020-02-12T22:07:02", "name": "mlx ibverbs linking in meson", "version": 5, "mbox": "http://patches.dpdk.org/series/8518/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65773/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65773/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A3F0EA0534;\n\tWed, 12 Feb 2020 23:08:14 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9BB921BFD2;\n\tWed, 12 Feb 2020 23:07:25 +0100 (CET)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 15C8B1BFB5;\n Wed, 12 Feb 2020 23:07:22 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id BAB6921C1C;\n Wed, 12 Feb 2020 17:07:21 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute1.internal (MEProxy); Wed, 12 Feb 2020 17:07:21 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id AC69C3060717;\n Wed, 12 Feb 2020 17:07:20 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=x9xh9hvSpD\n 0FZwKPrp57LzjuWGYalzdqq7h5zlI+W8U=; b=q1HAinSpLgf3oWPZ/SFSbmv1pT\n mZCIC0Gndmhuf4iCwIBKDA/EpYGXShMpqQIL6sh0gWX8FZyaaqNdhxwIv6QSEAfI\n mYV0ns5G8n7RyD1IcK9/aCi2ly07b8KLcbmIh6VJJ8ox+4KYUZfn8mH6HBvrh4LA\n CA/GgaOc4AxAS4Uh0=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=x9xh9hvSpD0FZwKPrp57LzjuWGYalzdqq7h5zlI+W8U=; b=y0U1Y6ph\n QiKm5luNfEqSDDqE6mDu4c+ivKt6PdH1VW1C5q91+SS4he74c2OfCglMcMBw2aGS\n umSPD9PECUMrc5X3jY0eTK1xw5Sc96XnEmTe4pvgEb8PkIa9bC/5RoK8QmocGih6\n hAl7VK35gu9mIcwmpZH1qnVD/DDwVaur6o6uT1fInR4az5YlwG2gLCw8DhI/i6e1\n kiSWT72oVeQ4WJvzdCm0byeenH3pVZMQ9D5adXW9xIHxAy3M9pbSYCGygz0UDkSW\n 6Sff6LCnol9cF8x2eJVsSW72GdRtOIPa0CqyjkMRd74WJ+MNtlyOLWSpygm7RiqE\n SQ+VKDke5Ce2OQ==" ], "X-ME-Sender": "<xms:GXdEXt0p7_H9NC0zpsYcDSdnBxFGuOngCsG1ZWjM5jwrhBHAs4cmLg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedrieeigddvvdcutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepgeenucfrrghr\n rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:GXdEXh5vTfmFjhYNeCMOZAP3xpRpJnlp-RILv9OS8p1zA6gM8s8d3w>\n <xmx:GXdEXoV5tthIBnvfqkPUYyGmyncHbl_4hsU1Zpjr7bN6O1R-ywXLHg>\n <xmx:GXdEXoCJEeLa4hN9Wyhsb_0R216IrFuhz7bcSqT-LpnlO-eLV7N5Vw>\n <xmx:GXdEXmMj4F8n-uI0NJwmFBpzrH5CvUdTL7q93y6CDj01tyd363pTHw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, stable@dpdk.org,\n Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>, =?utf-8?q?N=C3=A9lio_Laran?=\n\t=?utf-8?q?jeiro?= <nelio.laranjeiro@6wind.com>", "Date": "Wed, 12 Feb 2020 23:07:08 +0100", "Message-Id": "<20200212220708.492297-7-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200212220708.492297-1-thomas@monjalon.net>", "References": "<20200116071656.1663967-1-thomas@monjalon.net>\n <20200212220708.492297-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 6/6] net/mlx: fix overlinking with meson and\n\tglue dlopen", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If ibverbs_link is dlopen, the PMD and application should not\nbe linked with ibverbs, but the glue library is.\nUnfortunately the ibverbs dependency was exported in the\nvariable ext_deps, so there were overlinking.\n\nIt is fixed by not exporting the dependency in ext_deps,\nand recreating a limited dependency object for cflags only.\n\nFixes: 1dd7c7e38c19 (\"net/mlx4: support meson build\")\nFixes: 96d7c62a70c7 (\"net/mlx5: support meson build\")\nCc: stable@dpdk.org\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/common/mlx5/meson.build | 6 ++++--\n drivers/net/mlx4/meson.build | 6 ++++--\n 2 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build\nindex 0fe086136a..cfc178257d 100644\n--- a/drivers/common/mlx5/meson.build\n+++ b/drivers/common/mlx5/meson.build\n@@ -29,7 +29,7 @@ foreach libname:libnames\n \tendif\n \tif lib.found()\n \t\tlibs += lib\n-\t\tif not static_ibverbs\n+\t\tif not static_ibverbs and not dlopen_ibverbs\n \t\t\text_deps += lib\n \t\tendif\n \telse\n@@ -38,10 +38,12 @@ foreach libname:libnames\n \t\tsubdir_done()\n \tendif\n endforeach\n-if static_ibverbs\n+if static_ibverbs or dlopen_ibverbs\n \t# Build without adding shared libs to Requires.private\n \tibv_cflags = run_command(pkgconf, '--cflags', 'libibverbs').stdout()\n \text_deps += declare_dependency(compile_args: ibv_cflags.split())\n+endif\n+if static_ibverbs\n \t# Add static deps ldflags to internal apps and Libs.private\n \tibv_ldflags = run_command(ldflags_ibverbs_static, check:true).stdout()\n \text_deps += declare_dependency(link_args:ibv_ldflags.split())\ndiff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build\nindex f66e70f4d1..c598745730 100644\n--- a/drivers/net/mlx4/meson.build\n+++ b/drivers/net/mlx4/meson.build\n@@ -30,7 +30,7 @@ foreach libname:libnames\n \tendif\n \tif lib.found()\n \t\tlibs += lib\n-\t\tif not static_ibverbs\n+\t\tif not static_ibverbs and not dlopen_ibverbs\n \t\t\text_deps += lib\n \t\tendif\n \telse\n@@ -39,10 +39,12 @@ foreach libname:libnames\n \t\tsubdir_done()\n \tendif\n endforeach\n-if static_ibverbs\n+if static_ibverbs or dlopen_ibverbs\n \t# Build without adding shared libs to Requires.private\n \tibv_cflags = run_command(pkgconf, '--cflags', 'libibverbs').stdout()\n \text_deps += declare_dependency(compile_args: ibv_cflags.split())\n+endif\n+if static_ibverbs\n \t# Add static deps ldflags to internal apps and Libs.private\n \tibv_ldflags = run_command(ldflags_ibverbs_static, check:true).stdout()\n \text_deps += declare_dependency(link_args:ibv_ldflags.split())\n", "prefixes": [ "v5", "6/6" ] }