Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6577/?format=api
{ "id": 6577, "url": "http://patches.dpdk.org/api/patches/6577/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1437746295-12184-2-git-send-email-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1437746295-12184-2-git-send-email-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1437746295-12184-2-git-send-email-konstantin.ananyev@intel.com", "date": "2015-07-24T13:58:11", "name": "[dpdk-dev,PATCHv2,1/5] Revert \"ixgbe: check mbuf refcnt when clearing a ring\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "11695867f94a46b848079a89537a5c180f8f3e1a", "submitter": { "id": 33, "url": "http://patches.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1437746295-12184-2-git-send-email-konstantin.ananyev@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/6577/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/6577/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 35A6EC43E;\n\tFri, 24 Jul 2015 15:59:06 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 3E4FAC40C\n\tfor <dev@dpdk.org>; Fri, 24 Jul 2015 15:59:04 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga102.jf.intel.com with ESMTP; 24 Jul 2015 06:59:03 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 24 Jul 2015 06:59:02 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt6ODx14l026255; Fri, 24 Jul 2015 14:59:01 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t6ODx1m8012250;\n\tFri, 24 Jul 2015 14:59:01 +0100", "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with id t6ODx1ka012246;\n\tFri, 24 Jul 2015 14:59:01 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,538,1432623600\"; d=\"scan'208\";a=\"612155628\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 24 Jul 2015 14:58:11 +0100", "Message-Id": "<1437746295-12184-2-git-send-email-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": [ "<1437746295-12184-1-git-send-email-konstantin.ananyev@intel.com>", "<1437667506-3890-2-git-send-email-bruce.richardson@intel.com>" ], "References": [ "<1437667506-3890-2-git-send-email-bruce.richardson@intel.com>\n\t<1437746295-12184-1-git-send-email-konstantin.ananyev@intel.com>", "<1437667506-3890-2-git-send-email-bruce.richardson@intel.com>" ], "Subject": "[dpdk-dev] [PATCHv2 1/5] Revert \"ixgbe: check mbuf refcnt when\n\tclearing a ring\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This reverts commit b35d0d80f0a809939549ddde99c1a76b7e38bff3.\nThe bug fix was incorrect as it did not take account of the fact that\nthe mbufs that were previously freed may have since be re-allocated.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n drivers/net/ixgbe/ixgbe_rxtx.c | 3 +--\n drivers/net/ixgbe/ixgbe_rxtx_vec.c | 8 +-------\n 2 files changed, 2 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex af7e222..75c5555 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -2272,8 +2272,7 @@ ixgbe_rx_queue_release_mbufs(struct ixgbe_rx_queue *rxq)\n \n \tif (rxq->sw_ring != NULL) {\n \t\tfor (i = 0; i < rxq->nb_rx_desc; i++) {\n-\t\t\tif (rxq->sw_ring[i].mbuf != NULL &&\n-\t\t\t\t\trte_mbuf_refcnt_read(rxq->sw_ring[i].mbuf)) {\n+\t\t\tif (rxq->sw_ring[i].mbuf != NULL) {\n \t\t\t\trte_pktmbuf_free_seg(rxq->sw_ring[i].mbuf);\n \t\t\t\trxq->sw_ring[i].mbuf = NULL;\n \t\t\t}\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c b/drivers/net/ixgbe/ixgbe_rxtx_vec.c\nindex d3ac74a..47ff990 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec.c\n@@ -736,13 +736,7 @@ ixgbe_tx_queue_release_mbufs(struct ixgbe_tx_queue *txq)\n \t\t nb_free < max_desc && i != txq->tx_tail;\n \t\t i = (i + 1) & max_desc) {\n \t\t\ttxe = (struct ixgbe_tx_entry_v *)&txq->sw_ring[i];\n-\t\t\t/*\n-\t\t\t * Check for already freed packets.\n-\t\t\t * Note: ixgbe_tx_free_bufs does not NULL after free,\n-\t\t\t * so we actually have to check the reference count.\n-\t\t\t */\n-\t\t\tif (txe->mbuf != NULL &&\n-\t\t\t\t\trte_mbuf_refcnt_read(txe->mbuf) != 0)\n+\t\t\tif (txe->mbuf != NULL)\n \t\t\t\trte_pktmbuf_free_seg(txe->mbuf);\n \t\t}\n \t\t/* reset tx_entry */\n", "prefixes": [ "dpdk-dev", "PATCHv2", "1/5" ] }