Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65688/?format=api
{ "id": 65688, "url": "http://patches.dpdk.org/api/patches/65688/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200210103216.1168439-3-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200210103216.1168439-3-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200210103216.1168439-3-thomas@monjalon.net", "date": "2020-02-10T10:32:15", "name": "[2/3] common/mlx5: fix build with -fno-common", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5e8fc3121d3aa938eea6e956c116e76aa79fcead", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200210103216.1168439-3-thomas@monjalon.net/mbox/", "series": [ { "id": 8483, "url": "http://patches.dpdk.org/api/series/8483/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8483", "date": "2020-02-10T10:32:13", "name": "mlx: fix build with -fno-common (gcc 10)", "version": 1, "mbox": "http://patches.dpdk.org/series/8483/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65688/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/65688/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C33A0A052F;\n\tMon, 10 Feb 2020 11:32:40 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 36EB51BF80;\n\tMon, 10 Feb 2020 11:32:32 +0100 (CET)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A86371BF80\n for <dev@dpdk.org>; Mon, 10 Feb 2020 11:32:30 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id 56E7522025;\n Mon, 10 Feb 2020 05:32:30 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute1.internal (MEProxy); Mon, 10 Feb 2020 05:32:30 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 9C6E73280063;\n Mon, 10 Feb 2020 05:32:29 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=f9lHOsLFxz\n GgDBHHqKRwfCUihBCx3bDE1txcfXFqya8=; b=J3nLMM+TlGElnMDBaarbfWTFVy\n sw3avrpFEbRyuGfgnriUDmF/DvTqxf/AgKtfY5TupLOv+IkG36QLqbc66VbZmq5x\n Cpzjs/5hiUU4RBMxZdhAl1wNQ9i0SaUcxALrZYKwdJWmF6y0nAvQJ1ese2cutzFK\n liBhJJZM1ZY27w/LE=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=f9lHOsLFxzGgDBHHqKRwfCUihBCx3bDE1txcfXFqya8=; b=B+rt/IOI\n wbd5FFIbwqR9Lx3eHkKNe+IEIBmpguL9APnwrpRXJ8N2wtrHoaajHvF8jSGr/n+y\n XEZPTZjGTpIqJbVROSFkpfxpdZVr5ITyRRkwcwDgx2y71tCYDcBKqZ646P7dcnU6\n 00wXGXPV/jjbH0+Ntog3Mh41KbGiTyokjEKD5pNTYv/ACJdMpymArw1+as8WBvLj\n KcZIL9UPhTsEydlcPwLBo/Q+EEXo5xn54f65WaJ5eifvuOUbhVZ+aZGUbdohMeCP\n zPgY1YWLjaTgOaNNScjku5zGzUICP7YdLlI8t1k3x0Jzi2/gncQ4r211d8FfquNx\n WCDltfUadAJm6Q==" ], "X-ME-Sender": "<xms:PjFBXmmr748WkmfG-BAgRPVoPt9NKjnaa9_YKxrB0KWVExwzunaUqQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedriedugdduiecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepudenucfrrghr\n rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:PjFBXiEeAIIzbJyyhu27wfQbGtf40_9oxSyLceV8Es551VH3wnY2Bw>\n <xmx:PjFBXhkycuPymqdkR1f3dDtQbab_Yq_MBpu4Z77Hurs5YSuX-ssd_Q>\n <xmx:PjFBXpRLPTGwh3NNTt7WymgDSAfWfE5_7Y7FVvKXWedvsPRXbTK3xA>\n <xmx:PjFBXh5rhQnEmGH_AYR_shAyU6YytmMuxlGUfmnHA2X4ond03UTaug>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Date": "Mon, 10 Feb 2020 11:32:15 +0100", "Message-Id": "<20200210103216.1168439-3-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200210103216.1168439-1-thomas@monjalon.net>", "References": "<20200210103216.1168439-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/3] common/mlx5: fix build with -fno-common", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The variable storages of the same name are merged together\nif compiled with -fcommon. This is the default.\nThis default behaviour allows to declare a variable in a header file\nand share the variable in every .o binaries thanks to merge at link-time.\n\nIn the case of dlopen linking of the glue library, the pointer mlx5_glue\nis referencing the glue functions struct and is set after calling dlopen.\n\nIf compiling with -fno-common (default in GCC 10), the variable\nmust be declared as extern to avoid multiple re-definitions.\nIn case the glue layer is split in glue library, the variable mlx5_glue\nneeds to have its own storage for the rest of the PMD.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/common/mlx5/mlx5_common.c | 3 +++\n drivers/common/mlx5/mlx5_glue.h | 2 +-\n 2 files changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c\nindex f96506c27a..6110cf49de 100644\n--- a/drivers/common/mlx5/mlx5_common.c\n+++ b/drivers/common/mlx5/mlx5_common.c\n@@ -16,6 +16,9 @@\n \n int mlx5_common_logtype;\n \n+#ifdef MLX5_GLUE\n+const struct mlx5_glue *mlx5_glue = NULL;\n+#endif\n \n /**\n * Get PCI information by sysfs device path.\ndiff --git a/drivers/common/mlx5/mlx5_glue.h b/drivers/common/mlx5/mlx5_glue.h\nindex 6238b43946..29678623e4 100644\n--- a/drivers/common/mlx5/mlx5_glue.h\n+++ b/drivers/common/mlx5/mlx5_glue.h\n@@ -300,6 +300,6 @@ struct mlx5_glue {\n \t\t\t size_t event_resp_len);\n };\n \n-const struct mlx5_glue *mlx5_glue;\n+extern const struct mlx5_glue *mlx5_glue;\n \n #endif /* MLX5_GLUE_H_ */\n", "prefixes": [ "2/3" ] }