Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65526/?format=api
{ "id": 65526, "url": "http://patches.dpdk.org/api/patches/65526/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1580815045-32132-16-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1580815045-32132-16-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1580815045-32132-16-git-send-email-anoobj@marvell.com", "date": "2020-02-04T11:17:25", "name": "[v4,15/15] net/octeontx2: sync inline tag type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "23dd5333b243c63fadd98a2fa9888095e18a9299", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1580815045-32132-16-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 8411, "url": "http://patches.dpdk.org/api/series/8411/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8411", "date": "2020-02-04T11:17:10", "name": "add OCTEON TX2 inline IPsec support", "version": 4, "mbox": "http://patches.dpdk.org/series/8411/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65526/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65526/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4923A0532;\n\tTue, 4 Feb 2020 12:21:02 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 349EB1C1B8;\n\tTue, 4 Feb 2020 12:19:36 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id F369B1C1A6\n for <dev@dpdk.org>; Tue, 4 Feb 2020 12:19:33 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 014BFAMw010792; Tue, 4 Feb 2020 03:19:33 -0800", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 2xw9qukg4a-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 04 Feb 2020 03:19:33 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 4 Feb 2020 03:19:31 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 4 Feb 2020 03:19:30 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Tue, 4 Feb 2020 03:19:30 -0800", "from ajoseph83.caveonetworks.com (unknown [10.29.45.60])\n by maili.marvell.com (Postfix) with ESMTP id 6C8FD3F7068;\n Tue, 4 Feb 2020 03:19:26 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=b7LUf8iKs4ivE+Ay8/BTCiUF7LbOplb5D/HazixLAtc=;\n b=sfmemked+pOR6dttdyWjia6AAUJbN3Vjt/dsDW8JR1TOt7sbKUmu1jebSk4RvENXJRcU\n UDZaL+Gaw2rx0C0vlQU5+KFEbRKwovbW0gEF2jOGUP8gc/NlKhmgyb0wW+VPx0NgeZTG\n UdxyydL9Dsy/Ez9YWrLujHzFpgFzgmunxt1UOEECOA14rYT38USyYUTQYcq88r5g0jbd\n F9/ulSglXGzu9O/nQvFIn3YkVBuoA4F7BzKhJVFLts8sKnHv0GKIvX0lz9d4XzYzLQpe\n DrUP44BM1JjomWdhm+33lcNZ3MaXwOUHO2R2yLOAZwHOd62Fwzymb0gRVLeso1JWP4pb pA==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty\n <declan.doherty@intel.com>, Thomas Monjalon <thomas@monjalon.net>", "CC": "Vamsi Attunuru <vattunuru@marvell.com>, Jerin Jacob <jerinj@marvell.com>,\n Narayana Prasad <pathreya@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>,\n \"Pavan Nikhilesh\" <pbhagavatula@marvell.com>, Ankur Dwivedi\n <adwivedi@marvell.com>, Anoob Joseph <anoobj@marvell.com>,\n Archana Muniganti <marchana@marvell.com>,\n Tejasree Kondoj <ktejasree@marvell.com>, Lukasz\n Bartosik <lbartosik@marvell.com>, <dev@dpdk.org>", "Date": "Tue, 4 Feb 2020 16:47:25 +0530", "Message-ID": "<1580815045-32132-16-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1580815045-32132-1-git-send-email-anoobj@marvell.com>", "References": "<1580465035-30455-1-git-send-email-anoobj@marvell.com>\n <1580815045-32132-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572\n definitions=2020-02-04_02:2020-02-04,\n 2020-02-04 signatures=0", "Subject": "[dpdk-dev] [PATCH v4 15/15] net/octeontx2: sync inline tag type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Vamsi Attunuru <vattunuru@marvell.com>\n\nTag type configuration for the inline processed packets is set during\nethdev configuration, it might conflict with tag type configuration\ndone during Rx adapter configuration which would be setup later.\n\nThis conflict is fixed as part of flow rule creation by updating\ntag type config of inline same as Rx adapter configured tag type.\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Archana Muniganti <marchana@marvell.com>\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\nSigned-off-by: Vamsi Attunuru <vattunuru@marvell.com>\n---\n drivers/net/octeontx2/otx2_ethdev_sec.c | 28 ++++++++++++++++++++++++++++\n drivers/net/octeontx2/otx2_ethdev_sec.h | 2 ++\n drivers/net/octeontx2/otx2_flow.c | 26 ++++++++++++++++++++++++++\n 3 files changed, 56 insertions(+)", "diff": "diff --git a/drivers/net/octeontx2/otx2_ethdev_sec.c b/drivers/net/octeontx2/otx2_ethdev_sec.c\nindex 9ea0dc4..3858218 100644\n--- a/drivers/net/octeontx2/otx2_ethdev_sec.c\n+++ b/drivers/net/octeontx2/otx2_ethdev_sec.c\n@@ -754,6 +754,34 @@ eth_sec_ipsec_cfg(struct rte_eth_dev *eth_dev, uint8_t tt)\n }\n \n int\n+otx2_eth_sec_update_tag_type(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);\n+\tstruct otx2_mbox *mbox = dev->mbox;\n+\tstruct nix_aq_enq_rsp *rsp;\n+\tstruct nix_aq_enq_req *aq;\n+\tint ret;\n+\n+\taq = otx2_mbox_alloc_msg_nix_aq_enq(mbox);\n+\taq->qidx = 0; /* Read RQ:0 context */\n+\taq->ctype = NIX_AQ_CTYPE_RQ;\n+\taq->op = NIX_AQ_INSTOP_READ;\n+\n+\tret = otx2_mbox_process_msg(mbox, (void *)&rsp);\n+\tif (ret < 0) {\n+\t\totx2_err(\"Could not read RQ context\");\n+\t\treturn ret;\n+\t}\n+\n+\t/* Update tag type */\n+\tret = eth_sec_ipsec_cfg(eth_dev, rsp->rq.sso_tt);\n+\tif (ret < 0)\n+\t\totx2_err(\"Could not update sec eth tag type\");\n+\n+\treturn ret;\n+}\n+\n+int\n otx2_eth_sec_init(struct rte_eth_dev *eth_dev)\n {\n \tconst size_t sa_width = sizeof(struct otx2_ipsec_fp_in_sa);\ndiff --git a/drivers/net/octeontx2/otx2_ethdev_sec.h b/drivers/net/octeontx2/otx2_ethdev_sec.h\nindex 783e41d..e24358a 100644\n--- a/drivers/net/octeontx2/otx2_ethdev_sec.h\n+++ b/drivers/net/octeontx2/otx2_ethdev_sec.h\n@@ -130,6 +130,8 @@ int otx2_eth_sec_ctx_create(struct rte_eth_dev *eth_dev);\n \n void otx2_eth_sec_ctx_destroy(struct rte_eth_dev *eth_dev);\n \n+int otx2_eth_sec_update_tag_type(struct rte_eth_dev *eth_dev);\n+\n int otx2_eth_sec_init(struct rte_eth_dev *eth_dev);\n \n void otx2_eth_sec_fini(struct rte_eth_dev *eth_dev);\ndiff --git a/drivers/net/octeontx2/otx2_flow.c b/drivers/net/octeontx2/otx2_flow.c\nindex f1fb9f9..13a76e4 100644\n--- a/drivers/net/octeontx2/otx2_flow.c\n+++ b/drivers/net/octeontx2/otx2_flow.c\n@@ -3,6 +3,7 @@\n */\n \n #include \"otx2_ethdev.h\"\n+#include \"otx2_ethdev_sec.h\"\n #include \"otx2_flow.h\"\n \n int\n@@ -299,6 +300,21 @@ flow_free_rss_action(struct rte_eth_dev *eth_dev,\n \treturn 0;\n }\n \n+static int\n+flow_update_sec_tt(struct rte_eth_dev *eth_dev,\n+\t\t const struct rte_flow_action actions[])\n+{\n+\tint rc = 0;\n+\n+\tfor (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {\n+\t\tif (actions->type == RTE_FLOW_ACTION_TYPE_SECURITY) {\n+\t\t\trc = otx2_eth_sec_update_tag_type(eth_dev);\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\treturn rc;\n+}\n \n static int\n flow_parse_meta_items(__rte_unused struct otx2_parse_state *pst)\n@@ -491,6 +507,16 @@ otx2_flow_create(struct rte_eth_dev *dev,\n \t\tgoto err_exit;\n \t}\n \n+\tif (hw->rx_offloads & DEV_RX_OFFLOAD_SECURITY) {\n+\t\trc = flow_update_sec_tt(dev, actions);\n+\t\tif (rc != 0) {\n+\t\t\trte_flow_error_set(error, EIO,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"Failed to update tt with sec act\");\n+\t\t\tgoto err_exit;\n+\t\t}\n+\t}\n \n \tlist = &hw->npc_flow.flow_list[flow->priority];\n \t/* List in ascending order of mcam entries */\n", "prefixes": [ "v4", "15/15" ] }