Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65350/?format=api
{ "id": 65350, "url": "http://patches.dpdk.org/api/patches/65350/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200129172621.28565-4-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200129172621.28565-4-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200129172621.28565-4-david.marchand@redhat.com", "date": "2020-01-29T17:26:20", "name": "[v2,3/4] build: test meson installation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0f2ed06c98921c1eb63da2d7b275a3fe0a59f270", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200129172621.28565-4-david.marchand@redhat.com/mbox/", "series": [ { "id": 8347, "url": "http://patches.dpdk.org/api/series/8347/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8347", "date": "2020-01-29T17:26:18", "name": "add ABI checks", "version": 2, "mbox": "http://patches.dpdk.org/series/8347/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65350/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65350/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 17BDAA052F;\n\tWed, 29 Jan 2020 18:27:15 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 723CD1C06D;\n\tWed, 29 Jan 2020 18:27:03 +0100 (CET)", "from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com\n [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 6A1091C024\n for <dev@dpdk.org>; Wed, 29 Jan 2020 18:27:02 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-201-mXP5cI_CM8CsurDrVi2KMg-1; Wed, 29 Jan 2020 12:26:42 -0500", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2CDF4804AAE;\n Wed, 29 Jan 2020 17:26:41 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-128.brq.redhat.com\n [10.40.204.128])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 46F9F84BC9;\n Wed, 29 Jan 2020 17:26:38 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1580318821;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=fFO/5NxOR7o0aOc+KSThB10kzMAWUpXhuSuyzfp0fVo=;\n b=eHr3ZkFLWdjvJTYgbrGx59CIGm4D0qLD24wpBy/ZtijwhJ5nZIEf9h8u28qJvsJg2WeX0i\n +Ot7yDLgXw7YKc1j6K3PvBAf23vdEYHjY7dZw+DFYE2HQDHrSLf/cSx+nHaNOzXL9l/KaE\n WqmoiFeXTMlN5XHQwuaVwskqlxS8hko=", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com, kevin.laatz@intel.com,\n aconole@redhat.com, nhorman@tuxdriver.com, akhil.goyal@nxp.com,\n anoobj@marvell.com, Michael Santana <maicolgabriel@hotmail.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <arybchenko@solarflare.com>", "Date": "Wed, 29 Jan 2020 18:26:20 +0100", "Message-Id": "<20200129172621.28565-4-david.marchand@redhat.com>", "In-Reply-To": "<20200129172621.28565-1-david.marchand@redhat.com>", "References": "<20191220152058.10739-1-david.marchand@redhat.com>\n <20200129172621.28565-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-MC-Unique": "mXP5cI_CM8CsurDrVi2KMg-1", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH v2 3/4] build: test meson installation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Let's test installing with meson as part of Travis and the\ndevtools/test-meson-builds.sh script.\nThe resulting headers and binaries make more sense to run checks\nagainst, since they should be the same as what the final users get.\n\nIn this patch, test-null.sh is now called on an installed testpmd.\nFor this to work LD_LIBRARY_PATH must be set appropriately, but it can\nbe hard to debug, so a call to ldd has been added.\n\nThe (future) ABI compatibility checks will also need to filter its report\nagainst installed public headers.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n .ci/linux-build.sh | 6 +++++-\n devtools/test-meson-builds.sh | 27 ++++++++++++++++-----------\n devtools/test-null.sh | 1 +\n 3 files changed, 22 insertions(+), 12 deletions(-)", "diff": "diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh\nindex ccc3a7ccd..e61aa2b0a 100755\n--- a/.ci/linux-build.sh\n+++ b/.ci/linux-build.sh\n@@ -29,11 +29,15 @@ if [ \"$BUILD_32BIT\" = \"1\" ]; then\n fi\n \n OPTS=\"$OPTS --default-library=$DEF_LIB\"\n+OPTS=\"$OPTS --prefix=/usr -Dlibdir=lib\"\n meson build --werror -Dexamples=all $OPTS\n ninja -C build\n+DESTDIR=$(pwd)/install ninja -C build install\n \n if [ \"$AARCH64\" != \"1\" ]; then\n- devtools/test-null.sh\n+ export LD_LIBRARY_PATH=$(pwd)/install/usr/lib\n+ devtools/test-null.sh install/usr/bin/dpdk-testpmd\n+ unset LD_LIBRARY_PATH\n fi\n \n if [ \"$RUN_TESTS\" = \"1\" ]; then\ndiff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex aed175889..254588ae6 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -63,7 +63,7 @@ config () # <dir> <builddir> <meson options>\n \tshift\n \tbuilddir=$1\n \tshift\n-\toptions=\"--werror -Dexamples=all\"\n+\toptions=\"--werror -Dexamples=all --prefix=/usr -Dlibdir=lib\"\n \tfor option in $DPDK_MESON_OPTIONS ; do\n \t\toptions=\"$options -D$option\"\n \tdone\n@@ -74,22 +74,29 @@ config () # <dir> <builddir> <meson options>\n \tfi\n }\n \n-compile () # <builddir>\n+compile () # <builddir> <installdir>\n {\n \tbuilddir=$1\n \tshift\n+\texport DESTDIR=$1\n+\tshift\n+\trm -rf $DESTDIR\n \tif [ -n \"$TEST_MESON_BUILD_VERY_VERBOSE\" ] ; then\n \t\t# for full output from ninja use \"-v\"\n \t\techo \"$ninja_cmd -v -C $builddir\"\n \t\t$ninja_cmd -v -C $builddir\n+\t\t$ninja_cmd -v -C $builddir install\n \telif [ -n \"$TEST_MESON_BUILD_VERBOSE\" ] ; then\n \t\t# for keeping the history of short cmds, pipe through cat\n \t\techo \"$ninja_cmd -C $builddir | cat\"\n \t\t$ninja_cmd -C $builddir | cat\n+\t\t$ninja_cmd -C $builddir install | cat\n \telse\n \t\techo \"$ninja_cmd -C $builddir\"\n \t\t$ninja_cmd -C $builddir\n+\t\t$ninja_cmd -C $builddir install\n \tfi\n+\tunset DESTDIR\n }\n \n build () # <directory> <target compiler> <meson options>\n@@ -102,7 +109,8 @@ build () # <directory> <target compiler> <meson options>\n \tcommand -v ${CC##* } >/dev/null 2>&1 || return 0\n \tload_env $targetcc || return 0\n \tconfig $srcdir $builds_dir/$targetdir $*\n-\tcompile $builds_dir/$targetdir\n+\tcompile $builds_dir/$targetdir \\\n+\t\t$(readlink -f $builds_dir/$targetdir/install)\n }\n \n if [ \"$1\" = \"-vv\" ] ; then\n@@ -134,7 +142,7 @@ ok=$(cc -march=$default_machine -E - < /dev/null > /dev/null 2>&1 || echo false)\n if [ \"$ok\" = \"false\" ] ; then\n \tdefault_machine='corei7'\n fi\n-build build-x86-default cc -Dlibdir=lib -Dmachine=$default_machine $use_shared\n+build build-x86-default cc -Dmachine=$default_machine $use_shared\n \n c=aarch64-linux-gnu-gcc\n # generic armv8a with clang as host compiler\n@@ -150,12 +158,9 @@ for f in $srcdir/config/arm/arm64_[bdo]*gcc ; do\n \tunset CC\n done\n \n-# Test installation of the x86-default target, to be used for checking\n-# the sample apps build using the pkg-config file for cflags and libs\n-build_path=$(readlink -f $builds_dir/build-x86-default)\n-export DESTDIR=$build_path/install-root\n-$ninja_cmd -C $build_path install\n-\n+# Use the x86-default target, to check the sample apps build using the\n+# pkg-config file for cflags and libs\n+export DESTDIR=$(readlink -f $builds_dir/build-x86-default/install)\n load_env cc\n pc_file=$(find $DESTDIR -name libdpdk.pc)\n export PKG_CONFIG_PATH=$(dirname $pc_file):$PKG_CONFIG_PATH\n@@ -165,6 +170,6 @@ if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then\n \texport PKGCONF=\"pkg-config --define-prefix\"\n \tfor example in cmdline helloworld l2fwd l3fwd skeleton timer; do\n \t\techo \"## Building $example\"\n-\t\t$MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example clean all\n+\t\t$MAKE -C $DESTDIR/usr/share/dpdk/examples/$example clean all\n \tdone\n fi\ndiff --git a/devtools/test-null.sh b/devtools/test-null.sh\nindex 548de8113..8121ec9e3 100755\n--- a/devtools/test-null.sh\n+++ b/devtools/test-null.sh\n@@ -21,6 +21,7 @@ fi\n \n if ldd $testpmd | grep -q librte_ ; then\n \texport LD_LIBRARY_PATH=$build/drivers:$build/lib:$LD_LIBRARY_PATH\n+\tldd $testpmd\n \tlibs='-d librte_mempool_ring.so -d librte_pmd_null.so'\n else\n \tlibs=\n", "prefixes": [ "v2", "3/4" ] }