Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65185/?format=api
{ "id": 65185, "url": "http://patches.dpdk.org/api/patches/65185/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200128062357.9316-6-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200128062357.9316-6-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200128062357.9316-6-somnath.kotur@broadcom.com", "date": "2020-01-28T06:23:54", "name": "[5/8] net/bnxt: remove redundant macro", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "050b49470adcd020d93ca1deab4cee26a2b7d101", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200128062357.9316-6-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 8313, "url": "http://patches.dpdk.org/api/series/8313/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8313", "date": "2020-01-28T06:23:50", "name": "bnxt patch set", "version": 1, "mbox": "http://patches.dpdk.org/series/8313/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65185/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65185/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ECD59A04B3;\n\tTue, 28 Jan 2020 07:26:07 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B9BD31C112;\n\tTue, 28 Jan 2020 07:25:30 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 9E9EE1BFB6\n for <dev@dpdk.org>; Tue, 28 Jan 2020 07:25:22 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id DFD7F2904F8;\n Mon, 27 Jan 2020 22:25:21 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com DFD7F2904F8", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1580192722;\n bh=Ls5jLUHt0Yakdae80TmaTTjy4iMX+wt6aRZWB8N4WDk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=pbDujHHk9GmLSF+sFD7tdGFoNlVRAsAC6WXsfUkgYaqA6A0KnE+s3WzK6b3HTSw+Q\n /tHY9b1NoegMZCJva9NSmyc0DwKL12lkYTa40r/q9ixp+rqhNz1Umm7/Qo4Buz6DW5\n hQG6nNwgTzEi9sCo23wOetIP8rh6WICDCNU5d2/o=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Tue, 28 Jan 2020 11:53:54 +0530", "Message-Id": "<20200128062357.9316-6-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200128062357.9316-1-somnath.kotur@broadcom.com>", "References": "<20200128062357.9316-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 5/8] net/bnxt: remove redundant macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nUse \"dev->data->dev_started\" state, instead of local BNXT_FLAG_INIT_DONE\nto check whether device has been initialised or not.\n\nFixes: ed2ced6fe927 (\"net/bnxt: check initialization before accessing stats\")\n\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 -\n drivers/net/bnxt/bnxt_ethdev.c | 2 --\n drivers/net/bnxt/bnxt_stats.c | 4 ++--\n 3 files changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex bca9ad4..95f1f1a 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -520,7 +520,6 @@ struct bnxt {\n #define BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED\tBIT(18)\n #define BNXT_FLAG_EXT_STATS_SUPPORTED\t\tBIT(19)\n #define BNXT_FLAG_NEW_RM\t\t\tBIT(20)\n-#define BNXT_FLAG_INIT_DONE\t\t\tBIT(21)\n #define BNXT_FLAG_FW_CAP_ONE_STEP_TX_TS\t\tBIT(22)\n #define BNXT_FLAG_ADV_FLOW_MGMT\t\t\tBIT(23)\n #define BNXT_FLAG_RX_VECTOR_PKT_MODE\t\tBIT(24)\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 267a361..b04685c 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -887,7 +887,6 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \teth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev);\n \teth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);\n \n-\tbp->flags |= BNXT_FLAG_INIT_DONE;\n \teth_dev->data->dev_started = 1;\n \tpthread_mutex_lock(&bp->def_cp_lock);\n \tbnxt_schedule_fw_health_check(bp);\n@@ -947,7 +946,6 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n \n \tbnxt_cancel_fw_health_check(bp);\n \n-\tbp->flags &= ~BNXT_FLAG_INIT_DONE;\n \tbnxt_dev_set_link_down_op(eth_dev);\n \n \t/* Wait for link to be reset and the async notification to process.\ndiff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c\nindex 32f112b..4668629 100644\n--- a/drivers/net/bnxt/bnxt_stats.c\n+++ b/drivers/net/bnxt/bnxt_stats.c\n@@ -389,7 +389,7 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,\n \tif (rc)\n \t\treturn rc;\n \n-\tif (!(bp->flags & BNXT_FLAG_INIT_DONE))\n+\tif (!eth_dev->data->dev_started)\n \t\treturn -EIO;\n \n \tnum_q_stats = RTE_MIN(bp->rx_cp_nr_rings,\n@@ -434,7 +434,7 @@ int bnxt_stats_reset_op(struct rte_eth_dev *eth_dev)\n \tif (ret)\n \t\treturn ret;\n \n-\tif (!(bp->flags & BNXT_FLAG_INIT_DONE)) {\n+\tif (!eth_dev->data->dev_started) {\n \t\tPMD_DRV_LOG(ERR, \"Device Initialization not complete!\\n\");\n \t\treturn -EINVAL;\n \t}\n", "prefixes": [ "5/8" ] }