Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65175/?format=api
{ "id": 65175, "url": "http://patches.dpdk.org/api/patches/65175/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200128053506.2173-8-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200128053506.2173-8-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200128053506.2173-8-pbhagavatula@marvell.com", "date": "2020-01-28T05:35:01", "name": "[v6,07/11] examples/l3fwd: add service core setup based on caps", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d923904c981c4c06bc238ec546184fe680b8a04d", "submitter": { "id": 1183, "url": "http://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200128053506.2173-8-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 8312, "url": "http://patches.dpdk.org/api/series/8312/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8312", "date": "2020-01-28T05:34:54", "name": "example/l3fwd: introduce event device support", "version": 6, "mbox": "http://patches.dpdk.org/series/8312/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65175/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65175/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 97CDDA04B3;\n\tTue, 28 Jan 2020 06:36:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2D6901C0B9;\n\tTue, 28 Jan 2020 06:35:54 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 3D4861C0C3\n for <dev@dpdk.org>; Tue, 28 Jan 2020 06:35:52 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 00S5YjFU016830; Mon, 27 Jan 2020 21:35:51 -0800", "from sc-exch04.marvell.com ([199.233.58.184])\n by mx0b-0016f401.pphosted.com with ESMTP id 2xrp2t2fws-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 27 Jan 2020 21:35:51 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 27 Jan\n 2020 21:35:49 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 27 Jan 2020 21:35:49 -0800", "from BG-LT7430.marvell.com (unknown [10.28.17.49])\n by maili.marvell.com (Postfix) with ESMTP id EE2713F703F;\n Mon, 27 Jan 2020 21:35:44 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=iAO8Z3XtwQBZMwWN2t6Z2ZCCvZtMwUFHlI8a0sTnBn4=;\n b=Z2afKIlTDyX8TSzA3a1mf6gouJg+uPjc7W0+TOIziNFx7g4qmFXjlxYeuYkPglh68ZiD\n 8kjrPSWghZ/iJabqmNMrab2RNdKCyF1XPP/TAcZ+LQIO3VaO6gd3e4kv1jHWPeoZWJAZ\n SlimcaXejBLLcdMzM68QcsgC70Eu0P6gxJwn9SxPScUCxByVcd12inEHOSbqSMMs0jqO\n tZfEk++96g7lm6oWDYOIWYfmuCfEhUwNSZPMH3MjjBH39CrObBz+GxTg8U85Aw4AsfQ/\n yOPhvQbhx0xGjjgmEhbY/00AqOruf0QTaET6Z2SZGfvwa+MAYyidL3MwAzMf+r2CQqCi 3w==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>, <konstantin.ananyev@intel.com>, Marko Kovacevic\n <marko.kovacevic@intel.com>, Ori Kam <orika@mellanox.com>, Bruce Richardson\n <bruce.richardson@intel.com>, Radu Nicolau <radu.nicolau@intel.com>, \"Akhil\n Goyal\" <akhil.goyal@nxp.com>, Tomasz Kantecki <tomasz.kantecki@intel.com>,\n Sunil Kumar Kori <skori@marvell.com>, Pavan Nikhilesh\n <pbhagavatula@marvell.com>", "CC": "<dev@dpdk.org>", "Date": "Tue, 28 Jan 2020 11:05:01 +0530", "Message-ID": "<20200128053506.2173-8-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200128053506.2173-1-pbhagavatula@marvell.com>", "References": "<20200124040542.2360--1-pbhagavatula@marvell.com>\n <20200128053506.2173-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572\n definitions=2020-01-27_08:2020-01-24,\n 2020-01-27 signatures=0", "Subject": "[dpdk-dev] [PATCH v6 07/11] examples/l3fwd: add service core setup\n\tbased on caps", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nAdd service core setup when eventdev and Rx/Tx adapter don't have\ninternal port capability.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n examples/l3fwd/l3fwd_event.c | 6 ++\n examples/l3fwd/main.c | 188 +++++++++++++++++++++++++++--------\n 2 files changed, 150 insertions(+), 44 deletions(-)", "diff": "diff --git a/examples/l3fwd/l3fwd_event.c b/examples/l3fwd/l3fwd_event.c\nindex 0a75e39ee..1ed42c3ab 100644\n--- a/examples/l3fwd/l3fwd_event.c\n+++ b/examples/l3fwd/l3fwd_event.c\n@@ -212,6 +212,7 @@ l3fwd_event_resource_setup(struct rte_eth_conf *port_conf)\n {\n \tstruct l3fwd_event_resources *evt_rsrc = l3fwd_get_eventdev_rsrc();\n \tuint32_t event_queue_cfg;\n+\tint ret;\n \n \tif (!evt_rsrc->enabled)\n \t\treturn;\n@@ -236,4 +237,9 @@ l3fwd_event_resource_setup(struct rte_eth_conf *port_conf)\n \n \t/* Rx/Tx adapters configuration */\n \tevt_rsrc->ops.adapter_setup();\n+\n+\t/* Start event device */\n+\tret = rte_event_dev_start(evt_rsrc->event_d_id);\n+\tif (ret < 0)\n+\t\trte_exit(EXIT_FAILURE, \"Error in starting eventdev\");\n }\ndiff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex 04526343f..4bb00a48b 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -899,49 +899,18 @@ prepare_ptype_parser(uint16_t portid, uint16_t queueid)\n \treturn 0;\n }\n \n-int\n-main(int argc, char **argv)\n+static void\n+l3fwd_poll_resource_setup(void)\n {\n-\tstruct l3fwd_event_resources *evt_rsrc;\n-\tstruct lcore_conf *qconf;\n+\tuint8_t nb_rx_queue, queue, socketid;\n \tstruct rte_eth_dev_info dev_info;\n+\tuint32_t n_tx_queue, nb_lcores;\n \tstruct rte_eth_txconf *txconf;\n-\tint ret;\n-\tunsigned nb_ports;\n+\tstruct lcore_conf *qconf;\n \tuint16_t queueid, portid;\n-\tunsigned lcore_id;\n-\tuint32_t n_tx_queue, nb_lcores;\n-\tuint8_t nb_rx_queue, queue, socketid;\n-\n-\t/* init EAL */\n-\tret = rte_eal_init(argc, argv);\n-\tif (ret < 0)\n-\t\trte_exit(EXIT_FAILURE, \"Invalid EAL parameters\\n\");\n-\targc -= ret;\n-\targv += ret;\n-\n-\tforce_quit = false;\n-\tsignal(SIGINT, signal_handler);\n-\tsignal(SIGTERM, signal_handler);\n-\n-\t/* pre-init dst MACs for all ports to 02:00:00:00:00:xx */\n-\tfor (portid = 0; portid < RTE_MAX_ETHPORTS; portid++) {\n-\t\tdest_eth_addr[portid] =\n-\t\t\tRTE_ETHER_LOCAL_ADMIN_ADDR + ((uint64_t)portid << 40);\n-\t\t*(uint64_t *)(val_eth + portid) = dest_eth_addr[portid];\n-\t}\n-\n-\tevt_rsrc = l3fwd_get_eventdev_rsrc();\n-\t/* parse application arguments (after the EAL ones) */\n-\tret = parse_args(argc, argv);\n-\tif (ret < 0)\n-\t\trte_exit(EXIT_FAILURE, \"Invalid L3FWD parameters\\n\");\n-\n-\tevt_rsrc->per_port_pool = per_port_pool;\n-\tevt_rsrc->pkt_pool = pktmbuf_pool;\n-\tevt_rsrc->port_mask = enabled_port_mask;\n-\t/* Configure eventdev parameters if user has requested */\n-\tl3fwd_event_resource_setup(&port_conf);\n+\tunsigned int nb_ports;\n+\tunsigned int lcore_id;\n+\tint ret;\n \n \tif (check_lcore_params() < 0)\n \t\trte_exit(EXIT_FAILURE, \"check_lcore_params failed\\n\");\n@@ -957,9 +926,6 @@ main(int argc, char **argv)\n \n \tnb_lcores = rte_lcore_count();\n \n-\t/* Setup function pointers for lookup method. */\n-\tsetup_l3fwd_lookup_tables();\n-\n \t/* initialize all ports */\n \tRTE_ETH_FOREACH_DEV(portid) {\n \t\tstruct rte_eth_conf local_port_conf = port_conf;\n@@ -1127,7 +1093,142 @@ main(int argc, char **argv)\n \t\t}\n \t}\n \n-\tprintf(\"\\n\");\n+\n+}\n+\n+static inline int\n+l3fwd_service_enable(uint32_t service_id)\n+{\n+\tuint8_t min_service_count = UINT8_MAX;\n+\tuint32_t slcore_array[RTE_MAX_LCORE];\n+\tunsigned int slcore = 0;\n+\tuint8_t service_count;\n+\tint32_t slcore_count;\n+\n+\tif (!rte_service_lcore_count())\n+\t\treturn -ENOENT;\n+\n+\tslcore_count = rte_service_lcore_list(slcore_array, RTE_MAX_LCORE);\n+\tif (slcore_count < 0)\n+\t\treturn -ENOENT;\n+\t/* Get the core which has least number of services running. */\n+\twhile (slcore_count--) {\n+\t\t/* Reset default mapping */\n+\t\trte_service_map_lcore_set(service_id,\n+\t\t\t\tslcore_array[slcore_count], 0);\n+\t\tservice_count = rte_service_lcore_count_services(\n+\t\t\t\tslcore_array[slcore_count]);\n+\t\tif (service_count < min_service_count) {\n+\t\t\tslcore = slcore_array[slcore_count];\n+\t\t\tmin_service_count = service_count;\n+\t\t}\n+\t}\n+\tif (rte_service_map_lcore_set(service_id, slcore, 1))\n+\t\treturn -ENOENT;\n+\trte_service_lcore_start(slcore);\n+\n+\treturn 0;\n+}\n+\n+static void\n+l3fwd_event_service_setup(void)\n+{\n+\tstruct l3fwd_event_resources *evt_rsrc = l3fwd_get_eventdev_rsrc();\n+\tstruct rte_event_dev_info evdev_info;\n+\tuint32_t service_id, caps;\n+\tint ret, i;\n+\n+\trte_event_dev_info_get(evt_rsrc->event_d_id, &evdev_info);\n+\tif (!(evdev_info.event_dev_cap & RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED)) {\n+\t\tret = rte_event_dev_service_id_get(evt_rsrc->event_d_id,\n+\t\t\t\t&service_id);\n+\t\tif (ret != -ESRCH && ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"Error in starting eventdev service\\n\");\n+\t\tl3fwd_service_enable(service_id);\n+\t}\n+\n+\tfor (i = 0; i < evt_rsrc->rx_adptr.nb_rx_adptr; i++) {\n+\t\tret = rte_event_eth_rx_adapter_caps_get(evt_rsrc->event_d_id,\n+\t\t\t\tevt_rsrc->rx_adptr.rx_adptr[i], &caps);\n+\t\tif (ret < 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"Failed to get Rx adapter[%d] caps\\n\",\n+\t\t\t\t evt_rsrc->rx_adptr.rx_adptr[i]);\n+\t\tret = rte_event_eth_rx_adapter_service_id_get(\n+\t\t\t\tevt_rsrc->event_d_id,\n+\t\t\t\t&service_id);\n+\t\tif (ret != -ESRCH && ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"Error in starting Rx adapter[%d] service\\n\",\n+\t\t\t\t evt_rsrc->rx_adptr.rx_adptr[i]);\n+\t\tl3fwd_service_enable(service_id);\n+\t}\n+\n+\tfor (i = 0; i < evt_rsrc->tx_adptr.nb_tx_adptr; i++) {\n+\t\tret = rte_event_eth_tx_adapter_caps_get(evt_rsrc->event_d_id,\n+\t\t\t\tevt_rsrc->tx_adptr.tx_adptr[i], &caps);\n+\t\tif (ret < 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"Failed to get Rx adapter[%d] caps\\n\",\n+\t\t\t\t evt_rsrc->tx_adptr.tx_adptr[i]);\n+\t\tret = rte_event_eth_tx_adapter_service_id_get(\n+\t\t\t\tevt_rsrc->event_d_id,\n+\t\t\t\t&service_id);\n+\t\tif (ret != -ESRCH && ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"Error in starting Rx adapter[%d] service\\n\",\n+\t\t\t\t evt_rsrc->tx_adptr.tx_adptr[i]);\n+\t\tl3fwd_service_enable(service_id);\n+\t}\n+}\n+\n+int\n+main(int argc, char **argv)\n+{\n+\tstruct l3fwd_event_resources *evt_rsrc;\n+\tstruct lcore_conf *qconf;\n+\tuint16_t queueid, portid;\n+\tunsigned int lcore_id;\n+\tuint8_t queue;\n+\tint ret;\n+\n+\t/* init EAL */\n+\tret = rte_eal_init(argc, argv);\n+\tif (ret < 0)\n+\t\trte_exit(EXIT_FAILURE, \"Invalid EAL parameters\\n\");\n+\targc -= ret;\n+\targv += ret;\n+\n+\tforce_quit = false;\n+\tsignal(SIGINT, signal_handler);\n+\tsignal(SIGTERM, signal_handler);\n+\n+\t/* pre-init dst MACs for all ports to 02:00:00:00:00:xx */\n+\tfor (portid = 0; portid < RTE_MAX_ETHPORTS; portid++) {\n+\t\tdest_eth_addr[portid] =\n+\t\t\tRTE_ETHER_LOCAL_ADMIN_ADDR + ((uint64_t)portid << 40);\n+\t\t*(uint64_t *)(val_eth + portid) = dest_eth_addr[portid];\n+\t}\n+\n+\tevt_rsrc = l3fwd_get_eventdev_rsrc();\n+\t/* parse application arguments (after the EAL ones) */\n+\tret = parse_args(argc, argv);\n+\tif (ret < 0)\n+\t\trte_exit(EXIT_FAILURE, \"Invalid L3FWD parameters\\n\");\n+\n+\t/* Setup function pointers for lookup method. */\n+\tsetup_l3fwd_lookup_tables();\n+\n+\tevt_rsrc->per_port_pool = per_port_pool;\n+\tevt_rsrc->pkt_pool = pktmbuf_pool;\n+\tevt_rsrc->port_mask = enabled_port_mask;\n+\t/* Configure eventdev parameters if user has requested */\n+\tif (evt_rsrc->enabled) {\n+\t\tl3fwd_event_resource_setup(&port_conf);\n+\t\tl3fwd_event_service_setup();\n+\t} else\n+\t\tl3fwd_poll_resource_setup();\n \n \t/* start ports */\n \tRTE_ETH_FOREACH_DEV(portid) {\n@@ -1170,7 +1271,6 @@ main(int argc, char **argv)\n \t\t}\n \t}\n \n-\n \tcheck_all_ports_link_status(enabled_port_mask);\n \n \tret = 0;\n", "prefixes": [ "v6", "07/11" ] }