Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65155/?format=api
{ "id": 65155, "url": "http://patches.dpdk.org/api/patches/65155/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200127154402.4008069-5-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200127154402.4008069-5-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200127154402.4008069-5-thomas@monjalon.net", "date": "2020-01-27T15:44:02", "name": "[v2,4/4] net/mlx: workaround static linkage with meson", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e07a32d5142ffbd3ea5c53f84a6ab5238702c877", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200127154402.4008069-5-thomas@monjalon.net/mbox/", "series": [ { "id": 8307, "url": "http://patches.dpdk.org/api/series/8307/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8307", "date": "2020-01-27T15:43:58", "name": "add static ibverbs in meson", "version": 2, "mbox": "http://patches.dpdk.org/series/8307/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65155/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65155/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B3E3A0531;\n\tMon, 27 Jan 2020 16:44:58 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 67CAA1BFEC;\n\tMon, 27 Jan 2020 16:44:31 +0100 (CET)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2B8B41BFE0\n for <dev@dpdk.org>; Mon, 27 Jan 2020 16:44:28 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id BD41B22139;\n Mon, 27 Jan 2020 10:44:27 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute1.internal (MEProxy); Mon, 27 Jan 2020 10:44:27 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 00F36328005E;\n Mon, 27 Jan 2020 10:44:26 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=n0GBEB3nbL\n O5dQaWQDOt6X/yl6cVy1jyUBpHZDmphPk=; b=ilxtyeLy8rovboqxBV7rP5r3n4\n 3PvfdSu5YT/LrzFDurMDAsxar7estPy2V8+nerVUvqExURPVy5LT5HP20oBQDiQv\n 38kynb1b5JkK4gUJDtMTXIjVbhe4KBh7nm6WpQBO32yZGD0hee/LxMHCoPgIHR1Q\n gWQePywY+lEaTKF2I=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=n0GBEB3nbLO5dQaWQDOt6X/yl6cVy1jyUBpHZDmphPk=; b=Jg/wh9f4\n pT6rFP1yKQL7SCdUwUoe2leMh7CyBGp4SgFWA6wAfxTeXU7v5ZUg1ftg9C53Z0Jx\n haxOcqpYrTVTxvJD4xza0bc8EgPnhEltLc9dYm6G9vWgVknqcGaywxNFEVaga0gu\n enq+DNljDhEBZ9Zw9nyiG5a7DqDEJ5qiLu/fkgy2zLlwwCv/6yp30xbPtsZEY3T5\n qznnIFVHKcloj+ugsgVCFNrMtKFn67+Pmn6HYLekXO6L+p3GsVUydUt9B4C6X1Iy\n eZ5EIeAbjN9ZYPdiB32Cmu+SXB6S91wlrJJDaSP3P8qVYCXeCM/dkvYdyLYWJgCQ\n +jroOKhN5xj2cA==" ], "X-ME-Sender": "<xms:WwUvXj-KhMYDEdc3rDeXMGGmFkkVV8Nt5F1u0TQ-Gns_A2PGw5zuSg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedrfedvgdejkecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh\n hmrghinhepghhithhhuhgsrdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeen\n ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomh\n grshesmhhonhhjrghlohhnrdhnvght", "X-ME-Proxy": "<xmx:WwUvXgdGLRVyrJqtlahI5ma7cdCGJT3su45cT1Nm0J1kwgRlzQKB2Q>\n <xmx:WwUvXtI51eAl4A07jqDK_xZET8SrDqLHRgT3ktAZLBX8uU7yL8v0bw>\n <xmx:WwUvXgjBXMRCFc38IxmM3vZCBUPY5OHQR2o3ePEEDB-bwyCpUFJd5Q>\n <xmx:WwUvXoTTFRWA1ivuL9_Q-laSRaUFhiYvUe5-BO8kR5eysKjIucewvw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, Matan Azrad <matan@mellanox.com>,\n Shahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Date": "Mon, 27 Jan 2020 16:44:02 +0100", "Message-Id": "<20200127154402.4008069-5-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200127154402.4008069-1-thomas@monjalon.net>", "References": "<20200116071656.1663967-1-thomas@monjalon.net>\n <20200127154402.4008069-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 4/4] net/mlx: workaround static linkage with\n\tmeson", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If ibverbs_link is static and the application choose to link DPDK\nas static libraries, both PMD and ibverbs libraries must be linked\nas static libraries. And the dependencies of ibverbs (netlink) must\nstill be linked as shared libraries.\n\nUnfortunately, meson forget about the static requirement for ibverbs\nwhen generating the .pc file.\nAs a result, libibverbs, libmlx4, libmlx5 are listed in Requires.private\nsection (allowing to be linked as shared libraries) and libnl is missing.\n\nA fix is in progress for meson, but anyway we will have to live without\nsuch a fix until a better version of meson is widely available:\n\thttps://github.com/mesonbuild/meson/pull/6393\n\nIn order to not allow meson suggesting shared libraries in the section\nRequires.private of the .pc file, the cflags are passed as hidden_deps.\nThe list of required dependencies is replaced with ldflags, forcing\nstatic flavor of ibverbs libraries thanks to this syntax:\n\t-l:libfoo.a\n\nFixes: 83fff714bd27 (\"net/mlx: add static ibverbs linkage with meson\")\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n buildtools/meson.build | 2 ++\n drivers/net/mlx4/meson.build | 14 ++++++++++++--\n drivers/net/mlx5/meson.build | 14 ++++++++++++--\n 3 files changed, 26 insertions(+), 4 deletions(-)", "diff": "diff --git a/buildtools/meson.build b/buildtools/meson.build\nindex cd1d054036..2a25527385 100644\n--- a/buildtools/meson.build\n+++ b/buildtools/meson.build\n@@ -7,6 +7,8 @@ pmdinfo = find_program('gen-pmdinfo-cfile.sh')\n \n check_experimental_syms = find_program('check-experimental-syms.sh')\n \n+ldflags_ibverbs_static = find_program('options-ibverbs-static.sh')\n+\n # set up map-to-def script using python, either built-in or external\n python3 = import('python').find_installation(required: false)\n if python3.found()\ndiff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build\nindex 51d9784ee2..724256bfb4 100644\n--- a/drivers/net/mlx4/meson.build\n+++ b/drivers/net/mlx4/meson.build\n@@ -30,16 +30,26 @@ foreach libname:libnames\n \t\tlib = cc.find_library(libname, required:false)\n \tendif\n \tif lib.found()\n-\t\tlibs += [ lib ]\n+\t\tlibs += lib\n+\t\tif static_ibverbs\n+\t\t\t# Build without adding shared libs to Requires.private\n+\t\t\thidden_deps += lib.partial_dependency(compile_args:true)\n+\t\telse\n+\t\t\text_deps += lib\n+\t\tendif\n \telse\n \t\tbuild = false\n \t\treason = 'missing dependency, \"' + libname + '\"'\n \tendif\n endforeach\n+if build and static_ibverbs\n+\t# Add static deps ldflags to internal apps and Libs.private\n+\tldflags = run_command(ldflags_ibverbs_static, check:true).stdout()\n+\text_deps += declare_dependency(link_args:ldflags.split())\n+endif\n \n if build\n \tallow_experimental_apis = true\n-\text_deps += libs\n \tsources = files(\n \t\t'mlx4.c',\n \t\t'mlx4_ethdev.c',\ndiff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build\nindex a4f2f79f22..e04c8947e0 100644\n--- a/drivers/net/mlx5/meson.build\n+++ b/drivers/net/mlx5/meson.build\n@@ -30,17 +30,27 @@ foreach libname:libnames\n \t\tlib = cc.find_library(libname, required:false)\n \tendif\n \tif lib.found()\n-\t\tlibs += [ lib ]\n+\t\tlibs += lib\n+\t\tif static_ibverbs\n+\t\t\t# Build without adding shared libs to Requires.private\n+\t\t\thidden_deps += lib.partial_dependency(compile_args:true)\n+\t\telse\n+\t\t\text_deps += lib\n+\t\tendif\n \telse\n \t\tbuild = false\n \t\treason = 'missing dependency, \"' + libname + '\"'\n \tendif\n endforeach\n+if build and static_ibverbs\n+\t# Add static deps ldflags to internal apps and Libs.private\n+\tldflags = run_command(ldflags_ibverbs_static, check:true).stdout()\n+\text_deps += declare_dependency(link_args:ldflags.split())\n+endif\n \n if build\n \tallow_experimental_apis = true\n \tdeps += ['hash']\n-\text_deps += libs\n \tsources = files(\n \t\t'mlx5.c',\n \t\t'mlx5_ethdev.c',\n", "prefixes": [ "v2", "4/4" ] }