Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65141/?format=api
{ "id": 65141, "url": "http://patches.dpdk.org/api/patches/65141/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1580121053-26083-2-git-send-email-hariprasad.govindharajan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1580121053-26083-2-git-send-email-hariprasad.govindharajan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1580121053-26083-2-git-send-email-hariprasad.govindharajan@intel.com", "date": "2020-01-27T10:30:52", "name": "[1/2] app/testpmd: add portlist option to the testpmd", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "263d07490f7ec3b85679ab9efc8224846094f278", "submitter": { "id": 1311, "url": "http://patches.dpdk.org/api/people/1311/?format=api", "name": "Hariprasad Govindharajan", "email": "hariprasad.govindharajan@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1580121053-26083-2-git-send-email-hariprasad.govindharajan@intel.com/mbox/", "series": [ { "id": 8303, "url": "http://patches.dpdk.org/api/series/8303/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8303", "date": "2020-01-27T10:30:51", "name": "app/testpmd: add portlist option to the testpmd", "version": 1, "mbox": "http://patches.dpdk.org/series/8303/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65141/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65141/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 90DD4A04B3;\n\tMon, 27 Jan 2020 11:31:11 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E724A1BF7B;\n\tMon, 27 Jan 2020 11:31:04 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 384291BF75\n for <dev@dpdk.org>; Mon, 27 Jan 2020 11:31:03 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 27 Jan 2020 02:31:02 -0800", "from silpixa00393944.ir.intel.com ([10.237.223.184])\n by orsmga008.jf.intel.com with ESMTP; 27 Jan 2020 02:31:01 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,369,1574150400\"; d=\"scan'208\";a=\"221694723\"", "From": "Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>", "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>", "Cc": "dev@dpdk.org,\n Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>", "Date": "Mon, 27 Jan 2020 10:30:52 +0000", "Message-Id": "\n <1580121053-26083-2-git-send-email-hariprasad.govindharajan@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "\n <1580121053-26083-1-git-send-email-hariprasad.govindharajan@intel.com>", "References": "\n <1580121053-26083-1-git-send-email-hariprasad.govindharajan@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/2] app/testpmd: add portlist option to the\n\ttestpmd", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In current version, we are setting the ports\n using portmask. With portmask, we can use only\n upto 64 ports. This portlist option enables the user\n to use more than 64 ports.\n Now we can specify the ports in 2 different ways\n - Using portmask (-p [0x]nnn): mask must be in hex format\n - Using portlist in the following format\n --portlist <p1>[-p2][,p3[-p4],...]\n\n --portmask 0x2 is same as --portlist 1\n --portmask 0x3 is same as --portlist 0-1\n\nSigned-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>\n---\n app/test-pmd/config.c | 25 +++++++++++++++++++++++++\n app/test-pmd/parameters.c | 5 +++++\n app/test-pmd/testpmd.h | 3 +++\n 3 files changed, 33 insertions(+)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 9669cbd..49662cf 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -2588,6 +2588,31 @@ set_fwd_ports_list(unsigned int *portlist, unsigned int nb_pt)\n }\n \n void\n+parse_fwd_portlist(const char *portlist)\n+{\n+\tunsigned int portcount = 0;\n+\tint portindex[RTE_MAX_ETHPORTS];\n+\tunsigned int ports[RTE_MAX_ETHPORTS];\n+\tunsigned int idx;\n+\t/*\n+\t * eal_parse_portlist() will mark the portindex array\n+\t * with -1 if the port is not listed and with a positive value\n+\t * for the listed ports. however, the function set_fwd_ports_list()\n+\t * requires a list of portids' so we use 2 arrays to do the\n+\t * conversion between 2 formats.\n+\t */\n+\tif (eal_parse_optionlist(portlist, portindex, RTE_MAX_ETHPORTS) < 0)\n+\t\trte_exit(EXIT_FAILURE, \"Invalid fwd port list\\n\");\n+\n+\tRTE_ETH_FOREACH_DEV(idx) {\n+\t\tif (portindex[idx] != -1)\n+\t\t\tports[portcount++] = idx;\n+\t}\n+\n+\tset_fwd_ports_list(ports, portcount);\n+}\n+\n+void\n set_fwd_ports_mask(uint64_t portmask)\n {\n \tunsigned int portlist[64];\ndiff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex 6340104..404dba2 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -57,6 +57,7 @@ usage(char* progname)\n \t \"[--help|-h] | [--auto-start|-a] | [\"\n \t \"--tx-first | --stats-period=PERIOD | \"\n \t \"--coremask=COREMASK --portmask=PORTMASK --numa \"\n+\t \"--portlist=PORTLIST \"\n \t \"--mbuf-size= | --total-num-mbufs= | \"\n \t \"--nb-cores= | --nb-ports= | \"\n #ifdef RTE_LIBRTE_CMDLINE\n@@ -92,6 +93,7 @@ usage(char* progname)\n \t \"packet forwarding.\\n\");\n \tprintf(\" --portmask=PORTMASK: hexadecimal bitmask of ports used \"\n \t \"by the packet forwarding test.\\n\");\n+\tprintf(\" --portlist=PORTLIST: list of forwarding ports\\n\");\n \tprintf(\" --numa: enable NUMA-aware allocation of RX/TX rings and of \"\n \t \"RX memory buffers (mbufs).\\n\");\n \tprintf(\" --port-numa-config=(port,socket)[,(port,socket)]: \"\n@@ -587,6 +589,7 @@ launch_args_parse(int argc, char** argv)\n \t\t{ \"nb-ports\",\t\t\t1, 0, 0 },\n \t\t{ \"coremask\",\t\t\t1, 0, 0 },\n \t\t{ \"portmask\",\t\t\t1, 0, 0 },\n+\t\t{ \"portlist\",\t\t\t1, 0, 0 },\n \t\t{ \"numa\",\t\t\t0, 0, 0 },\n \t\t{ \"no-numa\",\t\t\t0, 0, 0 },\n \t\t{ \"mp-anon\",\t\t\t0, 0, 0 },\n@@ -825,6 +828,8 @@ launch_args_parse(int argc, char** argv)\n \t\t\t\tparse_fwd_coremask(optarg);\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"portmask\"))\n \t\t\t\tparse_fwd_portmask(optarg);\n+\t\t\tif (!strcmp(lgopts[opt_idx].name, \"portlist\"))\n+\t\t\t\tparse_fwd_portlist(optarg);\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"no-numa\"))\n \t\t\t\tnuma_support = 0;\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"numa\"))\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 3dd5fc7..33ef3e2 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -614,6 +614,9 @@ lcore_num(void)\n \trte_panic(\"lcore_id of current thread not found in fwd_lcores_cpuids\\n\");\n }\n \n+void\n+parse_fwd_portlist(const char *port);\n+\n static inline struct fwd_lcore *\n current_fwd_lcore(void)\n {\n", "prefixes": [ "1/2" ] }