Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64685/?format=api
{ "id": 64685, "url": "http://patches.dpdk.org/api/patches/64685/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200115005028.21026-3-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200115005028.21026-3-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200115005028.21026-3-haiyue.wang@intel.com", "date": "2020-01-15T00:50:26", "name": "[v3,2/4] net/ice: unify the bool type value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b6cd3e189590e63d6b622961ec1a5ff836e84707", "submitter": { "id": 1044, "url": "http://patches.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200115005028.21026-3-haiyue.wang@intel.com/mbox/", "series": [ { "id": 8127, "url": "http://patches.dpdk.org/api/series/8127/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8127", "date": "2020-01-15T00:50:24", "name": "Intel iavf and ice PMDs clean up", "version": 3, "mbox": "http://patches.dpdk.org/series/8127/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64685/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64685/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C4B59A04FD;\n\tWed, 15 Jan 2020 01:57:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7C4E11C0DB;\n\tWed, 15 Jan 2020 01:57:35 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 040681C0C9\n for <dev@dpdk.org>; Wed, 15 Jan 2020 01:57:28 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2020 16:57:28 -0800", "from npg-dpdk-haiyue-1.sh.intel.com ([10.67.119.213])\n by fmsmga006.fm.intel.com with ESMTP; 14 Jan 2020 16:57:27 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,320,1574150400\"; d=\"scan'208\";a=\"424844008\"", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org, xiaolong.ye@intel.com, qi.z.zhang@intel.com,\n qiming.yang@intel.com", "Cc": "Haiyue Wang <haiyue.wang@intel.com>", "Date": "Wed, 15 Jan 2020 08:50:26 +0800", "Message-Id": "<20200115005028.21026-3-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200115005028.21026-1-haiyue.wang@intel.com>", "References": "<20200115005028.21026-1-haiyue.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 2/4] net/ice: unify the bool type value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replaces the redefined TRUE and FALSE values with standard ones to\nmatch the 'bool' type definition.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\nAcked-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 22 +++++++++++-----------\n drivers/net/ice/ice_rxtx.c | 16 ++++++++--------\n 2 files changed, 19 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex f99eb4e1b..8e9369e0a 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -1720,7 +1720,7 @@ ice_pf_setup(struct ice_pf *pf)\n \tuint16_t unused;\n \n \t/* Clear all stats counters */\n-\tpf->offset_loaded = FALSE;\n+\tpf->offset_loaded = false;\n \tmemset(&pf->stats, 0, sizeof(struct ice_hw_port_stats));\n \tmemset(&pf->stats_offset, 0, sizeof(struct ice_hw_port_stats));\n \tmemset(&pf->internal_stats, 0, sizeof(struct ice_eth_stats));\n@@ -2234,16 +2234,16 @@ ice_dev_init(struct rte_eth_dev *dev)\n \tvsi = pf->main_vsi;\n \n \t/* Disable double vlan by default */\n-\tice_vsi_config_double_vlan(vsi, FALSE);\n+\tice_vsi_config_double_vlan(vsi, false);\n \n-\tret = ice_aq_stop_lldp(hw, TRUE, FALSE, NULL);\n+\tret = ice_aq_stop_lldp(hw, true, false, NULL);\n \tif (ret != ICE_SUCCESS)\n \t\tPMD_INIT_LOG(DEBUG, \"lldp has already stopped\\n\");\n-\tret = ice_init_dcb(hw, TRUE);\n+\tret = ice_init_dcb(hw, true);\n \tif (ret != ICE_SUCCESS)\n \t\tPMD_INIT_LOG(DEBUG, \"Failed to init DCB\\n\");\n \t/* Forward LLDP packets to default VSI */\n-\tret = ice_vsi_config_sw_lldp(vsi, TRUE);\n+\tret = ice_vsi_config_sw_lldp(vsi, true);\n \tif (ret != ICE_SUCCESS)\n \t\tPMD_INIT_LOG(DEBUG, \"Failed to cfg lldp\\n\");\n \t/* register callback func to eal lib */\n@@ -3449,23 +3449,23 @@ ice_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \trxmode = &dev->data->dev_conf.rxmode;\n \tif (mask & ETH_VLAN_FILTER_MASK) {\n \t\tif (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER)\n-\t\t\tice_vsi_config_vlan_filter(vsi, TRUE);\n+\t\t\tice_vsi_config_vlan_filter(vsi, true);\n \t\telse\n-\t\t\tice_vsi_config_vlan_filter(vsi, FALSE);\n+\t\t\tice_vsi_config_vlan_filter(vsi, false);\n \t}\n \n \tif (mask & ETH_VLAN_STRIP_MASK) {\n \t\tif (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP)\n-\t\t\tice_vsi_config_vlan_stripping(vsi, TRUE);\n+\t\t\tice_vsi_config_vlan_stripping(vsi, true);\n \t\telse\n-\t\t\tice_vsi_config_vlan_stripping(vsi, FALSE);\n+\t\t\tice_vsi_config_vlan_stripping(vsi, false);\n \t}\n \n \tif (mask & ETH_VLAN_EXTEND_MASK) {\n \t\tif (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND)\n-\t\t\tice_vsi_config_double_vlan(vsi, TRUE);\n+\t\t\tice_vsi_config_double_vlan(vsi, true);\n \t\telse\n-\t\t\tice_vsi_config_double_vlan(vsi, FALSE);\n+\t\t\tice_vsi_config_double_vlan(vsi, false);\n \t}\n \n \treturn 0;\ndiff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex ce499af43..ad3cb9c46 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -424,7 +424,7 @@ ice_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t/* Init the RX tail register. */\n \tICE_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1);\n \n-\terr = ice_switch_rx_queue(hw, rxq->reg_idx, TRUE);\n+\terr = ice_switch_rx_queue(hw, rxq->reg_idx, true);\n \tif (err) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to switch RX queue %u on\",\n \t\t\t rx_queue_id);\n@@ -450,7 +450,7 @@ ice_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \tif (rx_queue_id < dev->data->nb_rx_queues) {\n \t\trxq = dev->data->rx_queues[rx_queue_id];\n \n-\t\terr = ice_switch_rx_queue(hw, rxq->reg_idx, FALSE);\n+\t\terr = ice_switch_rx_queue(hw, rxq->reg_idx, false);\n \t\tif (err) {\n \t\t\tPMD_DRV_LOG(ERR, \"Failed to switch RX queue %u off\",\n \t\t\t\t rx_queue_id);\n@@ -630,7 +630,7 @@ ice_fdir_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t/* Init the RX tail register. */\n \tICE_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1);\n \n-\terr = ice_switch_rx_queue(hw, rxq->reg_idx, TRUE);\n+\terr = ice_switch_rx_queue(hw, rxq->reg_idx, true);\n \tif (err) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to switch FDIR RX queue %u on\",\n \t\t\t rx_queue_id);\n@@ -816,7 +816,7 @@ ice_fdir_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \n \trxq = pf->fdir.rxq;\n \n-\terr = ice_switch_rx_queue(hw, rxq->reg_idx, FALSE);\n+\terr = ice_switch_rx_queue(hw, rxq->reg_idx, false);\n \tif (err) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to switch FDIR RX queue %u off\",\n \t\t\t rx_queue_id);\n@@ -973,7 +973,7 @@ ice_rx_queue_setup(struct rte_eth_dev *dev,\n \t}\n \n \tice_reset_rx_queue(rxq);\n-\trxq->q_set = TRUE;\n+\trxq->q_set = true;\n \tdev->data->rx_queues[queue_idx] = rxq;\n \trxq->rx_rel_mbufs = _ice_rx_queue_release_mbufs;\n \n@@ -1186,7 +1186,7 @@ ice_tx_queue_setup(struct rte_eth_dev *dev,\n \t}\n \n \tice_reset_tx_queue(txq);\n-\ttxq->q_set = TRUE;\n+\ttxq->q_set = true;\n \tdev->data->tx_queues[queue_idx] = txq;\n \ttxq->tx_rel_mbufs = _ice_tx_queue_release_mbufs;\n \tice_set_tx_function_flag(dev, txq);\n@@ -2043,7 +2043,7 @@ ice_fdir_setup_tx_resources(struct ice_pf *pf)\n \t * don't need to allocate software ring and reset for the fdir\n \t * program queue just set the queue has been configured.\n \t */\n-\ttxq->q_set = TRUE;\n+\ttxq->q_set = true;\n \tpf->fdir.txq = txq;\n \n \ttxq->tx_rel_mbufs = _ice_tx_queue_release_mbufs;\n@@ -2104,7 +2104,7 @@ ice_fdir_setup_rx_resources(struct ice_pf *pf)\n \t * Don't need to allocate software ring and reset for the fdir\n \t * rx queue, just set the queue has been configured.\n \t */\n-\trxq->q_set = TRUE;\n+\trxq->q_set = true;\n \tpf->fdir.rxq = rxq;\n \n \trxq->rx_rel_mbufs = _ice_rx_queue_release_mbufs;\n", "prefixes": [ "v3", "2/4" ] }