Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64684/?format=api
{ "id": 64684, "url": "http://patches.dpdk.org/api/patches/64684/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200115005028.21026-2-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200115005028.21026-2-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200115005028.21026-2-haiyue.wang@intel.com", "date": "2020-01-15T00:50:25", "name": "[v3,1/4] net/iavf: unify the bool type value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c2ec3aa615fc9b948256c3cc9d20f6514374bd33", "submitter": { "id": 1044, "url": "http://patches.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200115005028.21026-2-haiyue.wang@intel.com/mbox/", "series": [ { "id": 8127, "url": "http://patches.dpdk.org/api/series/8127/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8127", "date": "2020-01-15T00:50:24", "name": "Intel iavf and ice PMDs clean up", "version": 3, "mbox": "http://patches.dpdk.org/series/8127/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64684/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64684/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 553BFA04FD;\n\tWed, 15 Jan 2020 01:57:36 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 29FE01C0D8;\n\tWed, 15 Jan 2020 01:57:32 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 242231C0C9\n for <dev@dpdk.org>; Wed, 15 Jan 2020 01:57:27 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2020 16:57:27 -0800", "from npg-dpdk-haiyue-1.sh.intel.com ([10.67.119.213])\n by fmsmga006.fm.intel.com with ESMTP; 14 Jan 2020 16:57:26 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,320,1574150400\"; d=\"scan'208\";a=\"424844001\"", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org, xiaolong.ye@intel.com, qi.z.zhang@intel.com,\n qiming.yang@intel.com", "Cc": "Haiyue Wang <haiyue.wang@intel.com>", "Date": "Wed, 15 Jan 2020 08:50:25 +0800", "Message-Id": "<20200115005028.21026-2-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200115005028.21026-1-haiyue.wang@intel.com>", "References": "<20200115005028.21026-1-haiyue.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 1/4] net/iavf: unify the bool type value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replaces the redefined TRUE and FALSE values with standard ones to\nmatch the 'bool' type definition.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\nAcked-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 31 ++++++++++++++++---------------\n drivers/net/iavf/iavf_rxtx.c | 34 +++++++++++++++++-----------------\n 2 files changed, 33 insertions(+), 32 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex f69c50df5..34913f9c4 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -454,7 +454,7 @@ iavf_dev_start(struct rte_eth_dev *dev)\n \t}\n \n \t/* Set all mac addrs */\n-\tiavf_add_del_all_mac_addr(adapter, TRUE);\n+\tiavf_add_del_all_mac_addr(adapter, true);\n \n \tif (iavf_start_queues(dev) != 0) {\n \t\tPMD_DRV_LOG(ERR, \"enable queues failed\");\n@@ -464,7 +464,7 @@ iavf_dev_start(struct rte_eth_dev *dev)\n \treturn 0;\n \n err_mac:\n-\tiavf_add_del_all_mac_addr(adapter, FALSE);\n+\tiavf_add_del_all_mac_addr(adapter, false);\n err_queue:\n err_rss:\n \treturn -1;\n@@ -493,7 +493,7 @@ iavf_dev_stop(struct rte_eth_dev *dev)\n \t}\n \n \t/* remove all mac addrs */\n-\tiavf_add_del_all_mac_addr(adapter, FALSE);\n+\tiavf_add_del_all_mac_addr(adapter, false);\n \tadapter->stopped = 1;\n }\n \n@@ -648,9 +648,9 @@ iavf_dev_promiscuous_enable(struct rte_eth_dev *dev)\n \tif (vf->promisc_unicast_enabled)\n \t\treturn 0;\n \n-\tret = iavf_config_promisc(adapter, TRUE, vf->promisc_multicast_enabled);\n+\tret = iavf_config_promisc(adapter, true, vf->promisc_multicast_enabled);\n \tif (!ret)\n-\t\tvf->promisc_unicast_enabled = TRUE;\n+\t\tvf->promisc_unicast_enabled = true;\n \telse\n \t\tret = -EAGAIN;\n \n@@ -668,9 +668,10 @@ iavf_dev_promiscuous_disable(struct rte_eth_dev *dev)\n \tif (!vf->promisc_unicast_enabled)\n \t\treturn 0;\n \n-\tret = iavf_config_promisc(adapter, FALSE, vf->promisc_multicast_enabled);\n+\tret = iavf_config_promisc(adapter, false,\n+\t\t\t\t vf->promisc_multicast_enabled);\n \tif (!ret)\n-\t\tvf->promisc_unicast_enabled = FALSE;\n+\t\tvf->promisc_unicast_enabled = false;\n \telse\n \t\tret = -EAGAIN;\n \n@@ -688,9 +689,9 @@ iavf_dev_allmulticast_enable(struct rte_eth_dev *dev)\n \tif (vf->promisc_multicast_enabled)\n \t\treturn 0;\n \n-\tret = iavf_config_promisc(adapter, vf->promisc_unicast_enabled, TRUE);\n+\tret = iavf_config_promisc(adapter, vf->promisc_unicast_enabled, true);\n \tif (!ret)\n-\t\tvf->promisc_multicast_enabled = TRUE;\n+\t\tvf->promisc_multicast_enabled = true;\n \telse\n \t\tret = -EAGAIN;\n \n@@ -708,9 +709,9 @@ iavf_dev_allmulticast_disable(struct rte_eth_dev *dev)\n \tif (!vf->promisc_multicast_enabled)\n \t\treturn 0;\n \n-\tret = iavf_config_promisc(adapter, vf->promisc_unicast_enabled, FALSE);\n+\tret = iavf_config_promisc(adapter, vf->promisc_unicast_enabled, false);\n \tif (!ret)\n-\t\tvf->promisc_multicast_enabled = FALSE;\n+\t\tvf->promisc_multicast_enabled = false;\n \telse\n \t\tret = -EAGAIN;\n \n@@ -732,7 +733,7 @@ iavf_dev_add_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *addr,\n \t\treturn -EINVAL;\n \t}\n \n-\terr = iavf_add_del_eth_addr(adapter, addr, TRUE);\n+\terr = iavf_add_del_eth_addr(adapter, addr, true);\n \tif (err) {\n \t\tPMD_DRV_LOG(ERR, \"fail to add MAC address\");\n \t\treturn -EIO;\n@@ -754,7 +755,7 @@ iavf_dev_del_mac_addr(struct rte_eth_dev *dev, uint32_t index)\n \n \taddr = &dev->data->mac_addrs[index];\n \n-\terr = iavf_add_del_eth_addr(adapter, addr, FALSE);\n+\terr = iavf_add_del_eth_addr(adapter, addr, false);\n \tif (err)\n \t\tPMD_DRV_LOG(ERR, \"fail to delete MAC address\");\n \n@@ -979,7 +980,7 @@ iavf_dev_set_default_mac_addr(struct rte_eth_dev *dev,\n \tif (rte_is_valid_assigned_ether_addr(perm_addr))\n \t\treturn -EPERM;\n \n-\tret = iavf_add_del_eth_addr(adapter, old_addr, FALSE);\n+\tret = iavf_add_del_eth_addr(adapter, old_addr, false);\n \tif (ret)\n \t\tPMD_DRV_LOG(ERR, \"Fail to delete old MAC:\"\n \t\t\t \" %02X:%02X:%02X:%02X:%02X:%02X\",\n@@ -990,7 +991,7 @@ iavf_dev_set_default_mac_addr(struct rte_eth_dev *dev,\n \t\t\t old_addr->addr_bytes[4],\n \t\t\t old_addr->addr_bytes[5]);\n \n-\tret = iavf_add_del_eth_addr(adapter, mac_addr, TRUE);\n+\tret = iavf_add_del_eth_addr(adapter, mac_addr, true);\n \tif (ret)\n \t\tPMD_DRV_LOG(ERR, \"Fail to add new MAC:\"\n \t\t\t \" %02X:%02X:%02X:%02X:%02X:%02X\",\ndiff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c\nindex 067290db4..85d9a8e3b 100644\n--- a/drivers/net/iavf/iavf_rxtx.c\n+++ b/drivers/net/iavf/iavf_rxtx.c\n@@ -95,11 +95,11 @@ check_rx_vec_allow(struct iavf_rx_queue *rxq)\n \tif (rxq->rx_free_thresh >= IAVF_VPMD_RX_MAX_BURST &&\n \t rxq->nb_rx_desc % rxq->rx_free_thresh == 0) {\n \t\tPMD_INIT_LOG(DEBUG, \"Vector Rx can be enabled on this rxq.\");\n-\t\treturn TRUE;\n+\t\treturn true;\n \t}\n \n \tPMD_INIT_LOG(DEBUG, \"Vector Rx cannot be enabled on this rxq.\");\n-\treturn FALSE;\n+\treturn false;\n }\n \n static inline bool\n@@ -109,29 +109,29 @@ check_tx_vec_allow(struct iavf_tx_queue *txq)\n \t txq->rs_thresh >= IAVF_VPMD_TX_MAX_BURST &&\n \t txq->rs_thresh <= IAVF_VPMD_TX_MAX_FREE_BUF) {\n \t\tPMD_INIT_LOG(DEBUG, \"Vector tx can be enabled on this txq.\");\n-\t\treturn TRUE;\n+\t\treturn true;\n \t}\n \tPMD_INIT_LOG(DEBUG, \"Vector Tx cannot be enabled on this txq.\");\n-\treturn FALSE;\n+\treturn false;\n }\n \n static inline bool\n check_rx_bulk_allow(struct iavf_rx_queue *rxq)\n {\n-\tint ret = TRUE;\n+\tint ret = true;\n \n \tif (!(rxq->rx_free_thresh >= IAVF_RX_MAX_BURST)) {\n \t\tPMD_INIT_LOG(DEBUG, \"Rx Burst Bulk Alloc Preconditions: \"\n \t\t\t \"rxq->rx_free_thresh=%d, \"\n \t\t\t \"IAVF_RX_MAX_BURST=%d\",\n \t\t\t rxq->rx_free_thresh, IAVF_RX_MAX_BURST);\n-\t\tret = FALSE;\n+\t\tret = false;\n \t} else if (rxq->nb_rx_desc % rxq->rx_free_thresh != 0) {\n \t\tPMD_INIT_LOG(DEBUG, \"Rx Burst Bulk Alloc Preconditions: \"\n \t\t\t \"rxq->nb_rx_desc=%d, \"\n \t\t\t \"rxq->rx_free_thresh=%d\",\n \t\t\t rxq->nb_rx_desc, rxq->rx_free_thresh);\n-\t\tret = FALSE;\n+\t\tret = false;\n \t}\n \treturn ret;\n }\n@@ -390,12 +390,12 @@ iavf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \n \trxq->mz = mz;\n \treset_rx_queue(rxq);\n-\trxq->q_set = TRUE;\n+\trxq->q_set = true;\n \tdev->data->rx_queues[queue_idx] = rxq;\n \trxq->qrx_tail = hw->hw_addr + IAVF_QRX_TAIL1(rxq->queue_id);\n \trxq->ops = &def_rxq_ops;\n \n-\tif (check_rx_bulk_allow(rxq) == TRUE) {\n+\tif (check_rx_bulk_allow(rxq) == true) {\n \t\tPMD_INIT_LOG(DEBUG, \"Rx Burst Bulk Alloc Preconditions are \"\n \t\t\t \"satisfied. Rx Burst Bulk Alloc function will be \"\n \t\t\t \"used on port=%d, queue=%d.\",\n@@ -408,7 +408,7 @@ iavf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\tad->rx_bulk_alloc_allowed = false;\n \t}\n \n-\tif (check_rx_vec_allow(rxq) == FALSE)\n+\tif (check_rx_vec_allow(rxq) == false)\n \t\tad->rx_vec_allowed = false;\n \n \treturn 0;\n@@ -500,12 +500,12 @@ iavf_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \n \ttxq->mz = mz;\n \treset_tx_queue(txq);\n-\ttxq->q_set = TRUE;\n+\ttxq->q_set = true;\n \tdev->data->tx_queues[queue_idx] = txq;\n \ttxq->qtx_tail = hw->hw_addr + IAVF_QTX_TAIL1(queue_idx);\n \ttxq->ops = &def_txq_ops;\n \n-\tif (check_tx_vec_allow(txq) == FALSE) {\n+\tif (check_tx_vec_allow(txq) == false) {\n \t\tstruct iavf_adapter *ad =\n \t\t\tIAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \t\tad->tx_vec_allowed = false;\n@@ -543,7 +543,7 @@ iavf_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \tIAVF_WRITE_FLUSH(hw);\n \n \t/* Ready to switch the queue on */\n-\terr = iavf_switch_queue(adapter, rx_queue_id, TRUE, TRUE);\n+\terr = iavf_switch_queue(adapter, rx_queue_id, true, true);\n \tif (err)\n \t\tPMD_DRV_LOG(ERR, \"Failed to switch RX queue %u on\",\n \t\t\t rx_queue_id);\n@@ -575,7 +575,7 @@ iavf_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \tIAVF_WRITE_FLUSH(hw);\n \n \t/* Ready to switch the queue on */\n-\terr = iavf_switch_queue(adapter, tx_queue_id, FALSE, TRUE);\n+\terr = iavf_switch_queue(adapter, tx_queue_id, false, true);\n \n \tif (err)\n \t\tPMD_DRV_LOG(ERR, \"Failed to switch TX queue %u on\",\n@@ -600,7 +600,7 @@ iavf_dev_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \tif (rx_queue_id >= dev->data->nb_rx_queues)\n \t\treturn -EINVAL;\n \n-\terr = iavf_switch_queue(adapter, rx_queue_id, TRUE, FALSE);\n+\terr = iavf_switch_queue(adapter, rx_queue_id, true, false);\n \tif (err) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to switch RX queue %u off\",\n \t\t\t rx_queue_id);\n@@ -628,7 +628,7 @@ iavf_dev_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \tif (tx_queue_id >= dev->data->nb_tx_queues)\n \t\treturn -EINVAL;\n \n-\terr = iavf_switch_queue(adapter, tx_queue_id, FALSE, FALSE);\n+\terr = iavf_switch_queue(adapter, tx_queue_id, false, false);\n \tif (err) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to switch TX queue %u off\",\n \t\t\t tx_queue_id);\n@@ -1815,7 +1815,7 @@ iavf_dev_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \tqinfo->nb_desc = rxq->nb_rx_desc;\n \n \tqinfo->conf.rx_free_thresh = rxq->rx_free_thresh;\n-\tqinfo->conf.rx_drop_en = TRUE;\n+\tqinfo->conf.rx_drop_en = true;\n \tqinfo->conf.rx_deferred_start = rxq->rx_deferred_start;\n }\n \n", "prefixes": [ "v3", "1/4" ] }