Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64673/?format=api
{ "id": 64673, "url": "http://patches.dpdk.org/api/patches/64673/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1579012036-326214-3-git-send-email-vladimir.medvedkin@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1579012036-326214-3-git-send-email-vladimir.medvedkin@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1579012036-326214-3-git-send-email-vladimir.medvedkin@intel.com", "date": "2020-01-14T14:27:13", "name": "[v4,2/5] examples/ipsec-secgw: implement inbound SAD", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "39b84098fede65d547fd93f687cc08ae9ba2e318", "submitter": { "id": 1216, "url": "http://patches.dpdk.org/api/people/1216/?format=api", "name": "Vladimir Medvedkin", "email": "vladimir.medvedkin@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1579012036-326214-3-git-send-email-vladimir.medvedkin@intel.com/mbox/", "series": [ { "id": 8120, "url": "http://patches.dpdk.org/api/series/8120/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8120", "date": "2020-01-14T14:27:11", "name": "integrate librte_ipsec SAD into ipsec-secgw", "version": 4, "mbox": "http://patches.dpdk.org/series/8120/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64673/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64673/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E3BD5A04FF;\n\tTue, 14 Jan 2020 15:27:34 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 498071C1CC;\n\tTue, 14 Jan 2020 15:27:27 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 1E3161C1BC\n for <dev@dpdk.org>; Tue, 14 Jan 2020 15:27:21 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2020 06:27:21 -0800", "from silpixa00400072.ir.intel.com ([10.237.222.213])\n by fmsmga002.fm.intel.com with ESMTP; 14 Jan 2020 06:27:20 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,433,1571727600\"; d=\"scan'208\";a=\"256316516\"", "From": "Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "To": "dev@dpdk.org", "Cc": "konstantin.ananyev@intel.com,\n\takhil.goyal@nxp.com", "Date": "Tue, 14 Jan 2020 14:27:13 +0000", "Message-Id": "<1579012036-326214-3-git-send-email-vladimir.medvedkin@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": [ "<1579012036-326214-1-git-send-email-vladimir.medvedkin@intel.com>", "<1578920122-228017-1-git-send-email-vladimir.medvedkin@intel.com>" ], "References": [ "<1579012036-326214-1-git-send-email-vladimir.medvedkin@intel.com>", "<1578920122-228017-1-git-send-email-vladimir.medvedkin@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v4 2/5] examples/ipsec-secgw: implement inbound\n\tSAD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add initial support for librte_ipsec SAD library\n\nSigned-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>\n---\n examples/ipsec-secgw/ipsec.h | 7 ++++\n examples/ipsec-secgw/sad.c | 90 ++++++++++++++++++++++++++++++++++++++++++++\n examples/ipsec-secgw/sad.h | 74 ++++++++++++++++++++++++++++++++++++\n 3 files changed, 171 insertions(+)\n create mode 100644 examples/ipsec-secgw/sad.c\n create mode 100644 examples/ipsec-secgw/sad.h", "diff": "diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h\nindex 8e07521..9ddb5d9 100644\n--- a/examples/ipsec-secgw/ipsec.h\n+++ b/examples/ipsec-secgw/ipsec.h\n@@ -53,6 +53,13 @@ struct ipsec_xform;\n struct rte_mbuf;\n \n struct ipsec_sa;\n+/*\n+ * Keeps number of configured SA's for each address family:\n+ */\n+struct ipsec_sa_cnt {\n+\tuint32_t\tnb_v4;\n+\tuint32_t\tnb_v6;\n+};\n \n typedef int32_t (*ipsec_xform_fn)(struct rte_mbuf *m, struct ipsec_sa *sa,\n \t\tstruct rte_crypto_op *cop);\ndiff --git a/examples/ipsec-secgw/sad.c b/examples/ipsec-secgw/sad.c\nnew file mode 100644\nindex 0000000..a193172\n--- /dev/null\n+++ b/examples/ipsec-secgw/sad.c\n@@ -0,0 +1,90 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2019 Intel Corporation\n+ */\n+\n+#include <rte_errno.h>\n+\n+#include \"ipsec.h\"\n+#include \"sad.h\"\n+\n+int\n+ipsec_sad_add(struct ipsec_sad *sad, struct ipsec_sa *sa)\n+{\n+\tint ret;\n+\tunion rte_ipsec_sad_key key = { {0} };\n+\n+\t/* spi field is common for ipv4 and ipv6 key types */\n+\tkey.v4.spi = rte_cpu_to_be_32(sa->spi);\n+\tswitch (WITHOUT_TRANSPORT_VERSION(sa->flags)) {\n+\tcase IP4_TUNNEL:\n+\t\tret = rte_ipsec_sad_add(sad->sad_v4, &key,\n+\t\t\tRTE_IPSEC_SAD_SPI_ONLY, sa);\n+\t\tif (ret != 0)\n+\t\t\treturn ret;\n+\t\tbreak;\n+\tcase IP6_TUNNEL:\n+\t\tret = rte_ipsec_sad_add(sad->sad_v6, &key,\n+\t\t\tRTE_IPSEC_SAD_SPI_ONLY, sa);\n+\t\tif (ret != 0)\n+\t\t\treturn ret;\n+\t\tbreak;\n+\tcase TRANSPORT:\n+\t\tif (sp4_spi_present(sa->spi, 1, NULL, NULL) >= 0) {\n+\t\t\tret = rte_ipsec_sad_add(sad->sad_v4, &key,\n+\t\t\t\tRTE_IPSEC_SAD_SPI_ONLY, sa);\n+\t\t\tif (ret != 0)\n+\t\t\t\treturn ret;\n+\t\t}\n+\t\tif (sp6_spi_present(sa->spi, 1, NULL, NULL) >= 0) {\n+\t\t\tret = rte_ipsec_sad_add(sad->sad_v6, &key,\n+\t\t\t\tRTE_IPSEC_SAD_SPI_ONLY, sa);\n+\t\t\tif (ret != 0)\n+\t\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n+int\n+ipsec_sad_create(const char *name, struct ipsec_sad *sad,\n+\tint socket_id, struct ipsec_sa_cnt *sa_cnt)\n+{\n+\tint ret;\n+\tstruct rte_ipsec_sad_conf sad_conf;\n+\tchar sad_name[RTE_IPSEC_SAD_NAMESIZE];\n+\n+\tif ((name == NULL) || (sad == NULL) || (sa_cnt == NULL))\n+\t\treturn -EINVAL;\n+\n+\tret = snprintf(sad_name, RTE_IPSEC_SAD_NAMESIZE, \"%s_v4\", name);\n+\tif (ret < 0 || ret >= RTE_IPSEC_SAD_NAMESIZE)\n+\t\treturn -ENAMETOOLONG;\n+\n+\tsad_conf.socket_id = socket_id;\n+\tsad_conf.flags = 0;\n+\t/* Make SAD have extra 25% of required number of entries */\n+\tsad_conf.max_sa[RTE_IPSEC_SAD_SPI_ONLY] = sa_cnt->nb_v4 * 5 / 4;\n+\tsad_conf.max_sa[RTE_IPSEC_SAD_SPI_DIP] = 0;\n+\tsad_conf.max_sa[RTE_IPSEC_SAD_SPI_DIP_SIP] = 0;\n+\n+\tif (sa_cnt->nb_v4 != 0) {\n+\t\tsad->sad_v4 = rte_ipsec_sad_create(sad_name, &sad_conf);\n+\t\tif (sad->sad_v4 == NULL)\n+\t\t\treturn -rte_errno;\n+\t}\n+\n+\tret = snprintf(sad_name, RTE_IPSEC_SAD_NAMESIZE, \"%s_v6\", name);\n+\tif (ret < 0 || ret >= RTE_IPSEC_SAD_NAMESIZE)\n+\t\treturn -ENAMETOOLONG;\n+\tsad_conf.flags = RTE_IPSEC_SAD_FLAG_IPV6;\n+\tsad_conf.max_sa[RTE_IPSEC_SAD_SPI_ONLY] = sa_cnt->nb_v6 * 5 / 4;\n+\n+\tif (sa_cnt->nb_v6 != 0) {\n+\t\tsad->sad_v6 = rte_ipsec_sad_create(name, &sad_conf);\n+\t\tif (sad->sad_v6 == NULL)\n+\t\t\treturn -rte_errno;\n+\t}\n+\n+\treturn 0;\n+}\ndiff --git a/examples/ipsec-secgw/sad.h b/examples/ipsec-secgw/sad.h\nnew file mode 100644\nindex 0000000..e754d57\n--- /dev/null\n+++ b/examples/ipsec-secgw/sad.h\n@@ -0,0 +1,74 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2019 Intel Corporation\n+ */\n+\n+#ifndef __SAD_H__\n+#define __SAD_H__\n+\n+#include <rte_ipsec_sad.h>\n+\n+struct ipsec_sad {\n+\tstruct rte_ipsec_sad *sad_v4;\n+\tstruct rte_ipsec_sad *sad_v6;\n+};\n+\n+int ipsec_sad_create(const char *name, struct ipsec_sad *sad,\n+\tint socket_id, struct ipsec_sa_cnt *sa_cnt);\n+\n+int ipsec_sad_add(struct ipsec_sad *sad, struct ipsec_sa *sa);\n+\n+static inline void\n+sad_lookup(const struct ipsec_sad *sad, struct rte_mbuf *pkts[],\n+\tvoid *sa[], uint16_t nb_pkts)\n+{\n+\tuint32_t i;\n+\tuint32_t nb_v4 = 0, nb_v6 = 0;\n+\tstruct rte_esp_hdr *esp;\n+\tstruct rte_ipv4_hdr *ipv4;\n+\tstruct rte_ipv6_hdr *ipv6;\n+\tstruct rte_ipsec_sadv4_key\tv4[nb_pkts];\n+\tstruct rte_ipsec_sadv6_key\tv6[nb_pkts];\n+\tint v4_idxes[nb_pkts];\n+\tint v6_idxes[nb_pkts];\n+\tconst union rte_ipsec_sad_key\t*keys_v4[nb_pkts];\n+\tconst union rte_ipsec_sad_key\t*keys_v6[nb_pkts];\n+\tvoid *v4_res[nb_pkts];\n+\tvoid *v6_res[nb_pkts];\n+\n+\tfor (i = 0; i < nb_pkts; i++) {\n+\t\tipv4 = rte_pktmbuf_mtod(pkts[i], struct rte_ipv4_hdr *);\n+\t\tesp = rte_pktmbuf_mtod_offset(pkts[i], struct rte_esp_hdr *,\n+\t\t\t\tpkts[i]->l3_len);\n+\t\tif ((ipv4->version_ihl >> 4) == IPVERSION) {\n+\t\t\tv4[nb_v4].spi = esp->spi;\n+\t\t\tv4[nb_v4].dip = ipv4->dst_addr;\n+\t\t\tv4[nb_v4].sip = ipv4->src_addr;\n+\t\t\tkeys_v4[nb_v4] = (const union rte_ipsec_sad_key *)\n+\t\t\t\t\t\t&v4[nb_v4];\n+\t\t\tv4_idxes[nb_v4++] = i;\n+\t\t} else {\n+\t\t\tipv6 = rte_pktmbuf_mtod(pkts[i], struct rte_ipv6_hdr *);\n+\t\t\tv6[nb_v6].spi = esp->spi;\n+\t\t\tmemcpy(v6[nb_v6].dip, ipv6->dst_addr,\n+\t\t\t\t\tsizeof(ipv6->dst_addr));\n+\t\t\tmemcpy(v6[nb_v6].sip, ipv6->src_addr,\n+\t\t\t\t\tsizeof(ipv6->src_addr));\n+\t\t\tkeys_v6[nb_v6] = (const union rte_ipsec_sad_key *)\n+\t\t\t\t\t\t&v6[nb_v6];\n+\t\t\tv6_idxes[nb_v6++] = i;\n+\t\t}\n+\t}\n+\n+\tif (nb_v4 != 0)\n+\t\trte_ipsec_sad_lookup(sad->sad_v4, keys_v4, v4_res, nb_v4);\n+\tif (nb_v6 != 0)\n+\t\trte_ipsec_sad_lookup(sad->sad_v6, keys_v6, v6_res, nb_v6);\n+\n+\tfor (i = 0; i < nb_v4; i++)\n+\t\tsa[v4_idxes[i]] = v4_res[i];\n+\n+\tfor (i = 0; i < nb_v6; i++)\n+\t\tsa[v6_idxes[i]] = v6_res[i];\n+}\n+\n+#endif /* __SAD_H__ */\n", "prefixes": [ "v4", "2/5" ] }