Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64609/?format=api
{ "id": 64609, "url": "http://patches.dpdk.org/api/patches/64609/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200114051435.46093-7-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200114051435.46093-7-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200114051435.46093-7-ajit.khaparde@broadcom.com", "date": "2020-01-14T05:14:31", "name": "[v3,06/10] net/bnxt: handle HW filter setting when port is stopped", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "eec44e4a8cb3f78f838610671ce8183b80f2b62e", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200114051435.46093-7-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 8097, "url": "http://patches.dpdk.org/api/series/8097/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8097", "date": "2020-01-14T05:14:25", "name": "bnxt patchset with bug fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/8097/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64609/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64609/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE7C5A04FD;\n\tTue, 14 Jan 2020 06:17:37 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 73CA41C43A;\n\tTue, 14 Jan 2020 06:16:46 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id DD7971C2AE\n for <dev@dpdk.org>; Tue, 14 Jan 2020 06:16:33 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 4C5F830C55E;\n Mon, 13 Jan 2020 21:10:22 -0800 (PST)", "from localhost.localdomain (unknown [10.230.30.124])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 6E56D14008C;\n Mon, 13 Jan 2020 21:16:32 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 4C5F830C55E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1578978622;\n bh=VBjCAyTYqCoXGekX6yKfIZYFc5a0qRgz+GoWH4BSW+E=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=JzDSVur6siXHAxGlI3990s1PSZXXZ7TjyKD8yJdWOHDBbZyIEDEU5kMBxoH0BWvqJ\n 6adYYs6lFIM6o4dpnPqOjXpUOMX+dFe6P6iow9tzR7d3q9uoJa244UI/KMJSsus129\n YCt0YAXHUV6bBikuSS+1j82Weu357SwZ1zYlrjXw=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Mon, 13 Jan 2020 21:14:31 -0800", "Message-Id": "<20200114051435.46093-7-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.0 (Apple Git-122.2)", "In-Reply-To": "<20200114051435.46093-1-ajit.khaparde@broadcom.com>", "References": "<20200113050118.28719-1-kalesh-anakkur.purayil@broadcom.com>\n <20200114051435.46093-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 06/10] net/bnxt: handle HW filter setting when\n\tport is stopped", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nDriver destroy the vnic when the port is brought down.\nPort hw filter setting such as promiscuos, allmulti and\nvlan filtering will be applied when port is started.\n\nFixed to return success silently for these callbacks\nwhen port is stopped. Also fixed to clear \"bp->dev_stopped\"\nbefore invoking bnxt_vlan_offload_set_op() in bnxt_dev_start_op().\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 23 ++++++++++++++++++++++-\n 1 file changed, 22 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 0b2c29bc8..436ecbb84 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -870,6 +870,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \teth_dev->data->scattered_rx = bnxt_scattered_rx(eth_dev);\n \n \tbnxt_link_update(eth_dev, 1, ETH_LINK_UP);\n+\tbp->dev_stopped = 0;\n \n \tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)\n \t\tvlan_mask |= ETH_VLAN_FILTER_MASK;\n@@ -884,7 +885,6 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \n \tbp->flags |= BNXT_FLAG_INIT_DONE;\n \teth_dev->data->dev_started = 1;\n-\tbp->dev_stopped = 0;\n \tpthread_mutex_lock(&bp->def_cp_lock);\n \tbnxt_schedule_fw_health_check(bp);\n \tpthread_mutex_unlock(&bp->def_cp_lock);\n@@ -895,6 +895,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \tbnxt_shutdown_nic(bp);\n \tbnxt_free_tx_mbufs(bp);\n \tbnxt_free_rx_mbufs(bp);\n+\tbp->dev_stopped = 1;\n \treturn rc;\n }\n \n@@ -1168,6 +1169,10 @@ static int bnxt_promiscuous_enable_op(struct rte_eth_dev *eth_dev)\n \tif (rc)\n \t\treturn rc;\n \n+\t/* Filter settings will get applied when port is started */\n+\tif (bp->dev_stopped == 1)\n+\t\treturn 0;\n+\n \tif (bp->vnic_info == NULL)\n \t\treturn 0;\n \n@@ -1193,6 +1198,10 @@ static int bnxt_promiscuous_disable_op(struct rte_eth_dev *eth_dev)\n \tif (rc)\n \t\treturn rc;\n \n+\t/* Filter settings will get applied when port is started */\n+\tif (bp->dev_stopped == 1)\n+\t\treturn 0;\n+\n \tif (bp->vnic_info == NULL)\n \t\treturn 0;\n \n@@ -1218,6 +1227,10 @@ static int bnxt_allmulticast_enable_op(struct rte_eth_dev *eth_dev)\n \tif (rc)\n \t\treturn rc;\n \n+\t/* Filter settings will get applied when port is started */\n+\tif (bp->dev_stopped == 1)\n+\t\treturn 0;\n+\n \tif (bp->vnic_info == NULL)\n \t\treturn 0;\n \n@@ -1243,6 +1256,10 @@ static int bnxt_allmulticast_disable_op(struct rte_eth_dev *eth_dev)\n \tif (rc)\n \t\treturn rc;\n \n+\t/* Filter settings will get applied when port is started */\n+\tif (bp->dev_stopped == 1)\n+\t\treturn 0;\n+\n \tif (bp->vnic_info == NULL)\n \t\treturn 0;\n \n@@ -1963,6 +1980,10 @@ bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask)\n \tif (rc)\n \t\treturn rc;\n \n+\t/* Filter settings will get applied when port is started */\n+\tif (bp->dev_stopped == 1)\n+\t\treturn 0;\n+\n \tif (mask & ETH_VLAN_FILTER_MASK) {\n \t\t/* Enable or disable VLAN filtering */\n \t\trc = bnxt_config_vlan_hw_filter(bp, rx_offloads);\n", "prefixes": [ "v3", "06/10" ] }