Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64577/?format=api
{ "id": 64577, "url": "http://patches.dpdk.org/api/patches/64577/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200113191239.22750-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200113191239.22750-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200113191239.22750-2-stephen@networkplumber.org", "date": "2020-01-13T19:12:38", "name": "[1/2] net/netvsc: fix crash in secondary process", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6e5d3df6eb1aec0da4e7887b522da52de3618798", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200113191239.22750-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 8088, "url": "http://patches.dpdk.org/api/series/8088/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8088", "date": "2020-01-13T19:12:37", "name": "net/netvsc: fix secondary process issues", "version": 1, "mbox": "http://patches.dpdk.org/series/8088/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64577/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64577/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DD487A04F1;\n\tMon, 13 Jan 2020 20:13:01 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 85CA01D174;\n\tMon, 13 Jan 2020 20:12:53 +0100 (CET)", "from mail-pj1-f68.google.com (mail-pj1-f68.google.com\n [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id ABEB11D153\n for <dev@dpdk.org>; Mon, 13 Jan 2020 20:12:49 +0100 (CET)", "by mail-pj1-f68.google.com with SMTP id a6so4564128pjh.2\n for <dev@dpdk.org>; Mon, 13 Jan 2020 11:12:49 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id f127sm15173723pfa.112.2020.01.13.11.12.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Jan 2020 11:12:47 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=yxIj6A0D1SZJ0xZvJ1qpglRW/a91k/5yg0nEiDGuLuA=;\n b=GJGD8WdY+m1cRU4uRySvlFV3Bzo8yHFBOSy1zmdmQ30nhQwd/qVjttoQDNDcAPz8yp\n GuVsfUe7RwY8oQ7kJ3RZoD1wTGJ6ygxnr9KSll30dcMEjcjcSvEvRqFjaljoxYqDGuIK\n 1Ao16geo9Prr1Wio5kwy1FgmRI5i0gPufIfQ70f2JhEcZKVN6FhEsSI8ImB7YlDg1qrU\n 1xjlLQ5Q3pe/VOol4+pJz9rzlBBYdjVULln/DNVyKagEGNPmR0eE9XBmKzZr7Pj8sWSo\n MvxWzuqdiYT4hzFHJQRP5RGulgC9w9SeM9ARwlVM2MR4BTDbjC4hk1b/rT/biRSNyvIx\n 1oBA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=yxIj6A0D1SZJ0xZvJ1qpglRW/a91k/5yg0nEiDGuLuA=;\n b=Q8yzAynsUDtgJg86rG07fth/iLa/0srGHhy1HnCp0/B4CQ+pTHgnqKuMISvceL1+69\n M1FAbpu+LnwdP08VOUJy8o9iDq2LlDZWgR3KWueJnOntdief+H09KFvJAdn4a4tBTzlH\n cUeIx7zEPgNq4X5VziKHNygwXPwNGb98/JmqjKSKI461sZggstNR5E5Xfh9VYS6oCD39\n hRusBUm9mVjgb2tJa7tmDnkirZF0WWDDOikdYRMiI5IbTL5yQW0aYEAQgyMz5bn9oPJf\n xlngpYDAv7z36NrK3p2MaOfgn55hKEWk8r2ajR4I7LN86ufyaJqRtFJH/Qh0iCuIHE0c\n aFCQ==", "X-Gm-Message-State": "APjAAAVMGemWI7rn/gy2kiBjRGfQHp4VJqts0UAia1nz573+IfdBwDxp\n cjMH+M35Xg3w5HtD82yeOYK7opYUWKo=", "X-Google-Smtp-Source": "\n APXvYqwL51btD+HwHPBx5hMM1KjSZQjzJeyVnqtdzuxiObWCTReqlePjE+hniU/7QvM2ybhQoSIIJA==", "X-Received": "by 2002:a17:90a:e28e:: with SMTP id\n d14mr24915790pjz.56.1578942768293;\n Mon, 13 Jan 2020 11:12:48 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tstable@dpdk.org", "Date": "Mon, 13 Jan 2020 11:12:38 -0800", "Message-Id": "<20200113191239.22750-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200113191239.22750-1-stephen@networkplumber.org>", "References": "<20200113191239.22750-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] net/netvsc: fix crash in secondary process", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The secondary process would crash trying to get the offload\ncapability of the device. Since the device capabilities were\nalready set by the primary process this was unnecessary.\n\nFixes: 4e9c73e96e83 (\"net/netvsc: add Hyper-V network device\")\nCc: stable@dpdk.org\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/netvsc/hn_ethdev.c | 17 +++++++++--------\n 1 file changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex 159116f7f691..c79f924379fe 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -257,15 +257,16 @@ static int hn_dev_info_get(struct rte_eth_dev *dev,\n \tdev_info->max_rx_queues = hv->max_queues;\n \tdev_info->max_tx_queues = hv->max_queues;\n \n-\trc = hn_rndis_get_offload(hv, dev_info);\n-\tif (rc != 0)\n-\t\treturn rc;\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn 0;\n \n-\trc = hn_vf_info_get(hv, dev_info);\n+\t/* fills in rx and tx offload capability */\n+\trc = hn_rndis_get_offload(hv, dev_info);\n \tif (rc != 0)\n \t\treturn rc;\n \n-\treturn 0;\n+\t/* merges the offload and queues of vf */\n+\treturn hn_vf_info_get(hv, dev_info);\n }\n \n static int hn_rss_reta_update(struct rte_eth_dev *dev,\n@@ -929,6 +930,9 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev)\n \teth_dev->tx_pkt_burst = &hn_xmit_pkts;\n \teth_dev->rx_pkt_burst = &hn_recv_pkts;\n \n+\t/* Since Hyper-V only supports one MAC address, just use local data */\n+\teth_dev->data->mac_addrs = &hv->mac_addr;\n+\n \t/*\n \t * for secondary processes, we don't initialize any further as primary\n \t * has already done this work.\n@@ -936,9 +940,6 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n-\t/* Since Hyper-V only supports one MAC address, just use local data */\n-\teth_dev->data->mac_addrs = &hv->mac_addr;\n-\n \thv->vmbus = vmbus;\n \thv->rxbuf_res = &vmbus->resource[HV_RECV_BUF_MAP];\n \thv->chim_res = &vmbus->resource[HV_SEND_BUF_MAP];\n", "prefixes": [ "1/2" ] }