Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64499/?format=api
{ "id": 64499, "url": "http://patches.dpdk.org/api/patches/64499/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200113023949.26718-36-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200113023949.26718-36-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200113023949.26718-36-xiaolong.ye@intel.com", "date": "2020-01-13T02:39:47", "name": "[v4,35/36] net/i40e/base: enable LED blinking flow", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7ce1a4f90d0ba1a56ac9988d4a75e7c1f7ffa9b1", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200113023949.26718-36-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 8064, "url": "http://patches.dpdk.org/api/series/8064/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8064", "date": "2020-01-13T02:39:12", "name": "update for i40e base code", "version": 4, "mbox": "http://patches.dpdk.org/series/8064/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64499/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64499/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EFC21A04F0;\n\tMon, 13 Jan 2020 03:52:07 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 099EA1D660;\n\tMon, 13 Jan 2020 03:48:17 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 963C21D5E5\n for <dev@dpdk.org>; Mon, 13 Jan 2020 03:47:45 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 12 Jan 2020 18:47:45 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.206])\n by FMSMGA003.fm.intel.com with ESMTP; 12 Jan 2020 18:47:44 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,427,1571727600\"; d=\"scan'208\";a=\"272916434\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org, Xiaolong Ye <xiaolong.ye@intel.com>,\n Damian Milosek <damian.milosek@intel.com>", "Date": "Mon, 13 Jan 2020 10:39:47 +0800", "Message-Id": "<20200113023949.26718-36-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200113023949.26718-1-xiaolong.ye@intel.com>", "References": "<20191202074935.97629-1-xiaolong.ye@intel.com>\n <20200113023949.26718-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 35/36] net/i40e/base: enable LED blinking flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add X710T*L device specific operations (in port LED detection and\nhandling of GLGEN_GPIO_CTL.PIN_FUNC field) to enable LED blinking.\n\nSigned-off-by: Damian Milosek <damian.milosek@intel.com>\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/base/i40e_common.c | 28 +++++++++++++++++++++++++---\n drivers/net/i40e/base/i40e_devids.h | 2 ++\n 2 files changed, 27 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex d0cb53a9d..84e67f285 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -1544,9 +1544,9 @@ static u32 i40e_led_is_mine(struct i40e_hw *hw, int idx)\n \tu32 gpio_val = 0;\n \tu32 port;\n \n-\tif (!hw->func_caps.led[idx])\n+\tif (!I40E_IS_X710TL_DEVICE(hw->device_id) &&\n+\t !hw->func_caps.led[idx])\n \t\treturn 0;\n-\n \tgpio_val = rd32(hw, I40E_GLGEN_GPIO_CTL(idx));\n \tport = (gpio_val & I40E_GLGEN_GPIO_CTL_PRT_NUM_MASK) >>\n \t\tI40E_GLGEN_GPIO_CTL_PRT_NUM_SHIFT;\n@@ -1565,8 +1565,15 @@ static u32 i40e_led_is_mine(struct i40e_hw *hw, int idx)\n #define I40E_FILTER_ACTIVITY 0xE\n #define I40E_LINK_ACTIVITY 0xC\n #define I40E_MAC_ACTIVITY 0xD\n+#define I40E_FW_LED BIT(4)\n+#define I40E_LED_MODE_VALID (I40E_GLGEN_GPIO_CTL_LED_MODE_MASK >> \\\n+\t\t\t I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT)\n+\n #define I40E_LED0 22\n \n+#define I40E_PIN_FUNC_SDP 0x0\n+#define I40E_PIN_FUNC_LED 0x1\n+\n /**\n * i40e_led_get - return current on/off mode\n * @hw: pointer to the hw struct\n@@ -1628,8 +1635,10 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)\n \tu32 current_mode = 0;\n \tint i;\n \n-\tif (mode & 0xfffffff0)\n+\tif (mode & ~I40E_LED_MODE_VALID) {\n \t\tDEBUGOUT1(\"invalid mode passed in %X\\n\", mode);\n+\t\treturn;\n+\t}\n \n \t/* as per the documentation GPIO 22-29 are the LED\n \t * GPIO pins named LED0..LED7\n@@ -1655,6 +1664,19 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)\n \t\t\tbreak;\n \t\t}\n \n+\t\tif (I40E_IS_X710TL_DEVICE(hw->device_id)) {\n+\t\t\tu32 pin_func = 0;\n+\n+\t\t\tif (mode & I40E_FW_LED)\n+\t\t\t\tpin_func = I40E_PIN_FUNC_SDP;\n+\t\t\telse\n+\t\t\t\tpin_func = I40E_PIN_FUNC_LED;\n+\n+\t\t\tgpio_val &= ~I40E_GLGEN_GPIO_CTL_PIN_FUNC_MASK;\n+\t\t\tgpio_val |= ((pin_func <<\n+\t\t\t\t I40E_GLGEN_GPIO_CTL_PIN_FUNC_SHIFT) &\n+\t\t\t\t I40E_GLGEN_GPIO_CTL_PIN_FUNC_MASK);\n+\t\t}\n \t\tgpio_val &= ~I40E_GLGEN_GPIO_CTL_LED_MODE_MASK;\n \t\t/* this & is a bit of paranoia, but serves as a range check */\n \t\tgpio_val |= ((mode << I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT) &\ndiff --git a/drivers/net/i40e/base/i40e_devids.h b/drivers/net/i40e/base/i40e_devids.h\nindex 1700db17a..5897d38f6 100644\n--- a/drivers/net/i40e/base/i40e_devids.h\n+++ b/drivers/net/i40e/base/i40e_devids.h\n@@ -38,6 +38,8 @@\n #endif\n #define I40E_DEV_ID_10G_B\t\t0x104F\n #define I40E_DEV_ID_10G_SFP\t\t0x104E\n+#define I40E_IS_X710TL_DEVICE(d) \\\n+\t((d) == I40E_DEV_ID_10G_BASE_T_BC)\n #define I40E_DEV_ID_KX_X722\t\t0x37CE\n #define I40E_DEV_ID_QSFP_X722\t\t0x37CF\n #define I40E_DEV_ID_SFP_X722\t\t0x37D0\n", "prefixes": [ "v4", "35/36" ] }