Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64227/?format=api
{ "id": 64227, "url": "http://patches.dpdk.org/api/patches/64227/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200106033851.43978-13-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200106033851.43978-13-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200106033851.43978-13-qi.z.zhang@intel.com", "date": "2020-01-06T03:38:51", "name": "[v2,12/12] net/ice/base: minor code clean", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8a51a953b511903912229bf035d21d24e0a294ac", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200106033851.43978-13-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 7984, "url": "http://patches.dpdk.org/api/series/7984/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7984", "date": "2020-01-06T03:38:39", "name": "base code update", "version": 2, "mbox": "http://patches.dpdk.org/series/7984/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64227/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64227/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49576A04F1;\n\tMon, 6 Jan 2020 04:37:39 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A91BB1D569;\n\tMon, 6 Jan 2020 04:36:08 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 4E6BF1D569\n for <dev@dpdk.org>; Mon, 6 Jan 2020 04:36:02 +0100 (CET)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 05 Jan 2020 19:36:01 -0800", "from dpdk51.sh.intel.com ([10.67.110.245])\n by fmsmga007.fm.intel.com with ESMTP; 05 Jan 2020 19:36:00 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,401,1571727600\"; d=\"scan'208\";a=\"216726377\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 6 Jan 2020 11:38:51 +0800", "Message-Id": "<20200106033851.43978-13-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200106033851.43978-1-qi.z.zhang@intel.com>", "References": "<20191205123847.39579-1-qi.z.zhang@intel.com>\n <20200106033851.43978-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 12/12] net/ice/base: minor code clean", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Couple minor code clean include:\n1. Improve debug message format.\n2. Add missing macro and comment.\n3. Remove unnecessary compile options.\n\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\nAcked-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/base/ice_adminq_cmd.h | 1 +\n drivers/net/ice/base/ice_common.c | 2 +-\n drivers/net/ice/base/ice_flex_pipe.c | 8 +++++---\n drivers/net/ice/base/ice_type.h | 4 ----\n 4 files changed, 7 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_adminq_cmd.h\nindex e6a1350ba..9a79c7645 100644\n--- a/drivers/net/ice/base/ice_adminq_cmd.h\n+++ b/drivers/net/ice/base/ice_adminq_cmd.h\n@@ -1688,6 +1688,7 @@ struct ice_aqc_nvm {\n #define ICE_AQC_NVM_ACTIV_SEL_NVM\tBIT(3) /* Write Activate/SR Dump only */\n #define ICE_AQC_NVM_ACTIV_SEL_OROM\tBIT(4)\n #define ICE_AQC_NVM_ACTIV_SEL_NETLIST\tBIT(5)\n+#define ICE_AQC_NVM_SPECIAL_UPDATE\tBIT(6)\n #define ICE_AQC_NVM_ACTIV_SEL_MASK\tMAKEMASK(0x7, 3)\n #define ICE_AQC_NVM_FLASH_ONLY\t\tBIT(7)\n \t__le16 module_typeid;\ndiff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex 22b2e316d..786e99d21 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -592,7 +592,7 @@ void ice_print_rollback_msg(struct ice_hw *hw)\n \tSNPRINTF(nvm_str, sizeof(nvm_str), \"%x.%02x 0x%x %d.%d.%d\", ver_hi,\n \t\t ver_lo, hw->nvm.eetrack, oem_ver, oem_build, oem_patch);\n \tice_warn(hw,\n-\t\t \"Firmware rollback mode detected. Current version is NVM: %s, FW: %d.%d. Device may exhibit limited functionality. Refer to the Intel(R) Ethernet Adapters and Devices User Guide for details on firmware rollback mode\",\n+\t\t \"Firmware rollback mode detected. Current version is NVM: %s, FW: %d.%d. Device may exhibit limited functionality. Refer to the Intel(R) Ethernet Adapters and Devices User Guide for details on firmware rollback mode\\n\",\n \t\t nvm_str, hw->fw_maj_ver, hw->fw_min_ver);\n }\n \ndiff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex 28ac3aa75..1598efd67 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -3069,7 +3069,8 @@ ice_free_prof_mask(struct ice_hw *hw, enum ice_block blk, u16 mask_idx)\n \thw->blk[blk].masks.masks[mask_idx].idx = 0;\n \n \t/* update mask as unused entry */\n-\tice_debug(hw, ICE_DBG_PKG, \"Free mask, blk %d, mask %d\", blk, mask_idx);\n+\tice_debug(hw, ICE_DBG_PKG, \"Free mask, blk %d, mask %d\\n\", blk,\n+\t\t mask_idx);\n \tice_write_prof_mask_reg(hw, blk, mask_idx, 0, 0);\n \n exit_ice_free_prof_mask:\n@@ -4173,7 +4174,7 @@ ice_upd_prof_hw(struct ice_hw *hw, enum ice_block blk,\n \t/* update package */\n \tstatus = ice_update_pkg(hw, ice_pkg_buf(b), 1);\n \tif (status == ICE_ERR_AQ_ERROR)\n-\t\tice_debug(hw, ICE_DBG_INIT, \"Unable to update HW profile.\");\n+\t\tice_debug(hw, ICE_DBG_INIT, \"Unable to update HW profile\\n\");\n \n error_tmp:\n \tice_pkg_buf_free(hw, b);\n@@ -5227,7 +5228,7 @@ ice_adj_prof_priorities(struct ice_hw *hw, enum ice_block blk, u16 vsig,\n * @blk: hardware block\n * @vsig: the VSIG to which this profile is to be added\n * @hdl: the profile handle indicating the profile to add\n- * @rev: true to reverse the additions to the list\n+ * @rev: true to add entries to the end of the list\n * @chg: the change list\n */\n static enum ice_status\n@@ -5379,6 +5380,7 @@ ice_create_prof_id_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl,\n * @blk: hardware block\n * @vsi: the initial VSI that will be in VSIG\n * @lst: the list of profile that will be added to the VSIG\n+ * @new_vsig: return of new vsig\n * @chg: the change list\n */\n static enum ice_status\ndiff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h\nindex a8e4229a1..9773a549f 100644\n--- a/drivers/net/ice/base/ice_type.h\n+++ b/drivers/net/ice/base/ice_type.h\n@@ -14,9 +14,7 @@\n \n #define BITS_PER_BYTE\t8\n \n-#ifndef _FORCE_\n #define _FORCE_\n-#endif\n \n #define ICE_BYTES_PER_WORD\t2\n #define ICE_BYTES_PER_DWORD\t4\n@@ -130,9 +128,7 @@ static inline u32 ice_round_to_num(u32 N, u32 R)\n #define ICE_DBG_USER\t\tBIT_ULL(31)\n #define ICE_DBG_ALL\t\t0xFFFFFFFFFFFFFFFFULL\n \n-#ifndef __ALWAYS_UNUSED\n #define __ALWAYS_UNUSED\n-#endif\n \n #define IS_ETHER_ADDR_EQUAL(addr1, addr2) \\\n \t(((bool)((((u16 *)(addr1))[0] == ((u16 *)(addr2))[0]))) && \\\n", "prefixes": [ "v2", "12/12" ] }