Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64173/?format=api
{ "id": 64173, "url": "http://patches.dpdk.org/api/patches/64173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200102174838.12908-5-dharmik.thakkar@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200102174838.12908-5-dharmik.thakkar@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200102174838.12908-5-dharmik.thakkar@arm.com", "date": "2020-01-02T17:48:35", "name": "[v2,4/7] net/bnx2x: remove 'typedef int bool'", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f8f7bea363cc2786ab69bb50c4b87c5cbf40a12b", "submitter": { "id": 1108, "url": "http://patches.dpdk.org/api/people/1108/?format=api", "name": "Dharmik Thakkar", "email": "dharmik.thakkar@arm.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200102174838.12908-5-dharmik.thakkar@arm.com/mbox/", "series": [ { "id": 7966, "url": "http://patches.dpdk.org/api/series/7966/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7966", "date": "2020-01-02T17:48:31", "name": "remove 'typedef int bool'", "version": 2, "mbox": "http://patches.dpdk.org/series/7966/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64173/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64173/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A5F46A04F3;\n\tThu, 2 Jan 2020 18:50:04 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DD9621C1BD;\n\tThu, 2 Jan 2020 18:49:27 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 0EBC11C192\n for <dev@dpdk.org>; Thu, 2 Jan 2020 18:49:17 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4E2E111B3;\n Thu, 2 Jan 2020 09:49:16 -0800 (PST)", "from dp6132.usa.Arm.com (dp6132.usa.arm.com [10.118.91.150])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 487603F703;\n Thu, 2 Jan 2020 09:49:16 -0800 (PST)" ], "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "To": "Rasesh Mody <rmody@marvell.com>,\n\tShahed Shaikh <shshaikh@marvell.com>", "Cc": "dev@dpdk.org,\n\tDharmik Thakkar <dharmik.thakkar@arm.com>", "Date": "Thu, 2 Jan 2020 17:48:35 +0000", "Message-Id": "<20200102174838.12908-5-dharmik.thakkar@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200102174838.12908-1-dharmik.thakkar@arm.com>", "References": "<20191003224419.23968-1-dharmik.thakkar@arm.com>\n <20200102174838.12908-1-dharmik.thakkar@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 4/7] net/bnx2x: remove 'typedef int bool'", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace 'typedef int bool' with 'stdbool.h' to avoid possible\nmultiple definitions of 'bool'.\n\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/bnx2x/bnx2x_ethdev.h | 4 +--\n drivers/net/bnx2x/ecore_sp.c | 46 ++++++++++++++++----------------\n 2 files changed, 24 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x_ethdev.h b/drivers/net/bnx2x/bnx2x_ethdev.h\nindex bd3ef143b63d..f712bb3e84c6 100644\n--- a/drivers/net/bnx2x/bnx2x_ethdev.h\n+++ b/drivers/net/bnx2x/bnx2x_ethdev.h\n@@ -15,6 +15,7 @@\n \n #include <stdio.h>\n #include <stdlib.h>\n+#include <stdbool.h>\n #include <errno.h>\n #include <stdint.h>\n #include <string.h>\n@@ -47,9 +48,6 @@\n #define FALSE 0\n #define TRUE 1\n \n-typedef int bool;\n-#define false 0\n-#define true 1\n #define min(a,b) RTE_MIN(a,b)\n \n #define mb() rte_mb()\ndiff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c\nindex b9bca9115e60..00c33a317512 100644\n--- a/drivers/net/bnx2x/ecore_sp.c\n+++ b/drivers/net/bnx2x/ecore_sp.c\n@@ -245,7 +245,7 @@ static struct ecore_exeq_elem *ecore_exe_queue_alloc_elem(struct\n }\n \n /************************ raw_obj functions ***********************************/\n-static int ecore_raw_check_pending(struct ecore_raw_obj *o)\n+static bool ecore_raw_check_pending(struct ecore_raw_obj *o)\n {\n \t/*\n \t * !! converts the value returned by ECORE_TEST_BIT such that it\n@@ -328,7 +328,7 @@ static int ecore_raw_wait(struct bnx2x_softc *sc, struct ecore_raw_obj *raw)\n \n /***************** Classification verbs: Set/Del MAC/VLAN/VLAN-MAC ************/\n /* credit handling callbacks */\n-static int ecore_get_cam_offset_mac(struct ecore_vlan_mac_obj *o, int *offset)\n+static bool ecore_get_cam_offset_mac(struct ecore_vlan_mac_obj *o, int *offset)\n {\n \tstruct ecore_credit_pool_obj *mp = o->macs_pool;\n \n@@ -337,7 +337,7 @@ static int ecore_get_cam_offset_mac(struct ecore_vlan_mac_obj *o, int *offset)\n \treturn mp->get_entry(mp, offset);\n }\n \n-static int ecore_get_credit_mac(struct ecore_vlan_mac_obj *o)\n+static bool ecore_get_credit_mac(struct ecore_vlan_mac_obj *o)\n {\n \tstruct ecore_credit_pool_obj *mp = o->macs_pool;\n \n@@ -346,14 +346,14 @@ static int ecore_get_credit_mac(struct ecore_vlan_mac_obj *o)\n \treturn mp->get(mp, 1);\n }\n \n-static int ecore_put_cam_offset_mac(struct ecore_vlan_mac_obj *o, int offset)\n+static bool ecore_put_cam_offset_mac(struct ecore_vlan_mac_obj *o, int offset)\n {\n \tstruct ecore_credit_pool_obj *mp = o->macs_pool;\n \n \treturn mp->put_entry(mp, offset);\n }\n \n-static int ecore_put_credit_mac(struct ecore_vlan_mac_obj *o)\n+static bool ecore_put_credit_mac(struct ecore_vlan_mac_obj *o)\n {\n \tstruct ecore_credit_pool_obj *mp = o->macs_pool;\n \n@@ -661,7 +661,7 @@ static struct ecore_vlan_mac_registry_elem *ecore_check_mac_del(struct bnx2x_sof\n }\n \n /* check_move() callback */\n-static int ecore_check_move(struct bnx2x_softc *sc,\n+static bool ecore_check_move(struct bnx2x_softc *sc,\n \t\t\t struct ecore_vlan_mac_obj *src_o,\n \t\t\t struct ecore_vlan_mac_obj *dst_o,\n \t\t\t union ecore_classification_ramrod_data *data)\n@@ -686,7 +686,7 @@ static int ecore_check_move(struct bnx2x_softc *sc,\n \treturn TRUE;\n }\n \n-static int ecore_check_move_always_err(__rte_unused struct bnx2x_softc *sc,\n+static bool ecore_check_move_always_err(__rte_unused struct bnx2x_softc *sc,\n \t\t\t\t __rte_unused struct ecore_vlan_mac_obj\n \t\t\t\t *src_o, __rte_unused struct ecore_vlan_mac_obj\n \t\t\t\t *dst_o, __rte_unused union\n@@ -713,7 +713,7 @@ static uint8_t ecore_vlan_mac_get_rx_tx_flag(struct ecore_vlan_mac_obj\n }\n \n void ecore_set_mac_in_nig(struct bnx2x_softc *sc,\n-\t\t\t\t int add, unsigned char *dev_addr, int index)\n+\t\t\t\t bool add, unsigned char *dev_addr, int index)\n {\n \tuint32_t wb_data[2];\n \tuint32_t reg_offset = ECORE_PORT_ID(sc) ? NIG_REG_LLH1_FUNC_MEM :\n@@ -754,7 +754,7 @@ void ecore_set_mac_in_nig(struct bnx2x_softc *sc,\n *\n */\n static void ecore_vlan_mac_set_cmd_hdr_e2(struct ecore_vlan_mac_obj *o,\n-\t\t\t\t\t int add, int opcode,\n+\t\t\t\t\t bool add, int opcode,\n \t\t\t\t\t struct eth_classify_cmd_header\n \t\t\t\t\t *hdr)\n {\n@@ -803,7 +803,7 @@ static void ecore_set_one_mac_e2(struct bnx2x_softc *sc,\n \t (struct eth_classify_rules_ramrod_data *)(raw->rdata);\n \tint rule_cnt = rule_idx + 1, cmd = elem->cmd_data.vlan_mac.cmd;\n \tunion eth_classify_rule_cmd *rule_entry = &data->rules[rule_idx];\n-\tint add = (cmd == ECORE_VLAN_MAC_ADD) ? TRUE : FALSE;\n+\tbool add = (cmd == ECORE_VLAN_MAC_ADD) ? TRUE : FALSE;\n \tunsigned long *vlan_mac_flags = &elem->cmd_data.vlan_mac.vlan_mac_flags;\n \tuint8_t *mac = elem->cmd_data.vlan_mac.u.mac.mac;\n \n@@ -3117,12 +3117,12 @@ static void ecore_mcast_set_sched(struct ecore_mcast_obj *o)\n \tECORE_SMP_MB_AFTER_CLEAR_BIT();\n }\n \n-static int ecore_mcast_check_sched(struct ecore_mcast_obj *o)\n+static bool ecore_mcast_check_sched(struct ecore_mcast_obj *o)\n {\n \treturn ! !ECORE_TEST_BIT(o->sched_state, o->raw.pstate);\n }\n \n-static int ecore_mcast_check_pending(struct ecore_mcast_obj *o)\n+static bool ecore_mcast_check_pending(struct ecore_mcast_obj *o)\n {\n \treturn o->raw.check_pending(&o->raw) || o->check_sched(o);\n }\n@@ -3195,7 +3195,7 @@ void ecore_init_mcast_obj(struct bnx2x_softc *sc,\n * returns TRUE if (v + a) was less than u, and FALSE otherwise.\n *\n */\n-static int __atomic_add_ifless(ecore_atomic_t * v, int a, int u)\n+static bool __atomic_add_ifless(ecore_atomic_t *v, int a, int u)\n {\n \tint c, old;\n \n@@ -3223,7 +3223,7 @@ static int __atomic_add_ifless(ecore_atomic_t * v, int a, int u)\n * returns TRUE if (v - a) was more or equal than u, and FALSE\n * otherwise.\n */\n-static int __atomic_dec_ifmoe(ecore_atomic_t * v, int a, int u)\n+static bool __atomic_dec_ifmoe(ecore_atomic_t *v, int a, int u)\n {\n \tint c, old;\n \n@@ -3241,9 +3241,9 @@ static int __atomic_dec_ifmoe(ecore_atomic_t * v, int a, int u)\n \treturn TRUE;\n }\n \n-static int ecore_credit_pool_get(struct ecore_credit_pool_obj *o, int cnt)\n+static bool ecore_credit_pool_get(struct ecore_credit_pool_obj *o, int cnt)\n {\n-\tint rc;\n+\tbool rc;\n \n \tECORE_SMP_MB();\n \trc = __atomic_dec_ifmoe(&o->credit, cnt, 0);\n@@ -3252,9 +3252,9 @@ static int ecore_credit_pool_get(struct ecore_credit_pool_obj *o, int cnt)\n \treturn rc;\n }\n \n-static int ecore_credit_pool_put(struct ecore_credit_pool_obj *o, int cnt)\n+static bool ecore_credit_pool_put(struct ecore_credit_pool_obj *o, int cnt)\n {\n-\tint rc;\n+\tbool rc;\n \n \tECORE_SMP_MB();\n \n@@ -3276,14 +3276,14 @@ static int ecore_credit_pool_check(struct ecore_credit_pool_obj *o)\n \treturn cur_credit;\n }\n \n-static int ecore_credit_pool_always_TRUE(__rte_unused struct\n+static bool ecore_credit_pool_always_TRUE(__rte_unused struct\n \t\t\t\t\t ecore_credit_pool_obj *o,\n \t\t\t\t\t __rte_unused int cnt)\n {\n \treturn TRUE;\n }\n \n-static int ecore_credit_pool_get_entry(struct ecore_credit_pool_obj *o,\n+static bool ecore_credit_pool_get_entry(struct ecore_credit_pool_obj *o,\n \t\t\t\t int *offset)\n {\n \tint idx, vec, i;\n@@ -3312,7 +3312,7 @@ static int ecore_credit_pool_get_entry(struct ecore_credit_pool_obj *o,\n \treturn FALSE;\n }\n \n-static int ecore_credit_pool_put_entry(struct ecore_credit_pool_obj *o,\n+static bool ecore_credit_pool_put_entry(struct ecore_credit_pool_obj *o,\n \t\t\t\t int offset)\n {\n \tif (offset < o->base_pool_offset)\n@@ -3329,14 +3329,14 @@ static int ecore_credit_pool_put_entry(struct ecore_credit_pool_obj *o,\n \treturn TRUE;\n }\n \n-static int ecore_credit_pool_put_entry_always_TRUE(__rte_unused struct\n+static bool ecore_credit_pool_put_entry_always_TRUE(__rte_unused struct\n \t\t\t\t\t\t ecore_credit_pool_obj *o,\n \t\t\t\t\t\t __rte_unused int offset)\n {\n \treturn TRUE;\n }\n \n-static int ecore_credit_pool_get_entry_always_TRUE(__rte_unused struct\n+static bool ecore_credit_pool_get_entry_always_TRUE(__rte_unused struct\n \t\t\t\t\t\t ecore_credit_pool_obj *o,\n \t\t\t\t\t\t __rte_unused int *offset)\n {\n", "prefixes": [ "v2", "4/7" ] }