Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64169/?format=api
{ "id": 64169, "url": "http://patches.dpdk.org/api/patches/64169/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200102174838.12908-4-dharmik.thakkar@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200102174838.12908-4-dharmik.thakkar@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200102174838.12908-4-dharmik.thakkar@arm.com", "date": "2020-01-02T17:48:34", "name": "[v2,3/7] net/vmxnet3: remove 'typedef int bool'", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "46e999dad3686646008d1aa8640bcb0d30855504", "submitter": { "id": 1108, "url": "http://patches.dpdk.org/api/people/1108/?format=api", "name": "Dharmik Thakkar", "email": "dharmik.thakkar@arm.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200102174838.12908-4-dharmik.thakkar@arm.com/mbox/", "series": [ { "id": 7966, "url": "http://patches.dpdk.org/api/series/7966/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7966", "date": "2020-01-02T17:48:31", "name": "remove 'typedef int bool'", "version": 2, "mbox": "http://patches.dpdk.org/series/7966/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64169/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64169/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C367DA04F3;\n\tThu, 2 Jan 2020 18:49:33 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5054F1C1A2;\n\tThu, 2 Jan 2020 18:49:21 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id B38EF1C194\n for <dev@dpdk.org>; Thu, 2 Jan 2020 18:49:16 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 390D61063;\n Thu, 2 Jan 2020 09:49:16 -0800 (PST)", "from dp6132.usa.Arm.com (dp6132.usa.arm.com [10.118.91.150])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3490F3F703;\n Thu, 2 Jan 2020 09:49:16 -0800 (PST)" ], "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "To": "Yong Wang <yongwang@vmware.com>", "Cc": "dev@dpdk.org,\n\tDharmik Thakkar <dharmik.thakkar@arm.com>", "Date": "Thu, 2 Jan 2020 17:48:34 +0000", "Message-Id": "<20200102174838.12908-4-dharmik.thakkar@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200102174838.12908-1-dharmik.thakkar@arm.com>", "References": "<20191003224419.23968-1-dharmik.thakkar@arm.com>\n <20200102174838.12908-1-dharmik.thakkar@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 3/7] net/vmxnet3: remove 'typedef int bool'", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace 'typedef int bool' with 'stdbool.h' to avoid possible\nmultiple definitions of 'bool'.\nRemove 'typedef char Bool' and use 'bool' instead.\n\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/vmxnet3/base/vmxnet3_defs.h | 6 +++---\n drivers/net/vmxnet3/base/vmxnet3_osdep.h | 4 ++--\n 2 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h\nindex 296d7e54c330..8d62b3e116e6 100644\n--- a/drivers/net/vmxnet3/base/vmxnet3_defs.h\n+++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h\n@@ -577,7 +577,7 @@ enum vmxnet3_intr_type {\n typedef\n #include \"vmware_pack_begin.h\"\n struct Vmxnet3_IntrConf {\n- Bool autoMask;\n+ bool autoMask;\n uint8 numIntrs; /* # of interrupts */\n uint8 eventIntrIdx;\n uint8 modLevels[VMXNET3_MAX_INTRS]; /* moderation level for each intr */\n@@ -593,7 +593,7 @@ Vmxnet3_IntrConf;\n typedef\n #include \"vmware_pack_begin.h\"\n struct Vmxnet3_QueueStatus {\n- Bool stopped;\n+ bool stopped;\n uint8 _pad[3];\n __le32 error;\n }\n@@ -613,7 +613,7 @@ Vmxnet3_TxQueueCtrl;\n typedef\n #include \"vmware_pack_begin.h\"\n struct Vmxnet3_RxQueueCtrl {\n- Bool updateRxProd;\n+ bool updateRxProd;\n uint8 _pad[7];\n __le64 reserved;\n }\ndiff --git a/drivers/net/vmxnet3/base/vmxnet3_osdep.h b/drivers/net/vmxnet3/base/vmxnet3_osdep.h\nindex c9b92b049fe7..381a68db6957 100644\n--- a/drivers/net/vmxnet3/base/vmxnet3_osdep.h\n+++ b/drivers/net/vmxnet3/base/vmxnet3_osdep.h\n@@ -5,12 +5,12 @@\n #ifndef _VMXNET3_OSDEP_H\n #define _VMXNET3_OSDEP_H\n \n+#include <stdbool.h>\n+\n typedef uint64_t\tuint64;\n typedef uint32_t\tuint32;\n typedef uint16_t\tuint16;\n typedef uint8_t\t\tuint8;\n-typedef int\t\tbool;\n-typedef char\t\tBool;\n \n #ifndef UNLIKELY\n #define UNLIKELY(x) __builtin_expect((x),0)\n", "prefixes": [ "v2", "3/7" ] }