Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64116/?format=api
{ "id": 64116, "url": "http://patches.dpdk.org/api/patches/64116/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191223103840.2848732-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191223103840.2848732-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191223103840.2848732-1-bruce.richardson@intel.com", "date": "2019-12-23T10:38:40", "name": "[v2] build: explicitly enable sse4 for meson builds", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bfc8d49d651583856202dc1d700226b9ea7dec0f", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191223103840.2848732-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 7939, "url": "http://patches.dpdk.org/api/series/7939/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7939", "date": "2019-12-23T10:38:40", "name": "[v2] build: explicitly enable sse4 for meson builds", "version": 2, "mbox": "http://patches.dpdk.org/series/7939/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64116/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64116/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 06E76A0352;\n\tMon, 23 Dec 2019 11:38:59 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6A1181C01;\n\tMon, 23 Dec 2019 11:38:58 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 7A5EA1F5\n for <dev@dpdk.org>; Mon, 23 Dec 2019 11:38:57 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 23 Dec 2019 02:38:56 -0800", "from silpixa00399126.ir.intel.com (HELO\n silpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n by orsmga005.jf.intel.com with ESMTP; 23 Dec 2019 02:38:55 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,347,1571727600\"; d=\"scan'208\";a=\"391548316\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "david.marchand@redhat.com", "Cc": "dev@dpdk.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Mon, 23 Dec 2019 10:38:40 +0000", "Message-Id": "<20191223103840.2848732-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20191217140838.2711906-1-bruce.richardson@intel.com>", "References": "<20191217140838.2711906-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] build: explicitly enable sse4 for meson builds", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If the compiler does not recognise the specific CPU when building with the\ndefault \"native\" machine type, sse4.2 instructions can be missing, causing\na build error. Rather than advising the user to change the machine type,\nwe can just turn on SSE4.2 directly. This can prevent issues with running\nautomated tests with older compilers/distros on newer hardware.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\nV2: insert missing quotes around \"-msse4\"\n---\n config/x86/meson.build | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/config/x86/meson.build b/config/x86/meson.build\nindex 8b0fa3e6f..adc857ba2 100644\n--- a/config/x86/meson.build\n+++ b/config/x86/meson.build\n@@ -15,11 +15,9 @@ if not is_windows\n endif\n \n # we require SSE4.2 for DPDK\n-sse_errormsg = '''SSE4.2 instruction set is required for DPDK.\n-Please set the machine type to \"nehalem\" or \"corei7\" or higher value'''\n-\n if cc.get_define('__SSE4_2__', args: machine_args) == ''\n-\terror(sse_errormsg)\n+\tmessage('SSE 4.2 not enabled by default, explicitly enabling')\n+\tmachine_args += '-msse4'\n endif\n \n base_flags = ['SSE', 'SSE2', 'SSE3','SSSE3', 'SSE4_1', 'SSE4_2']\n", "prefixes": [ "v2" ] }