Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 64055,
    "url": "http://patches.dpdk.org/api/patches/64055/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191220044524.32910-9-honnappa.nagarahalli@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191220044524.32910-9-honnappa.nagarahalli@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191220044524.32910-9-honnappa.nagarahalli@arm.com",
    "date": "2019-12-20T04:45:15",
    "name": "[v7,08/17] test/ring: remove duplicate test cases",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "220359d03b97ef80769f6d66de1a1629d47bcf5f",
    "submitter": {
        "id": 1045,
        "url": "http://patches.dpdk.org/api/people/1045/?format=api",
        "name": "Honnappa Nagarahalli",
        "email": "honnappa.nagarahalli@arm.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191220044524.32910-9-honnappa.nagarahalli@arm.com/mbox/",
    "series": [
        {
            "id": 7903,
            "url": "http://patches.dpdk.org/api/series/7903/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7903",
            "date": "2019-12-20T04:45:07",
            "name": "lib/ring: APIs to support custom element size",
            "version": 7,
            "mbox": "http://patches.dpdk.org/series/7903/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/64055/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/64055/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03D91A04F3;\n\tFri, 20 Dec 2019 05:47:03 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2707F1BF90;\n\tFri, 20 Dec 2019 05:46:16 +0100 (CET)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id D30B41BF78\n for <dev@dpdk.org>; Fri, 20 Dec 2019 05:45:58 +0100 (CET)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 63CE71396;\n Thu, 19 Dec 2019 20:45:57 -0800 (PST)",
            "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n [10.118.14.48])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E79F3F718;\n Thu, 19 Dec 2019 20:45:57 -0800 (PST)"
        ],
        "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>",
        "To": "olivier.matz@6wind.com, sthemmin@microsoft.com, jerinj@marvell.com,\n bruce.richardson@intel.com, david.marchand@redhat.com,\n pbhagavatula@marvell.com, konstantin.ananyev@intel.com,\n honnappa.nagarahalli@arm.com",
        "Cc": "dev@dpdk.org, dharmik.thakkar@arm.com, ruifeng.wang@arm.com,\n gavin.hu@arm.com, nd@arm.com",
        "Date": "Thu, 19 Dec 2019 22:45:15 -0600",
        "Message-Id": "<20191220044524.32910-9-honnappa.nagarahalli@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20191220044524.32910-1-honnappa.nagarahalli@arm.com>",
        "References": "<20190906190510.11146-1-honnappa.nagarahalli@arm.com>\n <20191220044524.32910-1-honnappa.nagarahalli@arm.com>",
        "Subject": "[dpdk-dev] [PATCH v7 08/17] test/ring: remove duplicate test cases",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The test cases in the function test_ring_basic are already covered\nby the function test_ring_burst_bulk_tests and others.\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\n---\n app/test/test_ring.c | 218 -------------------------------------------\n 1 file changed, 218 deletions(-)",
    "diff": "diff --git a/app/test/test_ring.c b/app/test/test_ring.c\nindex 552e8b53a..a082f0137 100644\n--- a/app/test/test_ring.c\n+++ b/app/test/test_ring.c\n@@ -200,206 +200,6 @@ test_ring_negative_tests(void)\n \treturn -1;\n }\n \n-static int\n-test_ring_basic(struct rte_ring *r)\n-{\n-\tvoid **src = NULL, **cur_src = NULL, **dst = NULL, **cur_dst = NULL;\n-\tint ret;\n-\tunsigned i, num_elems;\n-\n-\t/* alloc dummy object pointers */\n-\tsrc = malloc(RING_SIZE*2*sizeof(void *));\n-\tif (src == NULL)\n-\t\tgoto fail;\n-\n-\tfor (i = 0; i < RING_SIZE*2 ; i++) {\n-\t\tsrc[i] = (void *)(unsigned long)i;\n-\t}\n-\tcur_src = src;\n-\n-\t/* alloc some room for copied objects */\n-\tdst = malloc(RING_SIZE*2*sizeof(void *));\n-\tif (dst == NULL)\n-\t\tgoto fail;\n-\n-\tmemset(dst, 0, RING_SIZE*2*sizeof(void *));\n-\tcur_dst = dst;\n-\n-\tprintf(\"enqueue 1 obj\\n\");\n-\tret = rte_ring_sp_enqueue_bulk(r, cur_src, 1, NULL);\n-\tcur_src += 1;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\tprintf(\"enqueue 2 objs\\n\");\n-\tret = rte_ring_sp_enqueue_bulk(r, cur_src, 2, NULL);\n-\tcur_src += 2;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\tprintf(\"enqueue MAX_BULK objs\\n\");\n-\tret = rte_ring_sp_enqueue_bulk(r, cur_src, MAX_BULK, NULL);\n-\tcur_src += MAX_BULK;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\tprintf(\"dequeue 1 obj\\n\");\n-\tret = rte_ring_sc_dequeue_bulk(r, cur_dst, 1, NULL);\n-\tcur_dst += 1;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\tprintf(\"dequeue 2 objs\\n\");\n-\tret = rte_ring_sc_dequeue_bulk(r, cur_dst, 2, NULL);\n-\tcur_dst += 2;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\tprintf(\"dequeue MAX_BULK objs\\n\");\n-\tret = rte_ring_sc_dequeue_bulk(r, cur_dst, MAX_BULK, NULL);\n-\tcur_dst += MAX_BULK;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\t/* check data */\n-\tif (memcmp(src, dst, cur_dst - dst)) {\n-\t\trte_hexdump(stdout, \"src\", src, cur_src - src);\n-\t\trte_hexdump(stdout, \"dst\", dst, cur_dst - dst);\n-\t\tprintf(\"data after dequeue is not the same\\n\");\n-\t\tgoto fail;\n-\t}\n-\tcur_src = src;\n-\tcur_dst = dst;\n-\n-\tprintf(\"enqueue 1 obj\\n\");\n-\tret = rte_ring_mp_enqueue_bulk(r, cur_src, 1, NULL);\n-\tcur_src += 1;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\tprintf(\"enqueue 2 objs\\n\");\n-\tret = rte_ring_mp_enqueue_bulk(r, cur_src, 2, NULL);\n-\tcur_src += 2;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\tprintf(\"enqueue MAX_BULK objs\\n\");\n-\tret = rte_ring_mp_enqueue_bulk(r, cur_src, MAX_BULK, NULL);\n-\tcur_src += MAX_BULK;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\tprintf(\"dequeue 1 obj\\n\");\n-\tret = rte_ring_mc_dequeue_bulk(r, cur_dst, 1, NULL);\n-\tcur_dst += 1;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\tprintf(\"dequeue 2 objs\\n\");\n-\tret = rte_ring_mc_dequeue_bulk(r, cur_dst, 2, NULL);\n-\tcur_dst += 2;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\tprintf(\"dequeue MAX_BULK objs\\n\");\n-\tret = rte_ring_mc_dequeue_bulk(r, cur_dst, MAX_BULK, NULL);\n-\tcur_dst += MAX_BULK;\n-\tif (ret == 0)\n-\t\tgoto fail;\n-\n-\t/* check data */\n-\tif (memcmp(src, dst, cur_dst - dst)) {\n-\t\trte_hexdump(stdout, \"src\", src, cur_src - src);\n-\t\trte_hexdump(stdout, \"dst\", dst, cur_dst - dst);\n-\t\tprintf(\"data after dequeue is not the same\\n\");\n-\t\tgoto fail;\n-\t}\n-\tcur_src = src;\n-\tcur_dst = dst;\n-\n-\tprintf(\"fill and empty the ring\\n\");\n-\tfor (i = 0; i<RING_SIZE/MAX_BULK; i++) {\n-\t\tret = rte_ring_mp_enqueue_bulk(r, cur_src, MAX_BULK, NULL);\n-\t\tcur_src += MAX_BULK;\n-\t\tif (ret == 0)\n-\t\t\tgoto fail;\n-\t\tret = rte_ring_mc_dequeue_bulk(r, cur_dst, MAX_BULK, NULL);\n-\t\tcur_dst += MAX_BULK;\n-\t\tif (ret == 0)\n-\t\t\tgoto fail;\n-\t}\n-\n-\t/* check data */\n-\tif (memcmp(src, dst, cur_dst - dst)) {\n-\t\trte_hexdump(stdout, \"src\", src, cur_src - src);\n-\t\trte_hexdump(stdout, \"dst\", dst, cur_dst - dst);\n-\t\tprintf(\"data after dequeue is not the same\\n\");\n-\t\tgoto fail;\n-\t}\n-\n-\tcur_src = src;\n-\tcur_dst = dst;\n-\n-\tprintf(\"test default bulk enqueue / dequeue\\n\");\n-\tnum_elems = 16;\n-\n-\tcur_src = src;\n-\tcur_dst = dst;\n-\n-\tret = rte_ring_enqueue_bulk(r, cur_src, num_elems, NULL);\n-\tcur_src += num_elems;\n-\tif (ret == 0) {\n-\t\tprintf(\"Cannot enqueue\\n\");\n-\t\tgoto fail;\n-\t}\n-\tret = rte_ring_enqueue_bulk(r, cur_src, num_elems, NULL);\n-\tcur_src += num_elems;\n-\tif (ret == 0) {\n-\t\tprintf(\"Cannot enqueue\\n\");\n-\t\tgoto fail;\n-\t}\n-\tret = rte_ring_dequeue_bulk(r, cur_dst, num_elems, NULL);\n-\tcur_dst += num_elems;\n-\tif (ret == 0) {\n-\t\tprintf(\"Cannot dequeue\\n\");\n-\t\tgoto fail;\n-\t}\n-\tret = rte_ring_dequeue_bulk(r, cur_dst, num_elems, NULL);\n-\tcur_dst += num_elems;\n-\tif (ret == 0) {\n-\t\tprintf(\"Cannot dequeue2\\n\");\n-\t\tgoto fail;\n-\t}\n-\n-\t/* check data */\n-\tif (memcmp(src, dst, cur_dst - dst)) {\n-\t\trte_hexdump(stdout, \"src\", src, cur_src - src);\n-\t\trte_hexdump(stdout, \"dst\", dst, cur_dst - dst);\n-\t\tprintf(\"data after dequeue is not the same\\n\");\n-\t\tgoto fail;\n-\t}\n-\n-\tcur_src = src;\n-\tcur_dst = dst;\n-\n-\tret = rte_ring_mp_enqueue(r, cur_src);\n-\tif (ret != 0)\n-\t\tgoto fail;\n-\n-\tret = rte_ring_mc_dequeue(r, cur_dst);\n-\tif (ret != 0)\n-\t\tgoto fail;\n-\n-\tfree(src);\n-\tfree(dst);\n-\treturn 0;\n-\n- fail:\n-\tfree(src);\n-\tfree(dst);\n-\treturn -1;\n-}\n-\n /*\n  * Burst and bulk operations with sp/sc, mp/mc and default (during creation)\n  */\n@@ -856,7 +656,6 @@ static int\n test_ring(void)\n {\n \tunsigned int i, j;\n-\tstruct rte_ring *r = NULL;\n \n \t/* Negative test cases */\n \tif (test_ring_negative_tests() < 0)\n@@ -868,38 +667,21 @@ test_ring(void)\n \n \trte_atomic32_init(&synchro);\n \n-\tr = rte_ring_create(\"test\", RING_SIZE, SOCKET_ID_ANY, 0);\n-\tif (r == NULL)\n-\t\tgoto test_fail;\n-\n-\t/* retrieve the ring from its name */\n-\tif (rte_ring_lookup(\"test\") != r) {\n-\t\tprintf(\"Cannot lookup ring from its name\\n\");\n-\t\tgoto test_fail;\n-\t}\n-\n \t/* Burst and bulk operations with sp/sc, mp/mc and default */\n \tfor (j = TEST_RING_BL; j <= TEST_RING_BR; j <<= 1)\n \t\tfor (i = TEST_RING_N; i <= TEST_RING_M; i <<= 1)\n \t\t\tif (test_ring_burst_bulk_tests(i | j) < 0)\n \t\t\t\tgoto test_fail;\n \n-\t/* basic operations */\n-\tif (test_ring_basic(r) < 0)\n-\t\tgoto test_fail;\n-\n \tif (test_ring_with_exact_size() < 0)\n \t\tgoto test_fail;\n \n \t/* dump the ring status */\n \trte_ring_list_dump(stdout);\n \n-\trte_ring_free(r);\n-\n \treturn 0;\n \n test_fail:\n-\trte_ring_free(r);\n \n \treturn -1;\n }\n",
    "prefixes": [
        "v7",
        "08/17"
    ]
}