Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64054/?format=api
{ "id": 64054, "url": "http://patches.dpdk.org/api/patches/64054/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191220044524.32910-7-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191220044524.32910-7-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191220044524.32910-7-honnappa.nagarahalli@arm.com", "date": "2019-12-20T04:45:13", "name": "[v7,06/17] test/ring: rte_ring_xxx_elem test cases for exact size ring", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "08bebfbaecde14e6d80e4f08e7e12416e99f5074", "submitter": { "id": 1045, "url": "http://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191220044524.32910-7-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 7903, "url": "http://patches.dpdk.org/api/series/7903/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7903", "date": "2019-12-20T04:45:07", "name": "lib/ring: APIs to support custom element size", "version": 7, "mbox": "http://patches.dpdk.org/series/7903/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64054/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64054/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 55A46A04F3;\n\tFri, 20 Dec 2019 05:46:53 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AC6C11BF9D;\n\tFri, 20 Dec 2019 05:46:13 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id AAADD1BF73\n for <dev@dpdk.org>; Fri, 20 Dec 2019 05:45:58 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 386EC11FB;\n Thu, 19 Dec 2019 20:45:57 -0800 (PST)", "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n [10.118.14.48])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2D4093F718;\n Thu, 19 Dec 2019 20:45:57 -0800 (PST)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "olivier.matz@6wind.com, sthemmin@microsoft.com, jerinj@marvell.com,\n bruce.richardson@intel.com, david.marchand@redhat.com,\n pbhagavatula@marvell.com, konstantin.ananyev@intel.com,\n honnappa.nagarahalli@arm.com", "Cc": "dev@dpdk.org, dharmik.thakkar@arm.com, ruifeng.wang@arm.com,\n gavin.hu@arm.com, nd@arm.com", "Date": "Thu, 19 Dec 2019 22:45:13 -0600", "Message-Id": "<20191220044524.32910-7-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191220044524.32910-1-honnappa.nagarahalli@arm.com>", "References": "<20190906190510.11146-1-honnappa.nagarahalli@arm.com>\n <20191220044524.32910-1-honnappa.nagarahalli@arm.com>", "Subject": "[dpdk-dev] [PATCH v7 06/17] test/ring: rte_ring_xxx_elem test cases\n\tfor exact size ring", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Test cases for the exact size ring are changed to test\nrte_ring_xxx_elem APIs.\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\n---\n app/test/test_ring.c | 147 ++++++++++++++++++++++++++-----------------\n 1 file changed, 89 insertions(+), 58 deletions(-)", "diff": "diff --git a/app/test/test_ring.c b/app/test/test_ring.c\nindex 1025097c8..294e3ee10 100644\n--- a/app/test/test_ring.c\n+++ b/app/test/test_ring.c\n@@ -727,75 +727,106 @@ test_ring_basic_ex(void)\n \treturn -1;\n }\n \n+/*\n+ * Basic test cases with exact size ring.\n+ */\n static int\n test_ring_with_exact_size(void)\n {\n-\tstruct rte_ring *std_ring = NULL, *exact_sz_ring = NULL;\n-\tvoid *ptr_array[16];\n-\tstatic const unsigned int ring_sz = RTE_DIM(ptr_array);\n-\tunsigned int i;\n+\tstruct rte_ring *std_r = NULL, *exact_sz_r = NULL;\n+\tvoid *obj;\n+\tconst unsigned int ring_sz = 16;\n+\tunsigned int i, j;\n \tint ret = -1;\n \n-\tstd_ring = rte_ring_create(\"std\", ring_sz, rte_socket_id(),\n-\t\t\tRING_F_SP_ENQ | RING_F_SC_DEQ);\n-\tif (std_ring == NULL) {\n-\t\tprintf(\"%s: error, can't create std ring\\n\", __func__);\n-\t\tgoto end;\n-\t}\n-\texact_sz_ring = rte_ring_create(\"exact sz\", ring_sz, rte_socket_id(),\n-\t\t\tRING_F_SP_ENQ | RING_F_SC_DEQ | RING_F_EXACT_SZ);\n-\tif (exact_sz_ring == NULL) {\n-\t\tprintf(\"%s: error, can't create exact size ring\\n\", __func__);\n-\t\tgoto end;\n-\t}\n-\n-\t/*\n-\t * Check that the exact size ring is bigger than the standard ring\n-\t */\n-\tif (rte_ring_get_size(std_ring) >= rte_ring_get_size(exact_sz_ring)) {\n-\t\tprintf(\"%s: error, std ring (size: %u) is not smaller than exact size one (size %u)\\n\",\n-\t\t\t\t__func__,\n-\t\t\t\trte_ring_get_size(std_ring),\n-\t\t\t\trte_ring_get_size(exact_sz_ring));\n-\t\tgoto end;\n-\t}\n-\t/*\n-\t * check that the exact_sz_ring can hold one more element than the\n-\t * standard ring. (16 vs 15 elements)\n-\t */\n-\tfor (i = 0; i < ring_sz - 1; i++) {\n-\t\trte_ring_enqueue(std_ring, NULL);\n-\t\trte_ring_enqueue(exact_sz_ring, NULL);\n-\t}\n-\tif (rte_ring_enqueue(std_ring, NULL) != -ENOBUFS) {\n-\t\tprintf(\"%s: error, unexpected successful enqueue\\n\", __func__);\n-\t\tgoto end;\n-\t}\n-\tif (rte_ring_enqueue(exact_sz_ring, NULL) == -ENOBUFS) {\n-\t\tprintf(\"%s: error, enqueue failed\\n\", __func__);\n-\t\tgoto end;\n-\t}\n+\tfor (i = 0; i < RTE_DIM(esize); i++) {\n+\t\ttest_ring_print_test_string(\"Test exact size ring\",\n+\t\t\t\tTEST_RING_IGNORE_API_TYPE,\n+\t\t\t\tesize[i]);\n+\n+\t\t/* alloc object pointers */\n+\t\tobj = test_ring_calloc(16, esize[i]);\n+\t\tif (obj == NULL)\n+\t\t\tgoto test_fail;\n+\n+\t\tTEST_RING_CREATE(\"std\", esize[i], ring_sz, rte_socket_id(),\n+\t\t\t\t\tRING_F_SP_ENQ | RING_F_SC_DEQ, std_r);\n+\t\tif (std_r == NULL) {\n+\t\t\tprintf(\"%s: error, can't create std ring\\n\", __func__);\n+\t\t\tgoto test_fail;\n+\t\t}\n+\t\tTEST_RING_CREATE(\"exact sz\", esize[i], ring_sz, rte_socket_id(),\n+\t\t\t\tRING_F_SP_ENQ | RING_F_SC_DEQ | RING_F_EXACT_SZ,\n+\t\t\t\texact_sz_r);\n+\t\tif (exact_sz_r == NULL) {\n+\t\t\tprintf(\"%s: error, can't create exact size ring\\n\",\n+\t\t\t\t\t__func__);\n+\t\t\tgoto test_fail;\n+\t\t}\n \n-\t/* check that dequeue returns the expected number of elements */\n-\tif (rte_ring_dequeue_burst(exact_sz_ring, ptr_array,\n-\t\t\tRTE_DIM(ptr_array), NULL) != ring_sz) {\n-\t\tprintf(\"%s: error, failed to dequeue expected nb of elements\\n\",\n+\t\t/*\n+\t\t * Check that the exact size ring is bigger than the\n+\t\t * standard ring\n+\t\t */\n+\t\tif (rte_ring_get_size(std_r) >= rte_ring_get_size(exact_sz_r)) {\n+\t\t\tprintf(\"%s: error, std ring (size: %u) is not smaller than exact size one (size %u)\\n\",\n+\t\t\t\t\t__func__,\n+\t\t\t\t\trte_ring_get_size(std_r),\n+\t\t\t\t\trte_ring_get_size(exact_sz_r));\n+\t\t\tgoto test_fail;\n+\t\t}\n+\t\t/*\n+\t\t * check that the exact_sz_ring can hold one more element\n+\t\t * than the standard ring. (16 vs 15 elements)\n+\t\t */\n+\t\tfor (j = 0; j < ring_sz - 1; j++) {\n+\t\t\tTEST_RING_ENQUEUE(std_r, obj, esize[i], 1, ret,\n+\t\t\t\t\t\tTEST_RING_N | TEST_RING_SL);\n+\t\t\tTEST_RING_ENQUEUE(exact_sz_r, obj, esize[i], 1,\n+\t\t\t\t\tret, TEST_RING_N | TEST_RING_SL);\n+\t\t}\n+\t\tTEST_RING_ENQUEUE(std_r, obj, esize[i], 1, ret,\n+\t\t\t\t\t\tTEST_RING_N | TEST_RING_SL);\n+\t\tif (ret != -ENOBUFS) {\n+\t\t\tprintf(\"%s: error, unexpected successful enqueue\\n\",\n \t\t\t\t__func__);\n-\t\tgoto end;\n-\t}\n+\t\t\tgoto test_fail;\n+\t\t}\n+\t\tTEST_RING_ENQUEUE(exact_sz_r, obj, esize[i], 1, ret,\n+\t\t\t\t\t\tTEST_RING_N | TEST_RING_SL);\n+\t\tif (ret == -ENOBUFS) {\n+\t\t\tprintf(\"%s: error, enqueue failed\\n\", __func__);\n+\t\t\tgoto test_fail;\n+\t\t}\n \n-\t/* check that the capacity function returns expected value */\n-\tif (rte_ring_get_capacity(exact_sz_ring) != ring_sz) {\n-\t\tprintf(\"%s: error, incorrect ring capacity reported\\n\",\n+\t\t/* check that dequeue returns the expected number of elements */\n+\t\tTEST_RING_DEQUEUE(exact_sz_r, obj, esize[i], ring_sz,\n+\t\t\t\t\tret, TEST_RING_N | TEST_RING_BR);\n+\t\tif (ret != (int)ring_sz) {\n+\t\t\tprintf(\"%s: error, failed to dequeue expected nb of elements\\n\",\n \t\t\t\t__func__);\n-\t\tgoto end;\n+\t\t\tgoto test_fail;\n+\t\t}\n+\n+\t\t/* check that the capacity function returns expected value */\n+\t\tif (rte_ring_get_capacity(exact_sz_r) != ring_sz) {\n+\t\t\tprintf(\"%s: error, incorrect ring capacity reported\\n\",\n+\t\t\t\t\t__func__);\n+\t\t\tgoto test_fail;\n+\t\t}\n+\n+\t\trte_free(obj);\n+\t\trte_ring_free(std_r);\n+\t\trte_ring_free(exact_sz_r);\n \t}\n \n-\tret = 0; /* all ok if we get here */\n-end:\n-\trte_ring_free(std_ring);\n-\trte_ring_free(exact_sz_ring);\n-\treturn ret;\n+\treturn 0;\n+\n+test_fail:\n+\trte_free(obj);\n+\trte_ring_free(std_r);\n+\trte_ring_free(exact_sz_r);\n+\treturn -1;\n }\n \n static int\n", "prefixes": [ "v7", "06/17" ] }