Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 63945,
    "url": "http://patches.dpdk.org/api/patches/63945/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191217041755.29232-2-somnath.kotur@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191217041755.29232-2-somnath.kotur@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191217041755.29232-2-somnath.kotur@broadcom.com",
    "date": "2019-12-17T04:17:50",
    "name": "[1/6] net/bnxt: fix link failure during port toggle by increasing link wait time",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "65ec503b3d428698ab64e3f7f60253f98c161cbb",
    "submitter": {
        "id": 908,
        "url": "http://patches.dpdk.org/api/people/908/?format=api",
        "name": "Somnath Kotur",
        "email": "somnath.kotur@broadcom.com"
    },
    "delegate": {
        "id": 1766,
        "url": "http://patches.dpdk.org/api/users/1766/?format=api",
        "username": "ajitkhaparde",
        "first_name": "Ajit",
        "last_name": "Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191217041755.29232-2-somnath.kotur@broadcom.com/mbox/",
    "series": [
        {
            "id": 7857,
            "url": "http://patches.dpdk.org/api/series/7857/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7857",
            "date": "2019-12-17T04:17:49",
            "name": "bnxt patchset",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/7857/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/63945/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/63945/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DA25BA04F0;\n\tTue, 17 Dec 2019 05:18:38 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5EDE334EF;\n\tTue, 17 Dec 2019 05:18:34 +0100 (CET)",
            "from relay.smtp.broadcom.com (unknown [192.19.232.149])\n by dpdk.org (Postfix) with ESMTP id A8D08235\n for <dev@dpdk.org>; Tue, 17 Dec 2019 05:18:28 +0100 (CET)",
            "from dhcp-10-123-153-55.dhcp.broadcom.net\n (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 4F0251BE6AA;\n Mon, 16 Dec 2019 20:18:27 -0800 (PST)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 4F0251BE6AA",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1576556308;\n bh=MCqbCGspqvtzLA9X+Ucj2f06cYIVzJzpjGBHJtaEv9Q=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=b7oO+64w85YfBCyFtzheaOzQtNPIHe2ih2VQzKNFDCS4lzVfaahrjHbx9S/0cIOKo\n Q7GK6unjfcrsQ19SM7M+zsaADQDbJSJ0rP4KbaQd3VIsf7+3rnzPwFVzz96w5ERR8e\n aDd1A1V6VyOxt+iGqmbxIHOa8EIiRUmAGgE/RBik=",
        "From": "Somnath Kotur <somnath.kotur@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com",
        "Date": "Tue, 17 Dec 2019 09:47:50 +0530",
        "Message-Id": "<20191217041755.29232-2-somnath.kotur@broadcom.com>",
        "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70",
        "In-Reply-To": "<20191217041755.29232-1-somnath.kotur@broadcom.com>",
        "References": "<20191217041755.29232-1-somnath.kotur@broadcom.com>",
        "Subject": "[dpdk-dev] [PATCH 1/6] net/bnxt: fix link failure during port\n\ttoggle by increasing link wait time",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\n\nWe need to wait for up to 500ms to receive async event notification after\nforcing link down. Similarly we need to wait for up to 10s for link to\ncome up after configuring the hardware for link up.\n\nSigned-off-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h        | 10 ++++++----\n drivers/net/bnxt/bnxt_cpr.c    |  2 +-\n drivers/net/bnxt/bnxt_ethdev.c | 18 +++++++++++++-----\n 3 files changed, 20 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex bd8f660..257994d 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -231,9 +231,10 @@ struct bnxt_pf_info {\n \tuint8_t\t\t\tevb_mode;\n };\n \n-/* Max wait time is 10 * 100ms = 1s */\n-#define BNXT_LINK_WAIT_CNT\t10\n-#define BNXT_LINK_WAIT_INTERVAL\t100\n+/* Max wait time for link up is 10s and link down is 500ms */\n+#define BNXT_LINK_UP_WAIT_CNT\t200\n+#define BNXT_LINK_DOWN_WAIT_CNT\t10\n+#define BNXT_LINK_WAIT_INTERVAL\t50\n struct bnxt_link_info {\n \tuint32_t\t\tphy_flags;\n \tuint8_t\t\t\tmac_type;\n@@ -657,7 +658,8 @@ struct bnxt {\n };\n \n int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu);\n-int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete);\n+int bnxt_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete,\n+\t\t     bool exp_link_status);\n int bnxt_rcv_msg_from_vf(struct bnxt *bp, uint16_t vf_id, void *msg);\n int is_bnxt_in_error(struct bnxt *bp);\n uint16_t bnxt_rss_ctxts(const struct bnxt *bp);\ndiff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex 2c3129f..bb316b9 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -63,7 +63,7 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CHANGE:\n \tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE:\n \t\t/* FALLTHROUGH */\n-\t\tbnxt_link_update_op(bp->eth_dev, 0);\n+\t\tbnxt_link_update(bp->eth_dev, 0, ETH_LINK_UP);\n \t\tbreak;\n \tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PF_DRVR_UNLOAD:\n \t\tPMD_DRV_LOG(INFO, \"Async event: PF driver unloaded\\n\");\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 64f88e9..36905c2 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -859,7 +859,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \n \teth_dev->data->scattered_rx = bnxt_scattered_rx(eth_dev);\n \n-\tbnxt_link_update_op(eth_dev, 1);\n+\tbnxt_link_update(eth_dev, 1, ETH_LINK_UP);\n \n \tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)\n \t\tvlan_mask |= ETH_VLAN_FILTER_MASK;\n@@ -943,7 +943,7 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n \t * During reset recovery, there is no need to wait\n \t */\n \tif (!is_bnxt_in_error(bp))\n-\t\trte_delay_ms(BNXT_LINK_WAIT_INTERVAL * 2);\n+\t\tbnxt_link_update(eth_dev, 1, ETH_LINK_DOWN);\n \n \t/* Clean queue intr-vector mapping */\n \trte_intr_efd_disable(intr_handle);\n@@ -1094,12 +1094,14 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev,\n \treturn rc;\n }\n \n-int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)\n+int bnxt_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete,\n+\t\t     bool exp_link_status)\n {\n \tint rc = 0;\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n \tstruct rte_eth_link new;\n-\tunsigned int cnt = BNXT_LINK_WAIT_CNT;\n+\tint cnt = exp_link_status ? BNXT_LINK_UP_WAIT_CNT :\n+\t\t  BNXT_LINK_DOWN_WAIT_CNT;\n \n \trc = is_bnxt_in_error(bp);\n \tif (rc)\n@@ -1117,7 +1119,7 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)\n \t\t\tgoto out;\n \t\t}\n \n-\t\tif (!wait_to_complete || new.link_status)\n+\t\tif (!wait_to_complete || new.link_status == exp_link_status)\n \t\t\tbreak;\n \n \t\trte_delay_ms(BNXT_LINK_WAIT_INTERVAL);\n@@ -1139,6 +1141,12 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)\n \treturn rc;\n }\n \n+static int bnxt_link_update_op(struct rte_eth_dev *eth_dev,\n+\t\t\t       int wait_to_complete)\n+{\n+\treturn bnxt_link_update(eth_dev, wait_to_complete, ETH_LINK_UP);\n+}\n+\n static int bnxt_promiscuous_enable_op(struct rte_eth_dev *eth_dev)\n {\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n",
    "prefixes": [
        "1/6"
    ]
}