Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63826/?format=api
{ "id": 63826, "url": "http://patches.dpdk.org/api/patches/63826/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191212152124.260629-35-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191212152124.260629-35-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191212152124.260629-35-xiaolong.ye@intel.com", "date": "2019-12-12T15:21:22", "name": "[v2,34/36] net/i40e/base: add CRC stripping capability", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2f25747a42b71698a9cbdb24d8481862cb6e7307", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191212152124.260629-35-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 7813, "url": "http://patches.dpdk.org/api/series/7813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7813", "date": "2019-12-12T15:20:48", "name": "update for i40e base code", "version": 2, "mbox": "http://patches.dpdk.org/series/7813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63826/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63826/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 13A2AA04F5;\n\tThu, 12 Dec 2019 16:34:04 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1E3701C033;\n\tThu, 12 Dec 2019 16:29:16 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 885BB1BF9D\n for <dev@dpdk.org>; Thu, 12 Dec 2019 16:28:37 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 12 Dec 2019 07:28:37 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.186])\n by orsmga006.jf.intel.com with ESMTP; 12 Dec 2019 07:28:36 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,306,1571727600\"; d=\"scan'208\";a=\"216148458\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org,\n\tXiaolong Ye <xiaolong.ye@intel.com>", "Date": "Thu, 12 Dec 2019 23:21:22 +0800", "Message-Id": "<20191212152124.260629-35-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191212152124.260629-1-xiaolong.ye@intel.com>", "References": "<20191202074935.97629-1-xiaolong.ye@intel.com>\n <20191212152124.260629-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 34/36] net/i40e/base: add CRC stripping\n\tcapability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some VFs may want to disable CRC stripping on incoming packets\nso create an offload for that. The VF already sends information\nabout configuring it's RX queues so use that structure to\nindicate that the CRC stripping should be enabled or not.\n\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/base/i40e_dcb.h | 3 +--\n drivers/net/i40e/base/virtchnl.h | 12 ++++++++++--\n 2 files changed, 11 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_dcb.h b/drivers/net/i40e/base/i40e_dcb.h\nindex 520c7db73..60193c98d 100644\n--- a/drivers/net/i40e/base/i40e_dcb.h\n+++ b/drivers/net/i40e/base/i40e_dcb.h\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2001-2018\n+ * Copyright(c) 2001-2019\n */\n \n #ifndef _I40E_DCB_H_\n@@ -205,5 +205,4 @@ i40e_get_fw_lldp_status(struct i40e_hw *hw,\n enum i40e_status_code i40e_set_dcb_config(struct i40e_hw *hw);\n enum i40e_status_code i40e_dcb_config_to_lldp(u8 *lldpmib, u16 *miblen,\n \t\t\t\t\t struct i40e_dcbx_config *dcbcfg);\n-\n #endif /* _I40E_DCB_H_ */\ndiff --git a/drivers/net/i40e/base/virtchnl.h b/drivers/net/i40e/base/virtchnl.h\nindex c677d0eb5..c613d4761 100644\n--- a/drivers/net/i40e/base/virtchnl.h\n+++ b/drivers/net/i40e/base/virtchnl.h\n@@ -228,6 +228,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);\n #define VIRTCHNL_VF_OFFLOAD_RSS_REG\t\t0x00000010\n #define VIRTCHNL_VF_OFFLOAD_WB_ON_ITR\t\t0x00000020\n #define VIRTCHNL_VF_OFFLOAD_REQ_QUEUES\t\t0x00000040\n+#define VIRTCHNL_VF_OFFLOAD_CRC\t\t\t0x00000080\n #define VIRTCHNL_VF_OFFLOAD_VLAN\t\t0x00010000\n #define VIRTCHNL_VF_OFFLOAD_RX_POLLING\t\t0x00020000\n #define VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2\t0x00040000\n@@ -276,7 +277,13 @@ VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_txq_info);\n /* VIRTCHNL_OP_CONFIG_RX_QUEUE\n * VF sends this message to set up parameters for one RX queue.\n * External data buffer contains one instance of virtchnl_rxq_info.\n- * PF configures requested queue and returns a status code.\n+ * PF configures requested queue and returns a status code. The\n+ * crc_disable flag disables CRC stripping on the VF. Setting\n+ * the crc_disable flag to 1 will disable CRC stripping for each\n+ * queue in the VF where the flag is set. The VIRTCHNL_VF_OFFLOAD_CRC\n+ * offload must have been set prior to sending this info or the PF\n+ * will ignore the request. This flag should be set the same for\n+ * all of the queues for a VF.\n */\n \n /* Rx queue config info */\n@@ -288,7 +295,8 @@ struct virtchnl_rxq_info {\n \tu16 splithdr_enabled; /* deprecated with AVF 1.0 */\n \tu32 databuffer_size;\n \tu32 max_pkt_size;\n-\tu32 pad1;\n+\tu8 crc_disable;\n+\tu8 pad1[3];\n \tu64 dma_ring_addr;\n \tenum virtchnl_rx_hsplit rx_split_pos; /* deprecated with AVF 1.0 */\n \tu32 pad2;\n", "prefixes": [ "v2", "34/36" ] }