Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63739/?format=api
{ "id": 63739, "url": "http://patches.dpdk.org/api/patches/63739/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191211151823.128140-1-lunyuanx.cui@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191211151823.128140-1-lunyuanx.cui@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191211151823.128140-1-lunyuanx.cui@intel.com", "date": "2019-12-11T15:18:23", "name": "net/ixgbe: fixed port can not link up in FreeBSD", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3b8898093e52272f9facc01506f0c9230511c2ff", "submitter": { "id": 1420, "url": "http://patches.dpdk.org/api/people/1420/?format=api", "name": "Cui, LunyuanX", "email": "lunyuanx.cui@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191211151823.128140-1-lunyuanx.cui@intel.com/mbox/", "series": [ { "id": 7786, "url": "http://patches.dpdk.org/api/series/7786/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7786", "date": "2019-12-11T15:18:23", "name": "net/ixgbe: fixed port can not link up in FreeBSD", "version": 1, "mbox": "http://patches.dpdk.org/series/7786/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63739/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63739/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B036BA04F1;\n\tWed, 11 Dec 2019 08:23:24 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DE93B2C6A;\n\tWed, 11 Dec 2019 08:23:23 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 621701D9E;\n Wed, 11 Dec 2019 08:23:21 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 10 Dec 2019 23:23:19 -0800", "from intel.sh.intel.com ([10.239.255.129])\n by fmsmga002.fm.intel.com with ESMTP; 10 Dec 2019 23:23:18 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,301,1571727600\"; d=\"scan'208\";a=\"245138899\"", "From": "Lunyuan Cui <lunyuanx.cui@intel.com>", "To": "dev@dpdk.org", "Cc": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Lunyuan Cui <lunyuanx.cui@intel.com>,\n stable@dpdk.org", "Date": "Wed, 11 Dec 2019 15:18:23 +0000", "Message-Id": "<20191211151823.128140-1-lunyuanx.cui@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] net/ixgbe: fixed port can not link up in FreeBSD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In FreeBSD environment, nic_uio drivers do not support interrupts,\nrte_intr_callback_register() will fail to register interrupts.\nWe can not make link status to change from\ndown to up by interrupt callback.\nSo we need to wait for the controller to\nacquire link when ports start.\nThrough multiple tests, 5s should be enough.\n\nFixes: b9bd0f09fa15 (\"ethdev: fix link status query\")\nCc: stable@dpdk.org\n\nSigned-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 24 ++++++++++++++++++++++++\n 1 file changed, 24 insertions(+)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 2c6fd0f13..3023ee052 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2555,6 +2555,9 @@ ixgbe_dev_start(struct rte_eth_dev *dev)\n \t\tIXGBE_DEV_PRIVATE_TO_TM_CONF(dev->data->dev_private);\n \tstruct ixgbe_macsec_setting *macsec_setting =\n \t\tIXGBE_DEV_PRIVATE_TO_MACSEC_SETTING(dev->data->dev_private);\n+#ifdef RTE_EXEC_ENV_FREEBSD\n+\tint i;\n+#endif\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -2801,6 +2804,27 @@ ixgbe_dev_start(struct rte_eth_dev *dev)\n \t\t\t \"please call hierarchy_commit() \"\n \t\t\t \"before starting the port\");\n \n+\t/*\n+\t * In freebsd environment, nic_uio drivers do not support interrupts,\n+\t * rte_intr_callback_register() will fail to register interrupts.\n+\t * We can not make link status to change\n+\t * from down to up by interrupt callback.\n+\t * So we need to wait for the controller\n+\t * to acquire link when ports start.\n+\t */\n+#ifdef RTE_EXEC_ENV_FREEBSD\n+\tfor (i = 0; i < 25; i++) {\n+\t\t/* If we have link, just jump out */\n+\t\terr = ixgbe_check_link(hw, &speed, &link_up, 0);\n+\t\tif (err)\n+\t\t\tgoto error;\n+\t\tif (link_up)\n+\t\t\tbreak;\n+\t\t/* Wait for the link partner to also set speed */\n+\t\tmsec_delay(200);\n+\t}\n+#endif\n+\n \t/*\n \t * Update link status right before return, because it may\n \t * start link configuration process in a separate thread.\n", "prefixes": [] }